From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Neal Cardwell <ncardwell@google.com>,
Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] lib/win_minmax: use /* notation for regular comments
Date: Tue, 1 Sep 2026 09:32:33 +0200 [thread overview]
Message-ID: <apZ_kWb81yEVLt0N@black.igk.intel.com> (raw)
In-Reply-To: <20230102211614.26343-1-rdunlap@infradead.org>
On Mon, Jan 02, 2023 at 01:16:14PM -0800, Randy Dunlap wrote:
> Don't use kernel-doc "/**" notation for non-kernel-doc comments.
> Prevents a kernel-doc warning:
>
> lib/win_minmax.c:31: warning: expecting prototype for lib/minmax.c(). Prototype was for minmax_subwin_update() instead
...
> -/**
> +/*
> * lib/minmax.c: windowed min/max tracker
Side note (just stumbled over it today), if you fixing like this it also makes
sense to drop rather problematic filename in the file. Here is exactly a good
example why (it's not the same as on the filesystem and in general easy to go
south with time).
> *
> * Kathleen Nichols' algorithm for tracking the minimum (or maximum)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-01 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 21:16 Randy Dunlap
2026-09-01 7:32 ` Andy Shevchenko [this message]
2026-09-01 17:10 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apZ_kWb81yEVLt0N@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®