* [PATCH] lib/win_minmax: use /* notation for regular comments
@ 2023-01-02 21:16 Randy Dunlap
2026-09-01 7:32 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2023-01-02 21:16 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Neal Cardwell, Eric Dumazet, David S . Miller,
Andrew Morton
Don't use kernel-doc "/**" notation for non-kernel-doc comments.
Prevents a kernel-doc warning:
lib/win_minmax.c:31: warning: expecting prototype for lib/minmax.c(). Prototype was for minmax_subwin_update() instead
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Neal Cardwell <ncardwell@google.com>
Cc: Eric Dumazet <edumazet@google.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
lib/win_minmax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/lib/win_minmax.c b/lib/win_minmax.c
--- a/lib/win_minmax.c
+++ b/lib/win_minmax.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
-/**
+/*
* lib/minmax.c: windowed min/max tracker
*
* Kathleen Nichols' algorithm for tracking the minimum (or maximum)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/win_minmax: use /* notation for regular comments
2023-01-02 21:16 [PATCH] lib/win_minmax: use /* notation for regular comments Randy Dunlap
@ 2026-09-01 7:32 ` Andy Shevchenko
2026-09-01 17:10 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2026-09-01 7:32 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Neal Cardwell, Eric Dumazet, David S . Miller,
Andrew Morton
On Mon, Jan 02, 2023 at 01:16:14PM -0800, Randy Dunlap wrote:
> Don't use kernel-doc "/**" notation for non-kernel-doc comments.
> Prevents a kernel-doc warning:
>
> lib/win_minmax.c:31: warning: expecting prototype for lib/minmax.c(). Prototype was for minmax_subwin_update() instead
...
> -/**
> +/*
> * lib/minmax.c: windowed min/max tracker
Side note (just stumbled over it today), if you fixing like this it also makes
sense to drop rather problematic filename in the file. Here is exactly a good
example why (it's not the same as on the filesystem and in general easy to go
south with time).
> *
> * Kathleen Nichols' algorithm for tracking the minimum (or maximum)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/win_minmax: use /* notation for regular comments
2026-09-01 7:32 ` Andy Shevchenko
@ 2026-09-01 17:10 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2026-09-01 17:10 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-kernel, Neal Cardwell, Eric Dumazet, David S . Miller,
Andrew Morton
On 9/1/26 12:32 AM, Andy Shevchenko wrote:
> On Mon, Jan 02, 2023 at 01:16:14PM -0800, Randy Dunlap wrote:
>> Don't use kernel-doc "/**" notation for non-kernel-doc comments.
>> Prevents a kernel-doc warning:
>>
>> lib/win_minmax.c:31: warning: expecting prototype for lib/minmax.c(). Prototype was for minmax_subwin_update() instead
>
> ...
>
>> -/**
>> +/*
>> * lib/minmax.c: windowed min/max tracker
>
> Side note (just stumbled over it today), if you fixing like this it also makes
> sense to drop rather problematic filename in the file. Here is exactly a good
> example why (it's not the same as on the filesystem and in general easy to go
> south with time).
Ack. I'll try to do that in the future.
>> *
>> * Kathleen Nichols' algorithm for tracking the minimum (or maximum)
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-01 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-02 21:16 [PATCH] lib/win_minmax: use /* notation for regular comments Randy Dunlap
2026-09-01 7:32 ` Andy Shevchenko
2026-09-01 17:10 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®