From: "Shengzhuo Wei" <me@cherr.cc>
To: "Wei Fang" <wei.fang@nxp.com>
Cc: "Shengzhuo Wei" <me@cherr.cc>, "Frank Li" <frank.li@nxp.com>,
"Shenwei Wang" <shenwei.wang@nxp.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Troy Kisky" <troy.kisky@boundarydevices.com>,
"Fugang Duan" <fugang.duan@nxp.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Fugang Duan" <B38611@freescale.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH net 1/2] net: fec: don't leave a stale PTP clock pointer after unregister
Date: Fri, 4 Sep 2026 12:02:40 +0800 [thread overview]
Message-ID: <appC4LJ4B4NKtoRw@pve> (raw)
In-Reply-To: <GV2PR04MB11739E67E12529585010DEB7488B52@GV2PR04MB11739.eurprd04.prod.outlook.com>
On 2026-09-04 03:15, Wei Fang wrote:
> Why not move fec_ptp_stop() after unregister_netdev()?
Good point. I was focused on making the PHC index lookup safe
independently of the teardown ordering and followed the approach used by
similar fixes, so I overlooked the simpler solution here.
Moving fec_ptp_stop() after unregister_netdev() is cleaner and restores
the proper lifetime ordering. I will rework patch 1 accordingly and drop
the ptp_clock_index_by_dev() change in v2.
Thanks,
Shengzhuo
next prev parent reply other threads:[~2026-09-04 4:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 20:15 [PATCH net 0/2] net: fec: fix PTP clock teardown races on device removal Shengzhuo Wei
2026-09-03 20:15 ` [PATCH net 1/2] net: fec: don't leave a stale PTP clock pointer after unregister Shengzhuo Wei
2026-09-04 3:15 ` Wei Fang
2026-09-04 4:02 ` Shengzhuo Wei [this message]
2026-09-03 20:15 ` [PATCH net 2/2] net: fec: free the PPS interrupt before tearing down the PHC and netdev Shengzhuo Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=appC4LJ4B4NKtoRw@pve \
--to=me@cherr.cc \
--cc=B38611@freescale.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frank.li@nxp.com \
--cc=fugang.duan@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=shenwei.wang@nxp.com \
--cc=stable@vger.kernel.org \
--cc=troy.kisky@boundarydevices.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®