* [PATCH] gpio: crystalcove: add missing MODULE_ALIAS()
@ 2026-09-05 9:12 Dmitry Torokhov
2026-09-05 20:24 ` Linus Walleij
2026-09-06 8:36 ` Andy Shevchenko
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2026-09-05 9:12 UTC (permalink / raw)
To: Andy Shevchenko, Linus Walleij, Bartosz Golaszewski
Cc: linux-gpio, linux-kernel
The crystalcove GPIO driver lacks a MODULE_ALIAS() to allow it to be
auto-loaded.
Fix this by adding the missing platform alias.
Fixes: 104fb1d5153c ("gpio: Add support for Intel Crystal Cove PMIC")
Assisted-by: LLM
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/gpio/gpio-crystalcove.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c
index 0fb5c06d0886..ab7fab5b9754 100644
--- a/drivers/gpio/gpio-crystalcove.c
+++ b/drivers/gpio/gpio-crystalcove.c
@@ -396,3 +396,4 @@ module_platform_driver(crystalcove_gpio_driver);
MODULE_AUTHOR("Yang, Bin <bin.yang@intel.com>");
MODULE_DESCRIPTION("Intel Crystal Cove GPIO Driver");
MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:crystal_cove_gpio");
--
2.55.0.979.g7e5102b832-goog
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: crystalcove: add missing MODULE_ALIAS()
2026-09-05 9:12 [PATCH] gpio: crystalcove: add missing MODULE_ALIAS() Dmitry Torokhov
@ 2026-09-05 20:24 ` Linus Walleij
2026-09-06 8:36 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2026-09-05 20:24 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Andy Shevchenko, Bartosz Golaszewski, linux-gpio, linux-kernel
On Sat, Sep 5, 2026 at 11:12 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> The crystalcove GPIO driver lacks a MODULE_ALIAS() to allow it to be
> auto-loaded.
>
> Fix this by adding the missing platform alias.
>
> Fixes: 104fb1d5153c ("gpio: Add support for Intel Crystal Cove PMIC")
> Assisted-by: LLM
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: crystalcove: add missing MODULE_ALIAS()
2026-09-05 9:12 [PATCH] gpio: crystalcove: add missing MODULE_ALIAS() Dmitry Torokhov
2026-09-05 20:24 ` Linus Walleij
@ 2026-09-06 8:36 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2026-09-06 8:36 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Andy Shevchenko, Linus Walleij, Bartosz Golaszewski, linux-gpio,
linux-kernel
On Sat, Sep 05, 2026 at 02:12:39AM -0700, Dmitry Torokhov wrote:
> The crystalcove GPIO driver lacks a MODULE_ALIAS() to allow it to be
> auto-loaded.
>
> Fix this by adding the missing platform alias.
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-06 8:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-05 9:12 [PATCH] gpio: crystalcove: add missing MODULE_ALIAS() Dmitry Torokhov
2026-09-05 20:24 ` Linus Walleij
2026-09-06 8:36 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®