* [PATCH] PCI: eswin: Publish the platform driver's OF alias
@ 2026-09-05 13:42 hpp.iscas
2026-09-05 14:46 ` Nick Huang
2026-09-05 15:59 ` Manivannan Sadhasivam
0 siblings, 2 replies; 4+ messages in thread
From: hpp.iscas @ 2026-09-05 13:42 UTC (permalink / raw)
To: Senchuan Zhang
Cc: hpp.iscas, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, linux-pci,
linux-kernel, linux-riscv, Yu Ning, Yanghui Ou
The ESWIN PCIe host controller is a platform driver matched through
eswin_pcie_of_match. PCIE_ESWIN is tristate, but the table is not
published for OF module autoloading.
Publish this platform-device table. Do not change the RISC-V host
initialization sequence or PCI device matching.
Fixes: b593c26d081a ("PCI: eswin: Add ESWIN PCIe Root Complex driver")
Signed-off-by: hpp.iscas <hppiscas@163.com>
---
drivers/pci/controller/dwc/pcie-eswin.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pcie-eswin.c b/drivers/pci/controller/dwc/pcie-eswin.c
index ce8d64f..1bb4469 100644
--- a/drivers/pci/controller/dwc/pcie-eswin.c
+++ b/drivers/pci/controller/dwc/pcie-eswin.c
@@ -388,6 +388,7 @@ static const struct of_device_id eswin_pcie_of_match[] = {
{ .compatible = "eswin,eic7700-pcie", .data = &eswin_eic7700_data },
{}
};
+MODULE_DEVICE_TABLE(of, eswin_pcie_of_match);
static struct platform_driver eswin_pcie_driver = {
.probe = eswin_pcie_probe,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: eswin: Publish the platform driver's OF alias
2026-09-05 13:42 [PATCH] PCI: eswin: Publish the platform driver's OF alias hpp.iscas
@ 2026-09-05 14:46 ` Nick Huang
2026-09-05 15:55 ` Manivannan Sadhasivam
2026-09-05 15:59 ` Manivannan Sadhasivam
1 sibling, 1 reply; 4+ messages in thread
From: Nick Huang @ 2026-09-05 14:46 UTC (permalink / raw)
To: hpp.iscas
Cc: Senchuan Zhang, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, linux-pci,
linux-kernel, linux-riscv, Yu Ning, Yanghui Ou
On Sat, Sep 05, 2026 at 09:42:51PM +0800, hpp.iscas wrote:
> The ESWIN PCIe host controller is a platform driver matched through
> eswin_pcie_of_match. PCIE_ESWIN is tristate, but the table is not
> published for OF module autoloading.
>
> Publish this platform-device table. Do not change the RISC-V host
> initialization sequence or PCI device matching.
>
> Fixes: b593c26d081a ("PCI: eswin: Add ESWIN PCIe Root Complex driver")
> Signed-off-by: hpp.iscas <hppiscas@163.com>
> ---
> drivers/pci/controller/dwc/pcie-eswin.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-eswin.c b/drivers/pci/controller/dwc/pcie-eswin.c
> index ce8d64f..1bb4469 100644
> --- a/drivers/pci/controller/dwc/pcie-eswin.c
> +++ b/drivers/pci/controller/dwc/pcie-eswin.c
> @@ -388,6 +388,7 @@ static const struct of_device_id eswin_pcie_of_match[] = {
> { .compatible = "eswin,eic7700-pcie", .data = &eswin_eic7700_data },
> {}
> };
> +MODULE_DEVICE_TABLE(of, eswin_pcie_of_match);
>
> static struct platform_driver eswin_pcie_driver = {
> .probe = eswin_pcie_probe,
>
Hi hpp.iscas
Since this driver uses `builtin_platform_driver(eswin_pcie_driver)`, it
appears to be built-in only. In that case, `MODULE_DEVICE_TABLE()` seems
unnecessary.
Regards,
Nick Huang
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: eswin: Publish the platform driver's OF alias
2026-09-05 14:46 ` Nick Huang
@ 2026-09-05 15:55 ` Manivannan Sadhasivam
0 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2026-09-05 15:55 UTC (permalink / raw)
To: Nick Huang
Cc: hpp.iscas, Senchuan Zhang, Lorenzo Pieralisi,
Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas, linux-pci,
linux-kernel, linux-riscv, Yu Ning, Yanghui Ou
On Sat, Sep 05, 2026 at 02:46:41PM +0000, Nick Huang wrote:
> On Sat, Sep 05, 2026 at 09:42:51PM +0800, hpp.iscas wrote:
> > The ESWIN PCIe host controller is a platform driver matched through
> > eswin_pcie_of_match. PCIE_ESWIN is tristate, but the table is not
> > published for OF module autoloading.
> >
> > Publish this platform-device table. Do not change the RISC-V host
> > initialization sequence or PCI device matching.
> >
> > Fixes: b593c26d081a ("PCI: eswin: Add ESWIN PCIe Root Complex driver")
> > Signed-off-by: hpp.iscas <hppiscas@163.com>
> > ---
> > drivers/pci/controller/dwc/pcie-eswin.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-eswin.c b/drivers/pci/controller/dwc/pcie-eswin.c
> > index ce8d64f..1bb4469 100644
> > --- a/drivers/pci/controller/dwc/pcie-eswin.c
> > +++ b/drivers/pci/controller/dwc/pcie-eswin.c
> > @@ -388,6 +388,7 @@ static const struct of_device_id eswin_pcie_of_match[] = {
> > { .compatible = "eswin,eic7700-pcie", .data = &eswin_eic7700_data },
> > {}
> > };
> > +MODULE_DEVICE_TABLE(of, eswin_pcie_of_match);
> >
> > static struct platform_driver eswin_pcie_driver = {
> > .probe = eswin_pcie_probe,
> >
> Hi hpp.iscas
>
> Since this driver uses `builtin_platform_driver(eswin_pcie_driver)`, it
> appears to be built-in only. In that case, `MODULE_DEVICE_TABLE()` seems
> unnecessary.
>
Nope. builtin_platform_driver() only prevents removing the driver once loaded.
Since the driver is defined as 'tristate' in Kconfig, it can still be loaded
dynamically. So MODULE_DEVICE_TABLE() would still be necessary for udev to
autoload the module based on modalias.
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: eswin: Publish the platform driver's OF alias
2026-09-05 13:42 [PATCH] PCI: eswin: Publish the platform driver's OF alias hpp.iscas
2026-09-05 14:46 ` Nick Huang
@ 2026-09-05 15:59 ` Manivannan Sadhasivam
1 sibling, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2026-09-05 15:59 UTC (permalink / raw)
To: hpp.iscas
Cc: Senchuan Zhang, Lorenzo Pieralisi, Krzysztof Wilczyński,
Rob Herring, Bjorn Helgaas, linux-pci, linux-kernel, linux-riscv,
Yu Ning, Yanghui Ou
On Sat, Sep 05, 2026 at 09:42:51PM +0800, hpp.iscas wrote:
> The ESWIN PCIe host controller is a platform driver matched through
> eswin_pcie_of_match. PCIE_ESWIN is tristate, but the table is not
> published for OF module autoloading.
>
> Publish this platform-device table. Do not change the RISC-V host
> initialization sequence or PCI device matching.
>
> Fixes: b593c26d081a ("PCI: eswin: Add ESWIN PCIe Root Complex driver")
> Signed-off-by: hpp.iscas <hppiscas@163.com>
As per Linux Kernel DCO, a real name is required for the submitter/author.
Please refer: Documentation/process/submitting-patches.rst
'hpp.iscas' doesn't appear to be a real name.
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-05 15:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-05 13:42 [PATCH] PCI: eswin: Publish the platform driver's OF alias hpp.iscas
2026-09-05 14:46 ` Nick Huang
2026-09-05 15:55 ` Manivannan Sadhasivam
2026-09-05 15:59 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®