From: Drew Fustini <fustini@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v8 5/5] riscv_cbqri: Add CBQRI capacity allocation platform driver
Date: Fri, 18 Sep 2026 13:10:13 -0700 [thread overview]
Message-ID: <aq2apbFvv5mSPc82@thelio> (raw)
In-Reply-To: <20260917171116.1AD781F000FF@smtp.kernel.org>
On Thu, Sep 17, 2026 at 05:11:15PM +0000, sashiko-bot@kernel.org wrote:
[..]
> > + ret = of_property_read_u32(dev->of_node, "riscv,cbqri-rcid", &rcid_count);
> > + if (ret) {
> > + dev_err(dev, "missing riscv,cbqri-rcid\n");
> > + return ret;
> > + }
>
> [Severity: Medium]
> Does this unconditionally fail probe for valid monitoring-only capacity
> controllers?
Yes, because this is patch is only adding support for capacity
allocation.
The hardware I have access to only implements capacity allocation. I
plan to add monitoring support in a future series - hopefully with
feedback from vendors who are implementing monitoring support in
hardware.
Drew
prev parent reply other threads:[~2026-09-18 20:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 16:39 [PATCH v8 0/5] riscv: Add initial CBQRI resctrl support Drew Fustini
2026-09-17 16:39 ` [PATCH v8 1/5] riscv_cbqri: Add capacity controller probe and allocation device ops Drew Fustini
2026-09-17 16:39 ` [PATCH v8 2/5] riscv_cbqri: resctrl: Add cache allocation via capacity block mask Drew Fustini
2026-09-17 16:57 ` sashiko-bot
2026-09-17 19:59 ` Drew Fustini
2026-09-18 0:54 ` Reinette Chatre
2026-09-17 16:39 ` [PATCH v8 3/5] riscv_cbqri: Make RESCTRL_FS available on RISC-V Drew Fustini
2026-09-17 16:39 ` [PATCH v8 4/5] dt-bindings: riscv: Add binding for CBQRI controllers Drew Fustini
2026-09-17 16:39 ` [PATCH v8 5/5] riscv_cbqri: Add CBQRI capacity allocation platform driver Drew Fustini
2026-09-17 17:11 ` sashiko-bot
2026-09-18 20:10 ` Drew Fustini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq2apbFvv5mSPc82@thelio \
--to=fustini@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®