From: Dan Carpenter <error27@gmail.com>
To: "Rareș-Mihai Vladu" <vladurares@gmail.com>
Cc: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org,
gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: remove ia_css_circbuf_t typedef
Date: Sat, 19 Sep 2026 13:40:25 +0300 [thread overview]
Message-ID: <aq5mmSZeWXYBrs0o@stanley.mountain> (raw)
In-Reply-To: <20260918214132.1135549-1-vladurares@gmail.com>
On Fri, Sep 18, 2026 at 09:41:32PM +0000, Rareș-Mihai Vladu wrote:
> @@ -320,24 +319,24 @@ static inline uint32_t ia_css_circbuf_get_free_elems(
> * @brief Peek an element in Circular Buffer.
> *
> * @param cb The pointer to the circular buffer.
> - * @param offset Offset to the element.
> + * @param offset to the element.
Don't make unrelated changes like this. Also it's not really
correct. It's trying to describe "offset" using a sentence.
"Offset to the element." is a sentence but "to the element."
is not a sentence.
> *
> * @return the elements value.
> */
> uint32_t ia_css_circbuf_peek(
> - ia_css_circbuf_t *cb,
> + struct ia_css_circbuf_s *cb,
> int offset);
>
> /*
> * @brief Get an element in Circular Buffer.
> *
> * @param cb The pointer to the circular buffer.
> - * @param offset Offset to the element.
> + * @param offset to the element.
> *
Same.
regards,
dan carpenter
next prev parent reply other threads:[~2026-09-19 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 21:41 Rareș-Mihai Vladu
2026-09-19 10:40 ` Dan Carpenter [this message]
2026-09-19 14:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq5mmSZeWXYBrs0o@stanley.mountain \
--to=error27@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=vladurares@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®