From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Rareș-Mihai Vladu" <vladurares@gmail.com>
Cc: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org,
gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: remove ia_css_circbuf_t typedef
Date: Sat, 19 Sep 2026 17:12:02 +0300 [thread overview]
Message-ID: <aq6YMsRFmACGZUF-@ashevche-desk.local> (raw)
In-Reply-To: <20260918214132.1135549-1-vladurares@gmail.com>
On Fri, Sep 18, 2026 at 09:41:32PM +0000, Rareș-Mihai Vladu wrote:
> Remove typedef ia_css_circbuf_t and use struct ia_css_circbuf_s
> directly, as per kernel coding style (chapter 5).
...
> void ia_css_circbuf_create(
> - ia_css_circbuf_t *cb,
> + struct ia_css_circbuf_s *cb,
> ia_css_circbuf_elem_t *elems,
> ia_css_circbuf_desc_t *desc);
So, this is half baked patch. But even if it was the full one, the problem with
it that it does nothing useful. The useful change here is to refactor this to
use either circbuf or kfifo Linux kernel APIs.
...
TL;DR: Try more useful task first, please.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-09-19 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 21:41 Rareș-Mihai Vladu
2026-09-19 10:40 ` Dan Carpenter
2026-09-19 14:12 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq6YMsRFmACGZUF-@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=vladurares@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®