* [PATCH v5] Kconfig: fix typos in core makefiles and purge defective DVB debug (v5)
@ 2026-09-05 0:30 Breno Rodrigues Alves
2026-09-07 6:59 ` Thomas Zimmermann
2026-09-10 0:11 ` kernel test robot
0 siblings, 2 replies; 4+ messages in thread
From: Breno Rodrigues Alves @ 2026-09-05 0:30 UTC (permalink / raw)
To: torvalds
Cc: linux-kernel, gregkh, arnd, linux-clk, linux-input, linux-media,
linux-pci, linux-usb, linux-sound, linux-staging, linux-fbdev,
linux-security-module, Breno Rodrigues Alves
Automated review from Sashiko AI revealed that re-enabling the legacy
DVB_ULE_DEBUG code via CONFIG_DVB_ULE_DEBUG exposes severe race conditions
on global state variables, leading to out-of-bounds memory corruption.
Additionally, the debug block suffers from undeclared identifiers (TS_SZ).
Following the core kernel principle of eliminating dangerous, unmaintained
code, this patch completely extirpates the defective DVB_ULE_DEBUG block
from dvb_net.c and purges its corresponding configuration symbol from
the Kconfig tree.
This version retains the verified MediaTek bugfixes and ghost purges:
- Fixes MediaTek interconnect typo mapping mt8196.o to MT8196.
- Fixes MediaTek regulator typo mapping mt6316-regulator to MT6316.
- Cleans up the dangling comment in drivers/leds/Kconfig.
- Purges verified legacy ghost weight.
Signed-off-by: Breno Rodrigues Alves <breno3011alves@gmail.com>
---
drivers/interconnect/mediatek/Makefile | 2 +-
drivers/leds/Kconfig | 1 -
drivers/media/dvb-core/dvb_net.c | 6 +++---
drivers/regulator/Makefile | 2 +-
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/interconnect/mediatek/Makefile b/drivers/interconnect/mediatek/Makefile
index 6bd656668..64170ab16 100644
--- a/drivers/interconnect/mediatek/Makefile
+++ b/drivers/interconnect/mediatek/Makefile
@@ -3,4 +3,4 @@
obj-$(CONFIG_INTERCONNECT_MTK_DVFSRC_EMI) += icc-emi.o
obj-$(CONFIG_INTERCONNECT_MTK_MT8183) += mt8183.o
obj-$(CONFIG_INTERCONNECT_MTK_MT8195) += mt8195.o
-obj-$(CONFIG_INTERCONNECT_MTK_MT8195) += mt8196.o
+obj-$(CONFIG_INTERCONNECT_MTK_MT8196) += mt8196.o
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index d0d318223..800fbd560 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -873,7 +873,6 @@ config LEDS_UPBOARD
This driver can also be built as a module. If so the module will be
called leds-upboard.
-comment "LED driver for blink(1) USB RGB LED is under Special HID drivers (HID_THINGM)"
config LEDS_BLINKM
tristate "LED support for the BlinkM I2C RGB LED"
diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c
index a2159b2bc..3b503695e 100644
--- a/drivers/media/dvb-core/dvb_net.c
+++ b/drivers/media/dvb-core/dvb_net.c
@@ -68,7 +68,7 @@ static inline __u32 iov_crc32( __u32 c, struct kvec *iov, unsigned int cnt )
#define DVB_NET_MULTICAST_MAX 10
-#ifdef DVB_ULE_DEBUG
+#ifdef CONFIG_DVB_ULE_DEBUG
/*
* The code inside DVB_ULE_DEBUG keeps a history of the
* last 100 TS cells processed.
@@ -320,7 +320,7 @@ static int dvb_net_ule_new_ts_cell(struct dvb_net_ule_handle *h)
{
/* We are about to process a new TS cell. */
-#ifdef DVB_ULE_DEBUG
+#ifdef CONFIG_DVB_ULE_DEBUG
if (ule_where >= &ule_hist[100*TS_SZ])
ule_where = ule_hist;
memcpy(ule_where, h->ts, TS_SZ);
@@ -659,7 +659,7 @@ static void dvb_net_ule_check_crc(struct dvb_net_ule_handle *h,
h->ts_remain > 2 ?
*(unsigned short *)h->from_where : 0);
- #ifdef DVB_ULE_DEBUG
+ #ifdef CONFIG_DVB_ULE_DEBUG
hexdump(iov[0].iov_base, iov[0].iov_len);
hexdump(iov[1].iov_base, iov[1].iov_len);
hexdump(iov[2].iov_base, iov[2].iov_len);
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 5a764cec8..f81d1f31a 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -107,7 +107,7 @@ obj-$(CONFIG_REGULATOR_MP886X) += mp886x.o
obj-$(CONFIG_REGULATOR_MPQ7920) += mpq7920.o
obj-$(CONFIG_REGULATOR_MT6311) += mt6311-regulator.o
obj-$(CONFIG_REGULATOR_MT6315) += mt6315-regulator.o
-obj-$(CONFIG_REGULATOR_MT6315) += mt6316-regulator.o
+obj-$(CONFIG_REGULATOR_MT6316) += mt6316-regulator.o
obj-$(CONFIG_REGULATOR_MT6323) += mt6323-regulator.o
obj-$(CONFIG_REGULATOR_MT6331) += mt6331-regulator.o
obj-$(CONFIG_REGULATOR_MT6332) += mt6332-regulator.o
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v5] Kconfig: fix typos in core makefiles and purge defective DVB debug (v5)
2026-09-05 0:30 [PATCH v5] Kconfig: fix typos in core makefiles and purge defective DVB debug (v5) Breno Rodrigues Alves
@ 2026-09-07 6:59 ` Thomas Zimmermann
2026-09-09 14:54 ` Dan Carpenter
2026-09-10 0:11 ` kernel test robot
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Zimmermann @ 2026-09-07 6:59 UTC (permalink / raw)
To: Breno Rodrigues Alves, torvalds
Cc: linux-kernel, gregkh, arnd, linux-clk, linux-input, linux-media,
linux-pci, linux-usb, linux-sound, linux-staging, linux-fbdev,
linux-security-module
Please stop spamming this list with revisions.
Am 05.09.26 um 02:30 schrieb Breno Rodrigues Alves:
> Automated review from Sashiko AI revealed that re-enabling the legacy
> DVB_ULE_DEBUG code via CONFIG_DVB_ULE_DEBUG exposes severe race conditions
> on global state variables, leading to out-of-bounds memory corruption.
> Additionally, the debug block suffers from undeclared identifiers (TS_SZ).
>
> Following the core kernel principle of eliminating dangerous, unmaintained
> code, this patch completely extirpates the defective DVB_ULE_DEBUG block
> from dvb_net.c and purges its corresponding configuration symbol from
> the Kconfig tree.
>
> This version retains the verified MediaTek bugfixes and ghost purges:
> - Fixes MediaTek interconnect typo mapping mt8196.o to MT8196.
> - Fixes MediaTek regulator typo mapping mt6316-regulator to MT6316.
> - Cleans up the dangling comment in drivers/leds/Kconfig.
> - Purges verified legacy ghost weight.
>
> Signed-off-by: Breno Rodrigues Alves <breno3011alves@gmail.com>
> ---
> drivers/interconnect/mediatek/Makefile | 2 +-
> drivers/leds/Kconfig | 1 -
> drivers/media/dvb-core/dvb_net.c | 6 +++---
> drivers/regulator/Makefile | 2 +-
> 4 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/interconnect/mediatek/Makefile b/drivers/interconnect/mediatek/Makefile
> index 6bd656668..64170ab16 100644
> --- a/drivers/interconnect/mediatek/Makefile
> +++ b/drivers/interconnect/mediatek/Makefile
> @@ -3,4 +3,4 @@
> obj-$(CONFIG_INTERCONNECT_MTK_DVFSRC_EMI) += icc-emi.o
> obj-$(CONFIG_INTERCONNECT_MTK_MT8183) += mt8183.o
> obj-$(CONFIG_INTERCONNECT_MTK_MT8195) += mt8195.o
> -obj-$(CONFIG_INTERCONNECT_MTK_MT8195) += mt8196.o
> +obj-$(CONFIG_INTERCONNECT_MTK_MT8196) += mt8196.o
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index d0d318223..800fbd560 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -873,7 +873,6 @@ config LEDS_UPBOARD
> This driver can also be built as a module. If so the module will be
> called leds-upboard.
>
> -comment "LED driver for blink(1) USB RGB LED is under Special HID drivers (HID_THINGM)"
>
> config LEDS_BLINKM
> tristate "LED support for the BlinkM I2C RGB LED"
> diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c
> index a2159b2bc..3b503695e 100644
> --- a/drivers/media/dvb-core/dvb_net.c
> +++ b/drivers/media/dvb-core/dvb_net.c
> @@ -68,7 +68,7 @@ static inline __u32 iov_crc32( __u32 c, struct kvec *iov, unsigned int cnt )
>
> #define DVB_NET_MULTICAST_MAX 10
>
> -#ifdef DVB_ULE_DEBUG
> +#ifdef CONFIG_DVB_ULE_DEBUG
> /*
> * The code inside DVB_ULE_DEBUG keeps a history of the
> * last 100 TS cells processed.
> @@ -320,7 +320,7 @@ static int dvb_net_ule_new_ts_cell(struct dvb_net_ule_handle *h)
> {
> /* We are about to process a new TS cell. */
>
> -#ifdef DVB_ULE_DEBUG
> +#ifdef CONFIG_DVB_ULE_DEBUG
> if (ule_where >= &ule_hist[100*TS_SZ])
> ule_where = ule_hist;
> memcpy(ule_where, h->ts, TS_SZ);
> @@ -659,7 +659,7 @@ static void dvb_net_ule_check_crc(struct dvb_net_ule_handle *h,
> h->ts_remain > 2 ?
> *(unsigned short *)h->from_where : 0);
>
> - #ifdef DVB_ULE_DEBUG
> + #ifdef CONFIG_DVB_ULE_DEBUG
> hexdump(iov[0].iov_base, iov[0].iov_len);
> hexdump(iov[1].iov_base, iov[1].iov_len);
> hexdump(iov[2].iov_base, iov[2].iov_len);
> diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
> index 5a764cec8..f81d1f31a 100644
> --- a/drivers/regulator/Makefile
> +++ b/drivers/regulator/Makefile
> @@ -107,7 +107,7 @@ obj-$(CONFIG_REGULATOR_MP886X) += mp886x.o
> obj-$(CONFIG_REGULATOR_MPQ7920) += mpq7920.o
> obj-$(CONFIG_REGULATOR_MT6311) += mt6311-regulator.o
> obj-$(CONFIG_REGULATOR_MT6315) += mt6315-regulator.o
> -obj-$(CONFIG_REGULATOR_MT6315) += mt6316-regulator.o
> +obj-$(CONFIG_REGULATOR_MT6316) += mt6316-regulator.o
> obj-$(CONFIG_REGULATOR_MT6323) += mt6323-regulator.o
> obj-$(CONFIG_REGULATOR_MT6331) += mt6331-regulator.o
> obj-$(CONFIG_REGULATOR_MT6332) += mt6332-regulator.o
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v5] Kconfig: fix typos in core makefiles and purge defective DVB debug (v5)
2026-09-07 6:59 ` Thomas Zimmermann
@ 2026-09-09 14:54 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2026-09-09 14:54 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: Breno Rodrigues Alves, torvalds, linux-kernel, gregkh, arnd,
linux-clk, linux-input, linux-media, linux-pci, linux-usb,
linux-sound, linux-staging, linux-fbdev, linux-security-module
On Mon, Sep 07, 2026 at 08:59:28AM +0200, Thomas Zimmermann wrote:
> Please stop spamming this list with revisions.
>
Generally, the rule is wait a day between resends. Otherwise it
becomes pair programming and no one wants that.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5] Kconfig: fix typos in core makefiles and purge defective DVB debug (v5)
2026-09-05 0:30 [PATCH v5] Kconfig: fix typos in core makefiles and purge defective DVB debug (v5) Breno Rodrigues Alves
2026-09-07 6:59 ` Thomas Zimmermann
@ 2026-09-10 0:11 ` kernel test robot
1 sibling, 0 replies; 4+ messages in thread
From: kernel test robot @ 2026-09-10 0:11 UTC (permalink / raw)
To: Breno Rodrigues Alves, torvalds
Cc: oe-kbuild-all, linux-kernel, gregkh, arnd, linux-clk,
linux-input, linux-media, linux-pci, linux-usb, linux-sound,
linux-staging, linux-fbdev, linux-security-module,
Breno Rodrigues Alves
Hi Breno,
kernel test robot noticed the following build errors:
[auto build test ERROR on lee-leds/for-leds-next]
[also build test ERROR on broonie-regulator/for-next linus/master v7.3-rc2 next-20260909]
[cannot apply to linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Breno-Rodrigues-Alves/Kconfig-fix-typos-in-core-makefiles-and-purge-defective-DVB-debug-v5/20260904-213005
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link: https://lore.kernel.org/r/20260905003005.118245-1-breno3011alves%40gmail.com
patch subject: [PATCH v5] Kconfig: fix typos in core makefiles and purge defective DVB debug (v5)
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260910/202609100824.ndDVSLWu-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260910/202609100824.ndDVSLWu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609100824.ndDVSLWu-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
>> drivers/media/dvb-core/dvb_net.c:76:35: error: 'TS_SZ' undeclared here (not in a function)
76 | static unsigned char ule_hist[100*TS_SZ] = { 0 };
| ^~~~~
>> drivers/media/dvb-core/dvb_net.c:76:22: warning: 'ule_hist' defined but not used [-Wunused-variable]
76 | static unsigned char ule_hist[100*TS_SZ] = { 0 };
| ^~~~~~~~
vim +/TS_SZ +76 drivers/media/dvb-core/dvb_net.c
^1da177e4c3f41 drivers/media/dvb/dvb-core/dvb_net.c Linus Torvalds 2005-04-16 70
e9f8b7ccd92d83 drivers/media/dvb-core/dvb_net.c Breno Rodrigues Alves 2026-09-04 71 #ifdef CONFIG_DVB_ULE_DEBUG
b93a25e120d5a4 drivers/media/dvb-core/dvb_net.c Mauro Carvalho Chehab 2017-12-11 72 /*
ba711e1cee7553 drivers/media/dvb-core/dvb_net.c Mauro Carvalho Chehab 2017-12-11 73 * The code inside DVB_ULE_DEBUG keeps a history of the
b93a25e120d5a4 drivers/media/dvb-core/dvb_net.c Mauro Carvalho Chehab 2017-12-11 74 * last 100 TS cells processed.
b93a25e120d5a4 drivers/media/dvb-core/dvb_net.c Mauro Carvalho Chehab 2017-12-11 75 */
b93a25e120d5a4 drivers/media/dvb-core/dvb_net.c Mauro Carvalho Chehab 2017-12-11 @76 static unsigned char ule_hist[100*TS_SZ] = { 0 };
b93a25e120d5a4 drivers/media/dvb-core/dvb_net.c Mauro Carvalho Chehab 2017-12-11 77 static unsigned char *ule_where = ule_hist, ule_dump;
b93a25e120d5a4 drivers/media/dvb-core/dvb_net.c Mauro Carvalho Chehab 2017-12-11 78
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-10 0:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-05 0:30 [PATCH v5] Kconfig: fix typos in core makefiles and purge defective DVB debug (v5) Breno Rodrigues Alves
2026-09-07 6:59 ` Thomas Zimmermann
2026-09-09 14:54 ` Dan Carpenter
2026-09-10 0:11 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®