From: Shakeel Butt <shakeel.butt@linux.dev>
To: Sandeep Dhavale <dhavale@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>,
Christian Brauner <christian@brauner.io>,
Meta kernel team <kernel-team@meta.com>,
driver-core@lists.linux.dev, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] kernfs: Remove kernfs_rwsem from dentry revalidation
Date: Fri, 11 Sep 2026 20:09:27 -0700 [thread overview]
Message-ID: <aqTB1AVmFVs08T19@linux.dev> (raw)
In-Reply-To: <CAB=BE-SjW76gWr0kZcPnEjXOwt90vCV0TJeFuYEGV1Kt4Y1HWw@mail.gmail.com>
On Fri, Sep 11, 2026 at 02:11:53PM -0700, Sandeep Dhavale wrote:
> > Hi Sandeep, thanks for the report. Do you have a reproducer? If yes, can you
> > reproduce with this series?
> >
> Hi Shakeel,
> No luck with the reproducer yet, and reports have been sporadic.
>
> > I think first we need a real reproducer before considering anything. I would not
> > add a check unless we have proof that it is really needed.
>
> Ok, I understand. Do you have any opinion on the suspected call chain
> which makes dentry->d_inode = NULL; ?
I don't see how reclaim can set dentry->d_inode = NULL for a dentry with
elevated dentry->d_lockref.count because kernfs_dop_revalidate gets the dentry
whose dentry->d_lockref.count is elevated. Reclaim specifically skips such
dentries.
next prev parent reply other threads:[~2026-09-12 3:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 5:05 [PATCH 0/4] kernfs: remove " Shakeel Butt
2026-08-21 5:05 ` [PATCH 1/4] kernfs: Use VFS lookup context in d_revalidate() Shakeel Butt
2026-08-21 5:05 ` [PATCH 2/4] kernfs: Prepare directory revisions for lockless reads Shakeel Butt
2026-08-21 5:05 ` [PATCH 3/4] kernfs: Avoid namespace dereference in d_revalidate() Shakeel Butt
2026-08-21 5:05 ` [PATCH 4/4] kernfs: Remove kernfs_rwsem from dentry revalidation Shakeel Butt
2026-09-11 18:33 ` Sandeep Dhavale
2026-09-11 19:31 ` Shakeel Butt
2026-09-11 21:11 ` Sandeep Dhavale
2026-09-12 3:09 ` Shakeel Butt [this message]
2026-09-12 3:28 ` Sandeep Dhavale
2026-08-25 14:58 ` [PATCH 0/4] kernfs: remove " Christian Brauner
2026-08-26 4:02 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqTB1AVmFVs08T19@linux.dev \
--to=shakeel.butt@linux.dev \
--cc=cgroups@vger.kernel.org \
--cc=christian@brauner.io \
--cc=dhavale@google.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®