From: Tejun Heo <tj@kernel.org>
To: Tao Cui <cui.tao@linux.dev>
Cc: Josef Bacik <josef@toxicpanda.com>,
josef@toxicopanda.com, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, cuitao@kylinos.cn
Subject: Re: [PATCH v2 1/4] blk-iocost: charge flushes as pageless random writes
Date: Sun, 20 Sep 2026 02:19:48 -1000 [thread overview]
Message-ID: <aq_PZAB74FWXrON9@slm.duckdns.org> (raw)
In-Reply-To: <ab72a564-108c-4b74-adf3-1eadbbf01084@linux.dev>
Hello,
On Sun, Sep 20, 2026 at 03:08:54PM +0800, Tao Cui wrote:
> One remaining question is whether builtin profiles should eventually carry
> measured flushiops values, or whether flushiops is expected to remain
> user-configured. This series leaves it at zero because I don't have
> reliable measurements for the existing profiles.
The cost of a flush is more a function of what came before the flush how
long ago than anything else. The linear model is too dumb to estimate that.
You can tune this to suit a particular use case and maybe one can argue that
charging a small cost to penalize unnecessarily frequent flushes would be a
reasonable default policy, but, I don't know, what the default model can do
is pretty limited, so I'm not sure it matters that much one way or the
other.
If getting this right is actually useful, stateful BPF model is probably the
right way.
Thanks.
--
tejun
next prev parent reply other threads:[~2026-09-20 12:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 8:53 [PATCH v2 0/4] blk-iocost: charge flushes and zone appends Tao Cui
2026-09-16 8:53 ` [PATCH v2 1/4] blk-iocost: charge flushes as pageless random writes Tao Cui
2026-09-18 13:21 ` Christoph Hellwig
2026-09-19 14:59 ` Tejun Heo
2026-09-20 7:08 ` Tao Cui
2026-09-20 12:19 ` Tejun Heo [this message]
2026-09-16 8:53 ` [PATCH v2 2/4] blk-iocost: charge zone appends as page-counted sequential writes Tao Cui
2026-09-18 13:22 ` Christoph Hellwig
2026-09-20 7:11 ` Tao Cui
2026-09-19 15:00 ` Tejun Heo
2026-09-20 7:13 ` Tao Cui
2026-09-16 8:53 ` [PATCH v2 3/4] blk-iocost: account zone append completions in latency stats Tao Cui
2026-09-18 13:22 ` Christoph Hellwig
2026-09-16 8:53 ` [PATCH v2 4/4] blk-iocost: fix stale comment in ioc_rqos_throttle() Tao Cui
2026-09-18 13:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq_PZAB74FWXrON9@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=cui.tao@linux.dev \
--cc=cuitao@kylinos.cn \
--cc=hch@infradead.org \
--cc=josef@toxicopanda.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®