mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Val Packett <val@packett.cool>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] ASoC: soc-core: use the device tree card name as long_name
Date: Mon, 14 Sep 2026 12:19:15 +0100	[thread overview]
Message-ID: <aqfYM0svh1mDZtqj@sirena.co.uk> (raw)
In-Reply-To: <aqfT4ZzmxtxM2Dn0@quark2.heme.sigxcpu.org>

[-- Attachment #1: Type: text/plain, Size: 2313 bytes --]

On Mon, Sep 14, 2026 at 01:00:49PM +0200, Guido Günther wrote:
> On Wed, May 06, 2026 at 12:58:55AM -0300, Val Packett wrote:
> > When setting the model property for the sound card on an OF/DT system,
> > the expectation is that that model name would be used in the UCM config
> > path lookup. However, the DT model name was only used as the "short"
> > name, which gets overriden by the "long" name during loading, and
> > the "long" name is automatically set based on DMI data if available.
> > As a result, adding an intermediate bootloader such as U-Boot which
> > provides DMI data on a device that didn't have it before would break
> > the UCM config loading by suddenly looking at the "wrong" path.

> > Fix by assigning the DT model name to the long_name field as well.

I'm not convinced that there is a clear expectation here, any change
will doubtless upset some other user (for example someone using a system
derived from a reference board that happens to work with it's device
tree, or something where the firmware puts discovered information into
DMI).  Really you're just not supposed to combine DMI and DT based
discovery methods, having a system shipping both is just going to lead
to confusion and there's no way we can possibly get it right.  You have
decided that for your systems the DMI information is bad and you want to
override it but that doesn't mean that the next person won't make the
opposite choice.  Any decision here should be policy based in userspace
based on the full system information.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

  reply	other threads:[~2026-09-14 11:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06  3:58 Val Packett
2026-07-24 23:12 ` Clayton Craft
2026-09-06 11:50 ` David Heidelberg
2026-09-14 11:00 ` Guido Günther
2026-09-14 11:19   ` Mark Brown [this message]
2026-09-14 11:34     ` Guido Günther
2026-09-14 11:41       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqfYM0svh1mDZtqj@sirena.co.uk \
    --to=broonie@kernel.org \
    --cc=agx@sigxcpu.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=val@packett.cool \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®