mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Padhi, Beleswar" <b-padhi@ti.com>
Cc: Andrew Davis <afd@ti.com>, Bjorn Andersson <andersson@kernel.org>,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] remoteproc: Add compile testing for additional TI drivers
Date: Tue, 15 Sep 2026 09:44:20 -0600	[thread overview]
Message-ID: <aqln1OjBIsMt8wIv@p14s> (raw)
In-Reply-To: <0c4cdd98-4029-48a0-9a04-e2bd5f062eb1@ti.com>

On Tue, Sep 15, 2026 at 08:03:22PM +0530, Padhi, Beleswar wrote:
> 
> On 9/5/2026 1:26 AM, Andrew Davis wrote:
> > Many Remoteproc drivers, including K3, can and are built for compile
> > testing. The WKUP_M3, Keystone, and DA8xx can be also, enable this here.
> > 
> > Doing this exposes a compile warning on 64bit platforms as size_t changes
> > size, use the correct printf format specifier for size_t.
> > 
> > We cannot compile test for OMAP_REMOTEPROC due to dependency on OMAP
> > clock framework. But while here fix up the Kconfig help text which claims
> > this driver only works for OMAP4, when it really works across several
> > OMAP-class devices.
> > 
> > Signed-off-by: Andrew Davis <afd@ti.com>
> 
> 
> Thanks for cleaning this up. Test suite is happy.
> 
> Reviewed-by: Beleswar Padhi <b-padhi@ti.com>
> Tested-by: Beleswar Padhi <b-padhi@ti.com>
> 
> Nit: A cover letter would be good to send R/B and T/B for the entire series.

I agree with Beleswar.  I applied all 3 patches.

Thanks,
Mathieu

> 
> Thanks,
> Beleswar
> 
> > ---
> >   drivers/remoteproc/Kconfig           | 10 ++++------
> >   drivers/remoteproc/omap_remoteproc.c |  2 +-
> >   2 files changed, 5 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> > index 5b56b2dcc725f..73500fdc227db 100644
> > --- a/drivers/remoteproc/Kconfig
> > +++ b/drivers/remoteproc/Kconfig
> > @@ -83,9 +83,7 @@ config OMAP_REMOTEPROC
> >   	select OMAP2PLUS_MBOX
> >   	help
> >   	  Say y here to support OMAP's remote processors (dual M3
> > -	  and DSP on OMAP4) via the remote processor framework.
> > -
> > -	  Currently only supported on OMAP4.
> > +	  and DSP) via the remote processor framework.
> >   	  Usually you want to say Y here, in order to enable multimedia
> >   	  use-cases to run on your platform (multimedia codecs are
> > @@ -108,7 +106,7 @@ config OMAP_REMOTEPROC_WATCHDOG
> >   config WKUP_M3_RPROC
> >   	tristate "AMx3xx Wakeup M3 remoteproc support"
> > -	depends on SOC_AM33XX || SOC_AM43XX
> > +	depends on SOC_AM33XX || SOC_AM43XX || COMPILE_TEST
> >   	help
> >   	  Say y here to support Wakeup M3 remote processor on TI AM33xx
> >   	  and AM43xx family of SoCs.
> > @@ -120,7 +118,7 @@ config WKUP_M3_RPROC
> >   config DA8XX_REMOTEPROC
> >   	tristate "DA8xx/OMAP-L13x remoteproc support"
> > -	depends on ARCH_DAVINCI_DA8XX
> > +	depends on ARCH_DAVINCI_DA8XX || COMPILE_TEST
> >   	depends on DMA_CMA
> >   	help
> >   	  Say y here to support DA8xx/OMAP-L13x remote processors via the
> > @@ -141,7 +139,7 @@ config DA8XX_REMOTEPROC
> >   config KEYSTONE_REMOTEPROC
> >   	tristate "Keystone Remoteproc support"
> > -	depends on ARCH_KEYSTONE
> > +	depends on ARCH_KEYSTONE || COMPILE_TEST
> >   	help
> >   	  Say Y here here to support Keystone remote processors (DSP)
> >   	  via the remote processor framework.
> > diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
> > index efff95b8e363f..1e96506ce7ca7 100644
> > --- a/drivers/remoteproc/omap_remoteproc.c
> > +++ b/drivers/remoteproc/omap_remoteproc.c
> > @@ -1208,7 +1208,7 @@ static int omap_rproc_of_get_internal_memories(struct platform_device *pdev,
> >   		oproc->mem[i].dev_addr = data->mems[i].dev_addr;
> >   		oproc->mem[i].size = resource_size(res);
> > -		dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %p da 0x%x\n",
> > +		dev_dbg(dev, "memory %8s: bus addr %pa size 0x%zx va %p da 0x%x\n",
> >   			data->mems[i].name, &oproc->mem[i].bus_addr,
> >   			oproc->mem[i].size, oproc->mem[i].cpu_addr,
> >   			oproc->mem[i].dev_addr);

  reply	other threads:[~2026-09-15 15:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 19:56 [PATCH 1/3] remoteproc: k3: Include what we need and only what we need Andrew Davis
2026-09-04 19:56 ` [PATCH 2/3] remoteproc: k3-dsp: Fix usage of omap_mbox_message and mbox_msg_t Andrew Davis
2026-09-09 15:48   ` Mathieu Poirier
2026-09-09 16:07     ` Andrew Davis
2026-09-15 14:31   ` Padhi, Beleswar
2026-09-04 19:56 ` [PATCH 3/3] remoteproc: Add compile testing for additional TI drivers Andrew Davis
2026-09-15 14:33   ` Padhi, Beleswar
2026-09-15 15:44     ` Mathieu Poirier [this message]
2026-09-15 14:30 ` [PATCH 1/3] remoteproc: k3: Include what we need and only what we need Padhi, Beleswar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqln1OjBIsMt8wIv@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=afd@ti.com \
    --cc=andersson@kernel.org \
    --cc=b-padhi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®