From: Catalin Marinas <catalin.marinas@arm.com>
To: "Aneesh Kumar K.V (Arm)" <aneesh.kumar@kernel.org>
Cc: linux-coco@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>,
Greg KH <gregkh@linuxfoundation.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Jonathan Cameron <jic23@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Will Deacon <will@kernel.org>,
Steven Price <steven.price@arm.com>,
Suzuki K Poulose <Suzuki.Poulose@arm.com>,
Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH v11 3/7] firmware: arm_rmm: Move RSI support out of arch/arm64
Date: Wed, 16 Sep 2026 11:58:23 +0100 [thread overview]
Message-ID: <aqp2TzS5FAE9ixc8@arm.com> (raw)
In-Reply-To: <20260914060511.277948-4-aneesh.kumar@kernel.org>
On Mon, Sep 14, 2026 at 11:35:07AM +0530, Aneesh Kumar K.V (Arm) wrote:
> The RSI SMCCC function IDs describe a firmware ABI and are not arm64
> architecture specific definitions. Follow-up changes need to use them from
> non-arch code, including drivers/firmware/smccc and the Arm CCA guest
> driver.
>
> Move the complete Realm Service Interface (RSI) implementation from
> arch/arm64 to drivers/firmware/arm_rmm. The RSI SMCCC definitions and
> command helpers are also moved to include/linux so they can be shared by
> architecture code and firmware or driver code. This also keeps the
> firmware interface outside architecture code, as requested [1].
>
> [1] https://lore.kernel.org/all/agsNO9cc7H-b0H8L@willie-the-truck
>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@kernel.org>
> ---
> arch/arm64/Kconfig | 1 +
> arch/arm64/include/asm/io.h | 2 +-
> arch/arm64/include/asm/mem_encrypt.h | 2 +-
> arch/arm64/include/asm/pgtable-prot.h | 2 +-
> arch/arm64/include/asm/rsi.h | 70 -----------------
> arch/arm64/kernel/Makefile | 2 +-
> arch/arm64/kernel/setup.c | 2 +-
> arch/arm64/mm/init.c | 3 +-
> drivers/firmware/Kconfig | 1 +
> drivers/firmware/Makefile | 1 +
> drivers/firmware/arm_rmm/Kconfig | 17 ++++
> drivers/firmware/arm_rmm/Makefile | 2 +
> .../kernel => drivers/firmware/arm_rmm}/rsi.c | 2 +-
> drivers/virt/coco/arm-cca-guest/Kconfig | 2 +-
> .../virt/coco/arm-cca-guest/arm-cca-guest.c | 5 +-
> .../linux/arm-rsi-cmds.h | 77 +++++++++++++++++--
> .../linux/arm-smccc-rsi.h | 6 +-
> 17 files changed, 108 insertions(+), 89 deletions(-)
> delete mode 100644 arch/arm64/include/asm/rsi.h
> create mode 100644 drivers/firmware/arm_rmm/Kconfig
> create mode 100644 drivers/firmware/arm_rmm/Makefile
> rename {arch/arm64/kernel => drivers/firmware/arm_rmm}/rsi.c (99%)
> rename arch/arm64/include/asm/rsi_cmds.h => include/linux/arm-rsi-cmds.h (69%)
> rename arch/arm64/include/asm/rsi_smc.h => include/linux/arm-smccc-rsi.h (98%)
BTW, can you also add the new files under the ARM64 PORT in MAINTAINERS,
similar to arm-cca-guest?
Thanks.
--
Catalin
next prev parent reply other threads:[~2026-09-16 10:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 6:05 [PATCH v11 0/7] Switch Arm SMCCC firmware services to an SMCCC bus Aneesh Kumar K.V (Arm)
2026-09-14 6:05 ` [PATCH v11 1/7] firmware: smccc: Add an Arm " Aneesh Kumar K.V (Arm)
2026-09-14 13:03 ` Catalin Marinas
2026-09-14 20:32 ` Jonathan Cameron
2026-09-14 22:28 ` Jason Gunthorpe
2026-09-15 9:22 ` Aneesh Kumar K.V
2026-09-15 11:46 ` Jason Gunthorpe
2026-09-14 6:05 ` [PATCH v11 2/7] firmware: hwrng: arm_smccc_trng: Register as an SMCCC device Aneesh Kumar K.V (Arm)
2026-09-14 13:14 ` Catalin Marinas
2026-09-14 20:39 ` Jonathan Cameron
2026-09-14 6:05 ` [PATCH v11 3/7] firmware: arm_rmm: Move RSI support out of arch/arm64 Aneesh Kumar K.V (Arm)
2026-09-14 13:18 ` Catalin Marinas
2026-09-14 20:45 ` Jonathan Cameron
2026-09-16 10:58 ` Catalin Marinas [this message]
2026-09-14 6:05 ` [PATCH v11 4/7] arm64: realm: Move Realm memory encryption ops to RSI code Aneesh Kumar K.V (Arm)
2026-09-14 13:20 ` Catalin Marinas
2026-09-14 14:50 ` Suzuki K Poulose
2026-09-16 15:21 ` Suzuki K Poulose
2026-09-14 6:05 ` [PATCH v11 5/7] virt: coco: arm-cca-guest: Rename TSM report source file Aneesh Kumar K.V (Arm)
2026-09-14 13:23 ` Catalin Marinas
2026-09-14 15:06 ` Suzuki K Poulose
2026-09-14 20:48 ` Jonathan Cameron
2026-09-14 6:05 ` [PATCH v11 6/7] firmware: smccc: arm-cca-guest: Bind the TSM provider to an SMCCC device Aneesh Kumar K.V (Arm)
2026-09-14 13:42 ` Catalin Marinas
2026-09-14 20:51 ` Jonathan Cameron
2026-09-16 12:46 ` Jason Gunthorpe
2026-09-14 6:05 ` [PATCH v11 7/7] coco: guest: arm64: Replace dummy CCA device with sysfs ABI Aneesh Kumar K.V (Arm)
2026-09-14 13:48 ` Catalin Marinas
2026-09-14 21:00 ` Jonathan Cameron
2026-09-16 10:57 ` Catalin Marinas
2026-09-16 14:09 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqp2TzS5FAE9ixc8@arm.com \
--to=catalin.marinas@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=andre.przywara@arm.com \
--cc=aneesh.kumar@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy.linton@arm.com \
--cc=jgg@nvidia.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®