mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] siphash: clean up kernel-doc comments
@ 2026-08-31  5:52 Randy Dunlap
  2026-09-16  9:25 ` Jason A. Donenfeld
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2026-08-31  5:52 UTC (permalink / raw)
  To: linux-kernel; +Cc: Randy Dunlap, Jason A. Donenfeld

Use the correct function parameter names and add function return
value descriptions to avoid kernel-doc warnings:

Warning: include/linux/siphash.h:82 function parameter 'len' not described
 in 'siphash'
Warning: include/linux/siphash.h:82 No description found for return value
 of 'siphash'
Warning: include/linux/siphash.h:132 function parameter 'len' not
 described in 'hsiphash'
Warning: include/linux/siphash.h:132 No description found for return value
 of 'hsiphash'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
v2: rebase & resend

Cc: Jason A. Donenfeld <Jason@zx2c4.com>

 include/linux/siphash.h |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

--- linux-next-20260828.orig/include/linux/siphash.h
+++ linux-next-20260828/include/linux/siphash.h
@@ -75,8 +75,10 @@ static inline u64 ___siphash_aligned(con
 /**
  * siphash - compute 64-bit siphash PRF value
  * @data: buffer to hash
- * @size: size of @data
+ * @len: size of @data
  * @key: the siphash key
+ *
+ * Returns: siphash PRF value
  */
 static inline u64 siphash(const void *data, size_t len,
 			  const siphash_key_t *key)
@@ -125,8 +127,10 @@ static inline u32 ___hsiphash_aligned(co
 /**
  * hsiphash - compute 32-bit hsiphash PRF value
  * @data: buffer to hash
- * @size: size of @data
+ * @len: size of @data
  * @key: the hsiphash key
+ *
+ * Returns: hsiphash PRF value
  */
 static inline u32 hsiphash(const void *data, size_t len,
 			   const hsiphash_key_t *key)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] siphash: clean up kernel-doc comments
  2026-08-31  5:52 [PATCH v2] siphash: clean up kernel-doc comments Randy Dunlap
@ 2026-09-16  9:25 ` Jason A. Donenfeld
  0 siblings, 0 replies; 2+ messages in thread
From: Jason A. Donenfeld @ 2026-09-16  9:25 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: linux-kernel

On Sun, Aug 30, 2026 at 10:52:36PM -0700, Randy Dunlap wrote:
> Use the correct function parameter names and add function return
> value descriptions to avoid kernel-doc warnings:
> 
> Warning: include/linux/siphash.h:82 function parameter 'len' not described
>  in 'siphash'
> Warning: include/linux/siphash.h:82 No description found for return value
>  of 'siphash'
> Warning: include/linux/siphash.h:132 function parameter 'len' not
>  described in 'hsiphash'
> Warning: include/linux/siphash.h:132 No description found for return value
>  of 'hsiphash'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Applied. Thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-16  9:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-31  5:52 [PATCH v2] siphash: clean up kernel-doc comments Randy Dunlap
2026-09-16  9:25 ` Jason A. Donenfeld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®