* [PATCH net] selftests: net: update netfilter netlink config
@ 2026-09-17 2:17 Hangbin Liu
2026-09-17 7:06 ` Fernando Fernandez Mancera
0 siblings, 1 reply; 4+ messages in thread
From: Hangbin Liu @ 2026-09-17 2:17 UTC (permalink / raw)
To: Matthieu Baerts, Mat Martineau, Geliang Tang, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
Shuah Khan, Pablo Neira Ayuso, Florian Westphal, Phil Sutter,
Fernando Fernandez Mancera
Cc: Hangbin Liu, netdev, linux-kselftest, linux-kernel,
netfilter-devel, coreteam, mptcp, Hangbin Liu
From: Hangbin Liu <liuhangbin@kylinos.cn>
Since commit d4349ba9872d ("netfilter: allow nfnetlink built-in only"),
NETFILTER_NETLINK was changed to a bool. Use 'y' instead of 'm'.
Otherwise the build emits:
.config:5688:warning: symbol value 'm' invalid for NETFILTER_NETLINK
Fixes: d4349ba9872d ("netfilter: allow nfnetlink built-in only")
Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
---
This is a simple update addressing the same issue, so I’d like to post it
directly to netdev instead of bothering two separate subsystems
(mptcp and netfilter).
---
tools/testing/selftests/net/mptcp/config | 2 +-
tools/testing/selftests/net/netfilter/config | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
index 59051ee2a986..bb9c4c97c620 100644
--- a/tools/testing/selftests/net/mptcp/config
+++ b/tools/testing/selftests/net/mptcp/config
@@ -18,7 +18,7 @@ CONFIG_NET_CLS_ACT=y
CONFIG_NET_CLS_FW=m
CONFIG_NETFILTER=y
CONFIG_NETFILTER_ADVANCED=y
-CONFIG_NETFILTER_NETLINK=m
+CONFIG_NETFILTER_NETLINK=y
CONFIG_NETFILTER_XTABLES=m
CONFIG_NETFILTER_XTABLES_LEGACY=y
CONFIG_NETFILTER_XT_MATCH_BPF=m
diff --git a/tools/testing/selftests/net/netfilter/config b/tools/testing/selftests/net/netfilter/config
index c3c121b6f300..629b2b29ed1a 100644
--- a/tools/testing/selftests/net/netfilter/config
+++ b/tools/testing/selftests/net/netfilter/config
@@ -44,7 +44,7 @@ CONFIG_NET_CLS_U32=m
CONFIG_NETDEVSIM=m
CONFIG_NETFILTER=y
CONFIG_NETFILTER_ADVANCED=y
-CONFIG_NETFILTER_NETLINK=m
+CONFIG_NETFILTER_NETLINK=y
CONFIG_NETFILTER_NETLINK_QUEUE=m
CONFIG_NETFILTER_SYNPROXY=m
CONFIG_NETFILTER_XTABLES=m
---
base-commit: 1dd85662fee6e2ac580b1c4f9a0c0a7ae6e31f0e
change-id: 20260917-selftest_config-286bdd44b22b
Best regards,
--
Hangbin Liu <liuhangbin@kylinos.cn>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] selftests: net: update netfilter netlink config
2026-09-17 2:17 [PATCH net] selftests: net: update netfilter netlink config Hangbin Liu
@ 2026-09-17 7:06 ` Fernando Fernandez Mancera
2026-09-17 8:55 ` Pablo Neira Ayuso
2026-09-17 9:04 ` Matthieu Baerts
0 siblings, 2 replies; 4+ messages in thread
From: Fernando Fernandez Mancera @ 2026-09-17 7:06 UTC (permalink / raw)
To: Hangbin Liu, Matthieu Baerts, Mat Martineau, Geliang Tang,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Shuah Khan, Pablo Neira Ayuso, Florian Westphal,
Phil Sutter
Cc: netdev, linux-kselftest, linux-kernel, netfilter-devel, coreteam,
mptcp, Hangbin Liu
On 9/17/26 4:17 AM, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
>
> Since commit d4349ba9872d ("netfilter: allow nfnetlink built-in only"),
> NETFILTER_NETLINK was changed to a bool. Use 'y' instead of 'm'.
> Otherwise the build emits:
>
> .config:5688:warning: symbol value 'm' invalid for NETFILTER_NETLINK
>
> Fixes: d4349ba9872d ("netfilter: allow nfnetlink built-in only")
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Thanks!
> ---
> This is a simple update addressing the same issue, so I’d like to post it
> directly to netdev instead of bothering two separate subsystems
> (mptcp and netfilter).
> ---
> tools/testing/selftests/net/mptcp/config | 2 +-
> tools/testing/selftests/net/netfilter/config | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
> index 59051ee2a986..bb9c4c97c620 100644
> --- a/tools/testing/selftests/net/mptcp/config
> +++ b/tools/testing/selftests/net/mptcp/config
> @@ -18,7 +18,7 @@ CONFIG_NET_CLS_ACT=y
> CONFIG_NET_CLS_FW=m
> CONFIG_NETFILTER=y
> CONFIG_NETFILTER_ADVANCED=y
> -CONFIG_NETFILTER_NETLINK=m
> +CONFIG_NETFILTER_NETLINK=y
> CONFIG_NETFILTER_XTABLES=m
> CONFIG_NETFILTER_XTABLES_LEGACY=y
> CONFIG_NETFILTER_XT_MATCH_BPF=m
> diff --git a/tools/testing/selftests/net/netfilter/config b/tools/testing/selftests/net/netfilter/config
> index c3c121b6f300..629b2b29ed1a 100644
> --- a/tools/testing/selftests/net/netfilter/config
> +++ b/tools/testing/selftests/net/netfilter/config
> @@ -44,7 +44,7 @@ CONFIG_NET_CLS_U32=m
> CONFIG_NETDEVSIM=m
> CONFIG_NETFILTER=y
> CONFIG_NETFILTER_ADVANCED=y
> -CONFIG_NETFILTER_NETLINK=m
> +CONFIG_NETFILTER_NETLINK=y
> CONFIG_NETFILTER_NETLINK_QUEUE=m
> CONFIG_NETFILTER_SYNPROXY=m
> CONFIG_NETFILTER_XTABLES=m
>
> ---
> base-commit: 1dd85662fee6e2ac580b1c4f9a0c0a7ae6e31f0e
> change-id: 20260917-selftest_config-286bdd44b22b
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] selftests: net: update netfilter netlink config
2026-09-17 7:06 ` Fernando Fernandez Mancera
@ 2026-09-17 8:55 ` Pablo Neira Ayuso
2026-09-17 9:04 ` Matthieu Baerts
1 sibling, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2026-09-17 8:55 UTC (permalink / raw)
To: Fernando Fernandez Mancera
Cc: Hangbin Liu, Matthieu Baerts, Mat Martineau, Geliang Tang,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Shuah Khan, Florian Westphal, Phil Sutter, netdev,
linux-kselftest, linux-kernel, netfilter-devel, coreteam, mptcp,
Hangbin Liu
On Thu, Sep 17, 2026 at 09:06:48AM +0200, Fernando Fernandez Mancera wrote:
> On 9/17/26 4:17 AM, Hangbin Liu wrote:
> > From: Hangbin Liu <liuhangbin@kylinos.cn>
> >
> > Since commit d4349ba9872d ("netfilter: allow nfnetlink built-in only"),
> > NETFILTER_NETLINK was changed to a bool. Use 'y' instead of 'm'.
> > Otherwise the build emits:
> >
> > .config:5688:warning: symbol value 'm' invalid for NETFILTER_NETLINK
> >
> > Fixes: d4349ba9872d ("netfilter: allow nfnetlink built-in only")
> > Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
>
> Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Thanks.
> Thanks!
>
> > ---
> > This is a simple update addressing the same issue, so I’d like to post it
> > directly to netdev instead of bothering two separate subsystems
> > (mptcp and netfilter).
> > ---
> > tools/testing/selftests/net/mptcp/config | 2 +-
> > tools/testing/selftests/net/netfilter/config | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
> > index 59051ee2a986..bb9c4c97c620 100644
> > --- a/tools/testing/selftests/net/mptcp/config
> > +++ b/tools/testing/selftests/net/mptcp/config
> > @@ -18,7 +18,7 @@ CONFIG_NET_CLS_ACT=y
> > CONFIG_NET_CLS_FW=m
> > CONFIG_NETFILTER=y
> > CONFIG_NETFILTER_ADVANCED=y
> > -CONFIG_NETFILTER_NETLINK=m
> > +CONFIG_NETFILTER_NETLINK=y
> > CONFIG_NETFILTER_XTABLES=m
> > CONFIG_NETFILTER_XTABLES_LEGACY=y
> > CONFIG_NETFILTER_XT_MATCH_BPF=m
> > diff --git a/tools/testing/selftests/net/netfilter/config b/tools/testing/selftests/net/netfilter/config
> > index c3c121b6f300..629b2b29ed1a 100644
> > --- a/tools/testing/selftests/net/netfilter/config
> > +++ b/tools/testing/selftests/net/netfilter/config
> > @@ -44,7 +44,7 @@ CONFIG_NET_CLS_U32=m
> > CONFIG_NETDEVSIM=m
> > CONFIG_NETFILTER=y
> > CONFIG_NETFILTER_ADVANCED=y
> > -CONFIG_NETFILTER_NETLINK=m
> > +CONFIG_NETFILTER_NETLINK=y
> > CONFIG_NETFILTER_NETLINK_QUEUE=m
> > CONFIG_NETFILTER_SYNPROXY=m
> > CONFIG_NETFILTER_XTABLES=m
> >
> > ---
> > base-commit: 1dd85662fee6e2ac580b1c4f9a0c0a7ae6e31f0e
> > change-id: 20260917-selftest_config-286bdd44b22b
> >
> > Best regards,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] selftests: net: update netfilter netlink config
2026-09-17 7:06 ` Fernando Fernandez Mancera
2026-09-17 8:55 ` Pablo Neira Ayuso
@ 2026-09-17 9:04 ` Matthieu Baerts
1 sibling, 0 replies; 4+ messages in thread
From: Matthieu Baerts @ 2026-09-17 9:04 UTC (permalink / raw)
To: Hangbin Liu
Cc: netdev, linux-kselftest, linux-kernel, netfilter-devel, coreteam,
mptcp, Hangbin Liu, Fernando Fernandez Mancera, Mat Martineau,
Geliang Tang, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, Shuah Khan, Pablo Neira Ayuso,
Florian Westphal, Phil Sutter
Hi Hangbin,
On 17/09/2026 09:06, Fernando Fernandez Mancera wrote:
> On 9/17/26 4:17 AM, Hangbin Liu wrote:
>> From: Hangbin Liu <liuhangbin@kylinos.cn>
>>
>> Since commit d4349ba9872d ("netfilter: allow nfnetlink built-in only"),
>> NETFILTER_NETLINK was changed to a bool. Use 'y' instead of 'm'.
>> Otherwise the build emits:
>>
>> .config:5688:warning: symbol value 'm' invalid for NETFILTER_NETLINK
>>
>> Fixes: d4349ba9872d ("netfilter: allow nfnetlink built-in only")
>> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
>
> Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Thanks!
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-17 9:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 2:17 [PATCH net] selftests: net: update netfilter netlink config Hangbin Liu
2026-09-17 7:06 ` Fernando Fernandez Mancera
2026-09-17 8:55 ` Pablo Neira Ayuso
2026-09-17 9:04 ` Matthieu Baerts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®