* [PATCH] Input: cyapa - fix runtime PM leak in cyapa_update_rt_suspend_scanrate()
@ 2026-09-16 18:50 Wentao Liang
2026-09-17 15:15 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Liang @ 2026-09-16 18:50 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: dudl, linux-input, linux-kernel, Wentao Liang, stable
pm_runtime_get_sync() unconditionally increments the runtime PM usage
counter. If mutex_lock_interruptible() is interrupted, the function
returns without dropping that reference. Add the missing
pm_runtime_put_sync_autosuspend() call on the error path.
Fixes: 672865080a8f ("Input: cyapa - add runtime power management support")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/input/mouse/cyapa.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
index 6e0d956617a1..5edf4fdbb373 100644
--- a/drivers/input/mouse/cyapa.c
+++ b/drivers/input/mouse/cyapa.c
@@ -901,8 +901,10 @@ static ssize_t cyapa_update_rt_suspend_scanrate(struct device *dev,
pm_runtime_get_sync(dev);
error = mutex_lock_interruptible(&cyapa->state_sync_lock);
- if (error)
+ if (error) {
+ pm_runtime_put_sync_autosuspend(dev);
return error;
+ }
cyapa->runtime_suspend_sleep_time = min_t(u16, time, 1000);
cyapa->runtime_suspend_power_mode =
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: cyapa - fix runtime PM leak in cyapa_update_rt_suspend_scanrate()
2026-09-16 18:50 [PATCH] Input: cyapa - fix runtime PM leak in cyapa_update_rt_suspend_scanrate() Wentao Liang
@ 2026-09-17 15:15 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2026-09-17 15:15 UTC (permalink / raw)
To: Wentao Liang; +Cc: dudl, linux-input, linux-kernel, stable
Hi Wentao,
On Wed, Sep 16, 2026 at 06:50:15PM +0000, Wentao Liang wrote:
> pm_runtime_get_sync() unconditionally increments the runtime PM usage
> counter. If mutex_lock_interruptible() is interrupted, the function
> returns without dropping that reference. Add the missing
> pm_runtime_put_sync_autosuspend() call on the error path.
>
> Fixes: 672865080a8f ("Input: cyapa - add runtime power management support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/input/mouse/cyapa.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
> index 6e0d956617a1..5edf4fdbb373 100644
> --- a/drivers/input/mouse/cyapa.c
> +++ b/drivers/input/mouse/cyapa.c
> @@ -901,8 +901,10 @@ static ssize_t cyapa_update_rt_suspend_scanrate(struct device *dev,
> pm_runtime_get_sync(dev);
>
> error = mutex_lock_interruptible(&cyapa->state_sync_lock);
> - if (error)
> + if (error) {
> + pm_runtime_put_sync_autosuspend(dev);
Why does it have to be "sync" variant?
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-17 15:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-16 18:50 [PATCH] Input: cyapa - fix runtime PM leak in cyapa_update_rt_suspend_scanrate() Wentao Liang
2026-09-17 15:15 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®