[PATCH] hwmon: hp-wmi-sensors: Fix info_map[] allocation type

[PATCH] hwmon: hp-wmi-sensors: Fix info_map[] allocation type

[Kees Cook]

From: Kees Cook <kees+treewide@kernel.org>

In preparation for making the devm_kmalloc family of allocators type
aware, we need to make sure that the returned type from the allocation
matches the type of the variable being assigned. (Before, the allocator
would always return "void *", which can be implicitly cast to any
pointer type.)

The assigned type of "info_map[type]" is "struct hp_wmi_info **", but
the converted allocation type would be "struct hp_wmi_info ***", as the
size was taken from "*info_map", which is one level of indirection too
many. Luckily both element types are pointers of the same size. Take the
size from the element type of the assignment target.

Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:
drivers/hwmon/hp-wmi-sensors.o

Assisted-by: LLM coccinelle
Signed-off-by: Kees Cook <kees+treewide@kernel.org>
---
Cc: James Seo <james@equiv.tech>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: <linux-hwmon@vger.kernel.org>
---
 drivers/hwmon/hp-wmi-sensors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/hp-wmi-sensors.c b/drivers/hwmon/hp-wmi-sensors.c
index 03c684ba83bd..cc193a8890f2 100644
--- a/drivers/hwmon/hp-wmi-sensors.c
+++ b/drivers/hwmon/hp-wmi-sensors.c
@@ -1788,7 +1788,7 @@ static int init_numeric_sensors(struct hp_wmi_sensors *state,
 
 		if (!info_map[type]) {
 			info_map[type] = devm_kcalloc(dev, channel_count[type],
-						      sizeof(*info_map),
+						      sizeof(*info_map[type]),
 						      GFP_KERNEL);
 			if (!info_map[type])
 				return -ENOMEM;
-- 
2.34.1

Re: [PATCH] hwmon: hp-wmi-sensors: Fix info_map[] allocation type

[James Seo]

On Thu, Sep 17, 2026 at 02:13:39PM -0700, Kees Cook wrote:
>  drivers/hwmon/hp-wmi-sensors.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/hp-wmi-sensors.c b/drivers/hwmon/hp-wmi-sensors.c
> index 03c684ba83bd..cc193a8890f2 100644
> --- a/drivers/hwmon/hp-wmi-sensors.c
> +++ b/drivers/hwmon/hp-wmi-sensors.c
> @@ -1788,7 +1788,7 @@ static int init_numeric_sensors(struct hp_wmi_sensors *state,
>  
>  		if (!info_map[type]) {
>  			info_map[type] = devm_kcalloc(dev, channel_count[type],
> -						      sizeof(*info_map),
> +						      sizeof(*info_map[type]),
>  						      GFP_KERNEL);
>  			if (!info_map[type])
>  				return -ENOMEM;
> -- 
> 2.34.1
>
Acked-by: James Seo <james@equiv.tech>