From: Baoquan He <baoquan.he@linux.dev>
To: Wandun <chenwandun1@gmail.com>
Cc: catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org,
pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, robh@kernel.org,
saravanak@kernel.org, akpm@linux-foundation.org, rppt@kernel.org,
pasha.tatashin@soleen.com, pratyush@kernel.org,
m.szyprowski@samsung.com, mark.rutland@arm.com,
kernel@xen0n.name, alex@ghiti.fr, hpa@zytor.com,
ruirui.yang@linux.dev, robin.murphy@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
kexec@lists.infradead.org, linux-mm@kvack.org,
iommu@lists.linux.dev
Subject: Re: [PATCH v6 03/10] crash_core: fold duplicated memblock arch hooks into the weak default
Date: Fri, 18 Sep 2026 16:48:41 +0800 [thread overview]
Message-ID: <aqz66dMlp3NiMifc@fedora> (raw)
In-Reply-To: <c58e9b6a-e421-4265-aa77-48c07a4fb8e4@gmail.com>
On 09/18/26 at 04:45pm, Wandun wrote:
>
>
> On 9/18/26 15:30, Baoquan He wrote:
> > On 09/02/26 at 03:31pm, Wandun Chen wrote:
> >> From: Wandun Chen <chenwandun@lixiang.com>
> >>
> >> arm64, loongarch and riscv open-code the same memblock walk in
> >> arch_get_system_nr_ranges() and arch_crash_populate_cmem(). Move it into
> >> the __weak defaults in kernel/crash_core.c and delete the arch copies.
> >>
> >> No functional change.
> >
> > In one version, you also tried to remove these functions on x86, I could
> > remember it wrong.
>
> Yes, the x86 implementation can also remove these functions and use the same
> approach as arm64, RISC-V, and LoongArch. However since this change would not
> reduce the vmcore size on x86 at all, I did not include it in the current series.
>
> I plan to refactor this part on x86 after this series.
OK, that's fine. I remember I saw the code, but couldn't find it in this
patch. Thanks for telling.
>
>
>
> >
> > Anyway, this looks good to me.
> >
> > Acked-by: Baoquan He <baoquan.he@linux.dev>
> >
> >>
> >> Signed-off-by: Wandun Chen <chenwandun@lixiang.com>
> >> Tested-by: Meijing Zhao <zhaomeijing@lixiang.com>
> >> ---
> >> arch/arm64/kernel/machine_kexec_file.c | 29 ----------------------
> >> arch/loongarch/kernel/machine_kexec_file.c | 27 --------------------
> >> arch/riscv/kernel/machine_kexec_file.c | 26 -------------------
> >> kernel/crash_core.c | 25 +++++++++++++++++--
> >> 4 files changed, 23 insertions(+), 84 deletions(-)
> >>
> >> diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c
> >> index 854d872dfd0f..34d944d3f22f 100644
> >> --- a/arch/arm64/kernel/machine_kexec_file.c
> >> +++ b/arch/arm64/kernel/machine_kexec_file.c
> >> @@ -14,7 +14,6 @@
> >> #include <linux/kernel.h>
> >> #include <linux/kexec.h>
> >> #include <linux/libfdt.h>
> >> -#include <linux/memblock.h>
> >> #include <linux/of.h>
> >> #include <linux/of_fdt.h>
> >> #include <linux/slab.h>
> >> @@ -39,34 +38,6 @@ int arch_kimage_file_post_load_cleanup(struct kimage *image)
> >> return kexec_image_post_load_cleanup_default(image);
> >> }
> >>
> >> -#ifdef CONFIG_CRASH_DUMP
> >> -unsigned int arch_get_system_nr_ranges(void)
> >> -{
> >> - unsigned int nr_ranges = 2 + crashk_cma_cnt; /* for exclusion of crashkernel region */
> >> - phys_addr_t start, end;
> >> - u64 i;
> >> -
> >> - for_each_mem_range(i, &start, &end)
> >> - nr_ranges++;
> >> -
> >> - return nr_ranges;
> >> -}
> >> -
> >> -int arch_crash_populate_cmem(struct crash_mem *cmem)
> >> -{
> >> - phys_addr_t start, end;
> >> - u64 i;
> >> -
> >> - for_each_mem_range(i, &start, &end) {
> >> - cmem->ranges[cmem->nr_ranges].start = start;
> >> - cmem->ranges[cmem->nr_ranges].end = end - 1;
> >> - cmem->nr_ranges++;
> >> - }
> >> -
> >> - return 0;
> >> -}
> >> -#endif
> >> -
> >> /*
> >> * Tries to add the initrd and DTB to the image. If it is not possible to find
> >> * valid locations, this function will undo changes to the image and return non
> >> diff --git a/arch/loongarch/kernel/machine_kexec_file.c b/arch/loongarch/kernel/machine_kexec_file.c
> >> index 5412aa9f3568..481b8f906a56 100644
> >> --- a/arch/loongarch/kernel/machine_kexec_file.c
> >> +++ b/arch/loongarch/kernel/machine_kexec_file.c
> >> @@ -13,7 +13,6 @@
> >> #include <linux/ioport.h>
> >> #include <linux/kernel.h>
> >> #include <linux/kexec.h>
> >> -#include <linux/memblock.h>
> >> #include <linux/slab.h>
> >> #include <linux/string.h>
> >> #include <linux/types.h>
> >> @@ -56,32 +55,6 @@ static void cmdline_add_initrd(struct kimage *image, unsigned long *cmdline_tmpl
> >> }
> >>
> >> #ifdef CONFIG_CRASH_DUMP
> >> -unsigned int arch_get_system_nr_ranges(void)
> >> -{
> >> - int nr_ranges = 2; /* for exclusion of crashkernel region */
> >> - phys_addr_t start, end;
> >> - uint64_t i;
> >> -
> >> - for_each_mem_range(i, &start, &end)
> >> - nr_ranges++;
> >> -
> >> - return nr_ranges;
> >> -}
> >> -
> >> -int arch_crash_populate_cmem(struct crash_mem *cmem)
> >> -{
> >> - phys_addr_t start, end;
> >> - uint64_t i;
> >> -
> >> - for_each_mem_range(i, &start, &end) {
> >> - cmem->ranges[cmem->nr_ranges].start = start;
> >> - cmem->ranges[cmem->nr_ranges].end = end - 1;
> >> - cmem->nr_ranges++;
> >> - }
> >> -
> >> - return 0;
> >> -}
> >> -
> >> /*
> >> * Add the "mem=size@start" command line parameter to command line, indicating the
> >> * memory region the new kernel can use to boot into.
> >> diff --git a/arch/riscv/kernel/machine_kexec_file.c b/arch/riscv/kernel/machine_kexec_file.c
> >> index 808e872f4063..fdc6695e8588 100644
> >> --- a/arch/riscv/kernel/machine_kexec_file.c
> >> +++ b/arch/riscv/kernel/machine_kexec_file.c
> >> @@ -37,32 +37,6 @@ int arch_kimage_file_post_load_cleanup(struct kimage *image)
> >> }
> >>
> >> #ifdef CONFIG_CRASH_DUMP
> >> -unsigned int arch_get_system_nr_ranges(void)
> >> -{
> >> - unsigned int nr_ranges = 2 + crashk_cma_cnt; /* For exclusion of crashkernel region */
> >> - u64 i;
> >> - phys_addr_t start, end;
> >> -
> >> - for_each_mem_range(i, &start, &end)
> >> - nr_ranges++;
> >> -
> >> - return nr_ranges;
> >> -}
> >> -
> >> -int arch_crash_populate_cmem(struct crash_mem *cmem)
> >> -{
> >> - u64 i;
> >> - phys_addr_t start, end;
> >> -
> >> - for_each_mem_range(i, &start, &end) {
> >> - cmem->ranges[cmem->nr_ranges].start = start;
> >> - cmem->ranges[cmem->nr_ranges].end = end - 1;
> >> - cmem->nr_ranges++;
> >> - }
> >> -
> >> - return 0;
> >> -}
> >> -
> >> static char *setup_kdump_cmdline(struct kimage *image, char *cmdline,
> >> unsigned long cmdline_len)
> >> {
> >> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> >> index 2b36aa9fade0..77285ae3ce60 100644
> >> --- a/kernel/crash_core.c
> >> +++ b/kernel/crash_core.c
> >> @@ -281,8 +281,29 @@ static struct crash_mem *alloc_cmem(unsigned int nr_ranges)
> >> return cmem;
> >> }
> >>
> >> -unsigned int __weak arch_get_system_nr_ranges(void) { return 0; }
> >> -int __weak arch_crash_populate_cmem(struct crash_mem *cmem) { return -1; }
> >> +unsigned int __weak arch_get_system_nr_ranges(void)
> >> +{
> >> + unsigned int nr_ranges = 2 + crashk_cma_cnt; /* crashk_res + crashk_low_res, +CMA splits */
> >> + phys_addr_t start, end;
> >> + u64 i;
> >> +
> >> + for_each_mem_range(i, &start, &end)
> >> + nr_ranges++;
> >> + return nr_ranges;
> >> +}
> >> +
> >> +int __weak arch_crash_populate_cmem(struct crash_mem *cmem)
> >> +{
> >> + phys_addr_t start, end;
> >> + u64 i;
> >> +
> >> + for_each_mem_range(i, &start, &end) {
> >> + cmem->ranges[cmem->nr_ranges].start = start;
> >> + cmem->ranges[cmem->nr_ranges].end = end - 1;
> >> + cmem->nr_ranges++;
> >> + }
> >> + return 0;
> >> +}
> >> int __weak arch_crash_exclude_ranges(struct crash_mem *cmem) { return 0; }
> >>
> >> int __weak arch_crash_exclude_mem_range(struct crash_mem **mem,
> >> --
> >> 2.43.0
> >>
>
next prev parent reply other threads:[~2026-09-18 8:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 7:31 [PATCH v6 00/10] kdump: reduce vmcore size and capture time Wandun Chen
2026-09-02 7:31 ` [PATCH v6 01/10] mm: memblock: add missing HugeTLB flag name Wandun Chen
2026-09-14 5:20 ` Mike Rapoport
2026-09-15 12:49 ` Wandun
2026-09-02 7:31 ` [PATCH v6 02/10] riscv: build crash_mem ranges from memblock instead of resource tree Wandun Chen
2026-09-21 5:48 ` Baoquan He
2026-09-02 7:31 ` [PATCH v6 03/10] crash_core: fold duplicated memblock arch hooks into the weak default Wandun Chen
2026-09-18 7:30 ` Baoquan He
2026-09-18 8:45 ` Wandun
2026-09-18 8:48 ` Baoquan He [this message]
2026-09-02 7:31 ` [PATCH v6 04/10] crash_core: serialize crash header preparation against hotplug Wandun Chen
2026-09-18 7:54 ` Baoquan He
2026-09-02 7:31 ` [PATCH v6 05/10] crash_core: replace for_each_mem_range() with for_each_mem_region() Wandun Chen
2026-09-18 8:04 ` Baoquan He
2026-09-02 7:31 ` [PATCH v6 06/10] memblock: introduce MEMBLOCK_NODUMP flag Wandun Chen
2026-09-18 7:00 ` Mike Rapoport
2026-09-18 8:08 ` Baoquan He
2026-09-18 8:22 ` Wandun
2026-09-19 7:11 ` Mike Rapoport
2026-09-20 3:33 ` Baoquan He
2026-09-20 8:00 ` Wandun
2026-09-21 5:52 ` Baoquan He
2026-09-02 7:31 ` [PATCH v6 07/10] of: reserved_mem: add dumpable flag to opt-in vmcore Wandun Chen
2026-09-17 21:56 ` Rob Herring (Arm)
2026-09-02 7:31 ` [PATCH v6 08/10] of: reserved_mem: mark /reserved-memory entries with MEMBLOCK_NODUMP Wandun Chen
2026-09-03 7:32 ` Marek Szyprowski
2026-09-17 21:56 ` Rob Herring (Arm)
2026-09-02 7:31 ` [PATCH v6 09/10] of: reserved_mem: mark /memreserve/ entries as MEMBLOCK_NODUMP Wandun Chen
2026-09-03 7:32 ` Marek Szyprowski
2026-09-02 7:31 ` [PATCH v6 10/10] crash_core: skip MEMBLOCK_NODUMP regions when building vmcore ELF header Wandun Chen
2026-09-18 8:09 ` Baoquan He
2026-09-02 8:53 ` [PATCH v6 00/10] kdump: reduce vmcore size and capture time Baoquan He
2026-09-03 7:05 ` Wandun
2026-09-03 7:31 ` Baoquan He
2026-09-03 7:43 ` Wandun
2026-09-03 9:38 ` Baoquan He
2026-09-04 11:08 ` Chen Wandun
2026-09-15 13:01 ` Wandun
2026-09-18 7:03 ` Mike Rapoport
2026-09-18 7:31 ` Baoquan He
2026-09-18 8:17 ` Baoquan He
2026-09-18 10:53 ` Wandun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqz66dMlp3NiMifc@fedora \
--to=baoquan.he@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chenwandun1@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux.dev \
--cc=kernel@xen0n.name \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pasha.tatashin@soleen.com \
--cc=pjw@kernel.org \
--cc=pratyush@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=ruirui.yang@linux.dev \
--cc=saravanak@kernel.org \
--cc=tglx@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®