From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Thierry Chatard <tchatard@gmail.com>
Cc: linux-kernel@vger.kernel.org, hansg@kernel.org, lee@kernel.org,
platform-driver-x86@vger.kernel.org,
ilpo.jarvinen@linux.intel.com, djrscally@gmail.com,
dan.scally@ideasonboard.com, linux-media@vger.kernel.org,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
jacopo.mondi@ideasonboard.com, nicholas@rothemail.net,
v.vitovt@gmail.com, dmanresa@gmail.com
Subject: Re: [PATCH v11 4/9] platform/x86: int3472: tps68470: move Windows MFD setup below the device-type switch
Date: Fri, 2 Oct 2026 16:36:11 +0300 [thread overview]
Message-ID: <ar-zSxE7drHMn7eg@ashevche-desk.local> (raw)
In-Reply-To: <20260930214321.600863-5-tchatard@gmail.com>
On Wed, Sep 30, 2026 at 02:43:16PM -0700, Thierry Chatard wrote:
> The Windows path looks up the board data, builds the tps68470-clk
> platform data and registers the MFD cells; none of this is needed for the
> ChromeOS path, which registers its own cells. Move that handling out of
> the switch and let the ChromeOS case return directly, so the Windows-only
> work is no longer done for ChromeOS and the function reads top to bottom.
>
> While moving the code, use a local struct device *dev to shorten the many
> &client->dev references, and return -ENODATA (rather than -ENODEV) when no
> board data matches this machine, to distinguish it from a missing device.
>
> No functional change for either path.
> Assisted-by: Claude Code:claude-opus-4-8
Assisted-by: LLM
> Signed-off-by: Thierry Chatard <tchatard@gmail.com>
...
> regmap = devm_regmap_init_i2c(client, &tps68470_regmap_config);
> if (IS_ERR(regmap)) {
> - dev_err(&client->dev, "Failed to create regmap: %ld\n", PTR_ERR(regmap));
> + dev_err(dev, "Failed to create regmap: %ld\n", PTR_ERR(regmap));
This is unrelated to the patch. It belongs to a separate change.
Same for the similar cases below.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-02 13:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 21:43 [PATCH v11 0/9] Enable cameras on Dell Latitude 5285 2-in-1 Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 1/9] mfd: intel-lpss: add resource conflict quirk for Dell Latitude 5285 Thierry Chatard
2026-10-01 5:32 ` Sakari Ailus
2026-10-02 10:00 ` Lee Jones
2026-10-01 7:05 ` Andy Shevchenko
2026-10-01 7:24 ` Sakari Ailus
2026-10-01 18:34 ` Andy Shevchenko
2026-09-30 21:43 ` [PATCH v11 2/9] mfd: intel-lpss: add Dell Latitude 7275 to the resource conflict quirk Thierry Chatard
2026-10-01 7:06 ` Andy Shevchenko
2026-10-01 18:16 ` D. Manresa
2026-09-30 21:43 ` [PATCH v11 3/9] platform/x86: int3472: tps68470: use unsigned int for GPIO lookup loop counters Thierry Chatard
2026-10-02 13:34 ` Andy Shevchenko
2026-09-30 21:43 ` [PATCH v11 4/9] platform/x86: int3472: tps68470: move Windows MFD setup below the device-type switch Thierry Chatard
2026-10-02 13:36 ` Andy Shevchenko [this message]
2026-09-30 21:43 ` [PATCH v11 5/9] platform/x86: int3472: tps68470: add static clock consumer support Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 6/9] platform/x86: int3472: tps68470: use a common always-on VIO regulator init_data Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 7/9] platform/x86: int3472: tps68470: add board data for Dell Latitude 5285 Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 8/9] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Thierry Chatard
2026-09-30 21:43 ` [PATCH v11 9/9] media: ov8858: add ACPI device ID INT3477 Thierry Chatard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar-zSxE7drHMn7eg@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=dan.scally@ideasonboard.com \
--cc=djrscally@gmail.com \
--cc=dmanresa@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicholas@rothemail.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tchatard@gmail.com \
--cc=v.vitovt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®