* [PATCH] mtd: cfi_cmdset_0001: use assign_bit() where applicable
@ 2026-09-19 13:08 Peng Fan (OSS)
2026-09-21 8:17 ` Breno Leitao
0 siblings, 1 reply; 2+ messages in thread
From: Peng Fan (OSS) @ 2026-09-19 13:08 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Kees Cook, Karl Mehltretter, Peng Fan, Breno Leitao
Cc: linux-kernel, linux-mtd
From: Peng Fan <peng.fan@nxp.com>
Convert open-coded if/else with set_bit/clear_bit to the assign_bit API.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/mtd/chips/cfi_cmdset_0001.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
index 60d82a1acb01..e5805eebeed6 100644
--- a/drivers/mtd/chips/cfi_cmdset_0001.c
+++ b/drivers/mtd/chips/cfi_cmdset_0001.c
@@ -2520,10 +2520,7 @@ static void cfi_intelext_save_locks(struct mtd_info *mtd)
status = cfi_varsize_frob(mtd,
do_getlockstatus_oneblock, adr, len, NULL);
- if (status)
- set_bit(block, region->lockmap);
- else
- clear_bit(block, region->lockmap);
+ assign_bit(block, region->lockmap, status);
}
}
}
--
2.51.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: cfi_cmdset_0001: use assign_bit() where applicable
2026-09-19 13:08 [PATCH] mtd: cfi_cmdset_0001: use assign_bit() where applicable Peng Fan (OSS)
@ 2026-09-21 8:17 ` Breno Leitao
0 siblings, 0 replies; 2+ messages in thread
From: Breno Leitao @ 2026-09-21 8:17 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Kees Cook, Karl Mehltretter, Peng Fan, linux-kernel, linux-mtd
On Sat, Sep 19, 2026 at 09:08:06PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert open-coded if/else with set_bit/clear_bit to the assign_bit API.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-21 8:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-19 13:08 [PATCH] mtd: cfi_cmdset_0001: use assign_bit() where applicable Peng Fan (OSS)
2026-09-21 8:17 ` Breno Leitao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®