From: Thierry Reding <thierry.reding@kernel.org>
To: Sheetal <sheetal@nvidia.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sameer Pujar <spujar@nvidia.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mohan Kumar <mkumard@nvidia.com>,
linux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/3] ASoC: tegra: Fix ASRC Stream6 input threshold control
Date: Mon, 21 Sep 2026 13:38:03 +0200 [thread overview]
Message-ID: <arEWz1DC2sg266Kv@orome> (raw)
In-Reply-To: <20260921085704.1248920-2-sheetal@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On Mon, Sep 21, 2026 at 08:57:02AM +0000, Sheetal wrote:
> The Stream6 Input Threshold control points at stream index 4, which is
> already used by Stream5. The threshold get and put callbacks derive the
> lane ID from the register offset, so the duplicate index makes Stream6
> operate on lane 4 and leaves lane 5 inaccessible from userspace.
>
> Use stream index 5 for Stream6.
>
> Fixes: a2df8c2d5b36 ("ASoC: tegra: Add Tegra186 based ASRC driver")
> Signed-off-by: Sheetal <sheetal@nvidia.com>
> ---
> sound/soc/tegra/tegra186_asrc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This should be a separate patch since it fixes an existing problem and
is not related to the rework in subsequent patches. It also shouldn't be
blocked on any discussion regarding the ABI change.
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-09-21 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 8:57 [RFC PATCH 0/3] ASoC: tegra: ASRC control fixes and ratio caching Sheetal
2026-09-21 8:57 ` [RFC PATCH 1/3] ASoC: tegra: Fix ASRC Stream6 input threshold control Sheetal
2026-09-21 11:38 ` Thierry Reding [this message]
2026-09-21 8:57 ` [RFC PATCH 2/3] ASoC: tegra: Update ASRC ratio controls Sheetal
2026-09-21 11:50 ` Thierry Reding
2026-09-21 8:57 ` [RFC PATCH 3/3] ASoC: tegra: Cache ASRC ratios until streams are active Sheetal
2026-09-21 12:07 ` [RFC PATCH 0/3] ASoC: tegra: ASRC control fixes and ratio caching Thierry Reding
2026-09-21 12:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arEWz1DC2sg266Kv@orome \
--to=thierry.reding@kernel.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=sheetal@nvidia.com \
--cc=spujar@nvidia.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®