mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@kernel.org>
To: Sheetal <sheetal@nvidia.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	 Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	 Jonathan Hunter <jonathanh@nvidia.com>,
	Sameer Pujar <spujar@nvidia.com>,
	 Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Mohan Kumar <mkumard@nvidia.com>,
	linux-sound@vger.kernel.org,  linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] ASoC: tegra: ASRC control fixes and ratio caching
Date: Mon, 21 Sep 2026 14:07:19 +0200	[thread overview]
Message-ID: <arEaioTIrCyJqwKn@orome> (raw)
In-Reply-To: <20260921085704.1248920-1-sheetal@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1870 bytes --]

On Mon, Sep 21, 2026 at 08:57:01AM +0000, Sheetal wrote:
> This RFC series updates the Tegra186 ASRC driver control handling.
> 
> The main RFC point is the userspace-visible ALSA mixer control ABI
> change in patch 2. The existing per-stream controls expose the software
> ratio as separate integer and fractional mixer controls. This series
> replaces each pair with one two-value mixer control so userspace updates
> the integer and fractional parts together. That avoids programming a
> transient mixed ratio to hardware, but it does require userspace that
> sets ASRC software ratios to switch to the new paired controls.

Given the ABI change, do we have a good understanding of who might be
using these features? My understanding is that these are used for the
setup of hardware pipelines involving sample rate conversions. So these
are likely not your regular users that just want to change the volume
for headphones and such. This is for highly specific use-cases. Do we
know if people use extra userspace software on top of ALSA to set these
up, or are they typically dealing with fixed configuration files for
specifying these values?

So essentially to be able to better understand how to proceed it'd be
good to know what the upgrade path is for this. How easy or difficult
will it be for people to transition to this? Can we transition them
automatically by keeping write-only backwards-compatibility controls
that mirror the old ABI and maybe provide a hint that people should be
upgrading to the new controls?

Since we expect this to also fix the occasional glitch caused by
mismatched ratios, I think we really want this, but we need to make sure
users aren't left in the dark about such changes and have a reasonable
upgrade path.

Mark, Liam, do you have any guidelines on how to handle such ABI
changes?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2026-09-21 12:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  8:57 Sheetal
2026-09-21  8:57 ` [RFC PATCH 1/3] ASoC: tegra: Fix ASRC Stream6 input threshold control Sheetal
2026-09-21 11:38   ` Thierry Reding
2026-09-21  8:57 ` [RFC PATCH 2/3] ASoC: tegra: Update ASRC ratio controls Sheetal
2026-09-21 11:50   ` Thierry Reding
2026-09-21  8:57 ` [RFC PATCH 3/3] ASoC: tegra: Cache ASRC ratios until streams are active Sheetal
2026-09-21 12:07 ` Thierry Reding [this message]
2026-09-21 12:51   ` [RFC PATCH 0/3] ASoC: tegra: ASRC control fixes and ratio caching Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arEaioTIrCyJqwKn@orome \
    --to=thierry.reding@kernel.org \
    --cc=broonie@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkumard@nvidia.com \
    --cc=perex@perex.cz \
    --cc=sheetal@nvidia.com \
    --cc=spujar@nvidia.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®