* [PATCH] staging: greybus: gpio: add comment describing irq_lock mutex
@ 2026-09-21 12:28 UgwuRhema
2026-09-21 13:25 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: UgwuRhema @ 2026-09-21 12:28 UTC (permalink / raw)
To: johan
Cc: UgwuRhema, Rui Miguel Silva, Alex Elder, Greg Kroah-Hartman,
greybus-dev, linux-staging, linux-kernel
Add a description comment for irq_lock to clarify what the mutex
protects and satisfy checkpatch checks.
Signed-off-by: UgwuRhema <hikarialiyev@gmail.com>
---
drivers/staging/greybus/gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 12185f7a9..7f19b3275 100644
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -39,7 +39,7 @@ struct gb_gpio_controller {
struct gpio_chip chip;
struct irq_chip irqc;
- struct mutex irq_lock;
+ struct mutex irq_lock; /* protects IRQ configuration and hardware state */
};
static struct gpio_chip *irq_data_to_gpio_chip(struct irq_data *d)
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging: greybus: gpio: add comment describing irq_lock mutex
2026-09-21 12:28 [PATCH] staging: greybus: gpio: add comment describing irq_lock mutex UgwuRhema
@ 2026-09-21 13:25 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-09-21 13:25 UTC (permalink / raw)
To: UgwuRhema
Cc: johan, Rui Miguel Silva, Alex Elder, Greg Kroah-Hartman,
greybus-dev, linux-staging, linux-kernel
On Mon, Sep 21, 2026 at 12:28:43PM +0000, UgwuRhema wrote:
> Add a description comment for irq_lock to clarify what the mutex
> protects and satisfy checkpatch checks.
>
> Signed-off-by: UgwuRhema <hikarialiyev@gmail.com>
> ---
> drivers/staging/greybus/gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
> index 12185f7a9..7f19b3275 100644
> --- a/drivers/staging/greybus/gpio.c
> +++ b/drivers/staging/greybus/gpio.c
> @@ -39,7 +39,7 @@ struct gb_gpio_controller {
>
> struct gpio_chip chip;
> struct irq_chip irqc;
> - struct mutex irq_lock;
> + struct mutex irq_lock; /* protects IRQ configuration and hardware state */
No, I wouldn't say this is accurate at all.
regards,
dan carpenter
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-21 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-21 12:28 [PATCH] staging: greybus: gpio: add comment describing irq_lock mutex UgwuRhema
2026-09-21 13:25 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®