Re: [PATCH v8 05/25] iommu/arm-smmu-v3: Move hitless machinery to common code

[Nicolin Chen <nicolinc@nvidia.com>]

On Tue, Sep 22, 2026 at 01:12:38PM +0000, Mostafa Saleh wrote:
> Move the hitless STE functions to the common file so it can be
> reused by the hypervisor.

s/it/they

> No functional change.
> 
> Signed-off-by: Mostafa Saleh <smostafa@google.com>

Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>

With some nits:

> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> @@ -59,10 +59,8 @@ enum arm_smmu_msi_index {
>  	ARM_SMMU_MAX_MSIS,
>  };
>  
> -#define NUM_ENTRY_QWORDS 8
>  static_assert(sizeof(struct arm_smmu_ste) == NUM_ENTRY_QWORDS * sizeof(u64));
>  static_assert(sizeof(struct arm_smmu_cd) == NUM_ENTRY_QWORDS * sizeof(u64));
> -
>  static phys_addr_t arm_smmu_msi_cfg[ARM_SMMU_MAX_MSIS][3] = {

This line removal seems unnecessary.

> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
> @@ -1321,6 +1316,8 @@ static inline u64 arm_smmu_tlb_inv_range_enc(u8 num, u8 scale)
>  		FIELD_PREP(CMDQ_TLBI_0_SCALE, scale & 0x1f);
>  }
>  
> +#define NUM_ENTRY_QWORDS 8
> +

Maybe we should drop the duplicated define in arm-smmu-v3-test.c?

Nicolin