From: Kiryl Shutsemau <kas@kernel.org>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86/tdx: Remove the early #VE handler
Date: Thu, 24 Sep 2026 11:48:42 +0100 [thread overview]
Message-ID: <arT_p-dhkHix5fyj@thinkstation> (raw)
In-Reply-To: <d940f1bb8bf51915c7efb19f79760859ad8a45df.camel@intel.com>
On Tue, Sep 22, 2026 at 05:45:03PM +0000, Verma, Vishal L wrote:
> On Tue, 2026-09-22 at 11:19 +0100, Kiryl Shutsemau wrote:
> >
> > Could you just check what happens you panic early (like in
> > tdx_early_init()) with and without the patch?
>
> Tested this:
>
> ---
>
> arch/x86/coco/tdx/tdx.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c
> index f904a636d449..fcb2ecf055d1 100644
> --- a/arch/x86/coco/tdx/tdx.c
> +++ b/arch/x86/coco/tdx/tdx.c
> @@ -1192,4 +1192,7 @@ void __init tdx_early_init(void)
> x86_cpuinit.parallel_bringup = false;
>
> tdx_announce();
> +
> + panic("early #VE window panic test");
> }
>
> ---
>
> In both cases, with and without the removal patch, the guest just hangs
> without any actual text in the serial output. I didn't add any panic=
> cmdline, and CONFIG_PANIC_TIMEOUT was the default 0.
Okay, I run out of excuses. We can revert it later, if there's an actual
problem I cannot recall.
Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
--
Kiryl Shutsemau / Kirill A. Shutemov
prev parent reply other threads:[~2026-09-24 10:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 18:28 Vishal Verma
2026-09-10 20:39 ` Edgecombe, Rick P
2026-09-11 0:15 ` Verma, Vishal L
2026-09-11 10:37 ` Kiryl Shutsemau
2026-09-11 15:24 ` Edgecombe, Rick P
2026-09-11 16:07 ` Kiryl Shutsemau
2026-09-11 17:51 ` Edgecombe, Rick P
2026-09-21 21:20 ` Verma, Vishal L
2026-09-22 10:19 ` Kiryl Shutsemau
2026-09-22 17:45 ` Verma, Vishal L
2026-09-24 10:48 ` Kiryl Shutsemau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arT_p-dhkHix5fyj@thinkstation \
--to=kas@kernel.org \
--cc=ak@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®