From: Mark Rutland <mark.rutland@arm.com>
To: Steffen Eiden <seiden@linux.ibm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andreas Grapentin <gra@linux.ibm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH] arm64: Use proper include variant
Date: Thu, 24 Sep 2026 13:54:54 +0100 [thread overview]
Message-ID: <arUdntLjLT6BD6zJ@J2N7QTR9R3> (raw)
In-Reply-To: <20260924-syreg-incl-v1-1-a3097a8ccc74@linux.ibm.com>
On Thu, Sep 24, 2026 at 12:57:18PM +0200, Steffen Eiden wrote:
> Use <> for including the sysreg header as it is not discoverable from
> the current directory.
>
> Acked-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
I'm surprised that happens to work today, but evidently it does.
Mark.
> ---
> This is just a spin off from [1]. There is no in-series dependency for
> this patch and it fixes a minor issue. Using " for the include file does
> not break anything (now) but it is not right as well. For [1] we need
> this to correctly transform the includes to a new path for the
> s390-generated version of this file.
>
> Steffen
>
> [1] https://lore.kernel.org/all/20260918133107.1042730-1-seiden@linux.ibm.com/
> ---
> arch/arm64/include/asm/sysreg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
> index 7aa08d59d494..4bfdac9401bd 100644
> --- a/arch/arm64/include/asm/sysreg.h
> +++ b/arch/arm64/include/asm/sysreg.h
> @@ -173,7 +173,7 @@
> * come from here. The header relies on the definition of sys_reg()
> * earlier in this file.
> */
> -#include "asm/sysreg-defs.h"
> +#include <asm/sysreg-defs.h>
>
> /*
> * System registers, organised loosely by encoding but grouped together
>
>
>
next prev parent reply other threads:[~2026-09-24 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 10:57 Steffen Eiden
2026-09-24 12:54 ` Mark Rutland [this message]
2026-09-24 16:03 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arUdntLjLT6BD6zJ@J2N7QTR9R3 \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=gra@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=seiden@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®