mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: Use proper include variant
@ 2026-09-24 10:57 Steffen Eiden
  2026-09-24 12:54 ` Mark Rutland
  2026-09-24 16:03 ` Catalin Marinas
  0 siblings, 2 replies; 3+ messages in thread
From: Steffen Eiden @ 2026-09-24 10:57 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon, Mark Rutland
  Cc: Steffen Eiden, Andreas Grapentin, linux-arm-kernel, linux-kernel,
	Marc Zyngier

Use <> for including the sysreg header as it is not discoverable from
the current directory.

Acked-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
---
This is just a spin off from [1]. There is no in-series dependency for
this patch and it fixes a minor issue. Using " for the include file does
not break anything (now) but it is not right as well. For [1] we need
this to correctly transform the includes to a new path for the
s390-generated version of this file.

	Steffen

[1] https://lore.kernel.org/all/20260918133107.1042730-1-seiden@linux.ibm.com/
---
 arch/arm64/include/asm/sysreg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
index 7aa08d59d494..4bfdac9401bd 100644
--- a/arch/arm64/include/asm/sysreg.h
+++ b/arch/arm64/include/asm/sysreg.h
@@ -173,7 +173,7 @@
  * come from here. The header relies on the definition of sys_reg()
  * earlier in this file.
  */
-#include "asm/sysreg-defs.h"
+#include <asm/sysreg-defs.h>
 
 /*
  * System registers, organised loosely by encoding but grouped together




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: Use proper include variant
  2026-09-24 10:57 [PATCH] arm64: Use proper include variant Steffen Eiden
@ 2026-09-24 12:54 ` Mark Rutland
  2026-09-24 16:03 ` Catalin Marinas
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Rutland @ 2026-09-24 12:54 UTC (permalink / raw)
  To: Steffen Eiden
  Cc: Catalin Marinas, Will Deacon, Andreas Grapentin,
	linux-arm-kernel, linux-kernel, Marc Zyngier

On Thu, Sep 24, 2026 at 12:57:18PM +0200, Steffen Eiden wrote:
> Use <> for including the sysreg header as it is not discoverable from
> the current directory.
> 
> Acked-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>

Acked-by: Mark Rutland <mark.rutland@arm.com>

I'm surprised that happens to work today, but evidently it does.

Mark.

> ---
> This is just a spin off from [1]. There is no in-series dependency for
> this patch and it fixes a minor issue. Using " for the include file does
> not break anything (now) but it is not right as well. For [1] we need
> this to correctly transform the includes to a new path for the
> s390-generated version of this file.
> 
> 	Steffen
> 
> [1] https://lore.kernel.org/all/20260918133107.1042730-1-seiden@linux.ibm.com/
> ---
>  arch/arm64/include/asm/sysreg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
> index 7aa08d59d494..4bfdac9401bd 100644
> --- a/arch/arm64/include/asm/sysreg.h
> +++ b/arch/arm64/include/asm/sysreg.h
> @@ -173,7 +173,7 @@
>   * come from here. The header relies on the definition of sys_reg()
>   * earlier in this file.
>   */
> -#include "asm/sysreg-defs.h"
> +#include <asm/sysreg-defs.h>
>  
>  /*
>   * System registers, organised loosely by encoding but grouped together
> 
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: Use proper include variant
  2026-09-24 10:57 [PATCH] arm64: Use proper include variant Steffen Eiden
  2026-09-24 12:54 ` Mark Rutland
@ 2026-09-24 16:03 ` Catalin Marinas
  1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2026-09-24 16:03 UTC (permalink / raw)
  To: Will Deacon, Mark Rutland, Steffen Eiden
  Cc: Andreas Grapentin, linux-arm-kernel, linux-kernel, Marc Zyngier

On Thu, 24 Sep 2026 12:57:18 +0200, Steffen Eiden wrote:
> Use <> for including the sysreg header as it is not discoverable from
> the current directory.

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: Use proper include variant
      https://git.kernel.org/arm64/c/b64f41a7ace1

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-24 16:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-24 10:57 [PATCH] arm64: Use proper include variant Steffen Eiden
2026-09-24 12:54 ` Mark Rutland
2026-09-24 16:03 ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®