* [PATCH v12 1/6] perf mem: Fix size tracking for mem_lvl's in perf_script__meminfo_scnprintf()
2026-09-23 17:08 ` [PATCH v12 0/6] perf: Add support for memory region/range reporting Thomas Falcon
@ 2026-09-23 17:08 ` Thomas Falcon
2026-09-23 17:08 ` [PATCH v12 2/6] perf mem: Add support for printing PERF_MEM_LVLNUM_L0 Thomas Falcon
` (5 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Thomas Falcon @ 2026-09-23 17:08 UTC (permalink / raw)
To: sashiko-bot
Cc: linux-perf-users, linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
James Clark, Dapeng Mi
When printing memory info in perf script, the entire size of the
buffer is passed to perf_mem__lvl_scnprintf() instead of the remaining
size. Pass the remaining buffer size instead.
This issue was detected by sashiko during an internal code review.
Assisted-by: Sashiko:gemini-3.1-pro-preview
Fixes: fdefc3750e847 ("perf mem: Print memory operation type")
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>
---
tools/perf/util/mem-events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index 0b49fce251fc..4e490f9cd348 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -610,7 +610,7 @@ int perf_script__meminfo_scnprintf(char *out, size_t sz, const struct mem_info *
i += scnprintf(out, sz, "|OP ");
i += perf_mem__op_scnprintf(out + i, sz - i, mem_info);
i += scnprintf(out + i, sz - i, "|LVL ");
- i += perf_mem__lvl_scnprintf(out + i, sz, mem_info);
+ i += perf_mem__lvl_scnprintf(out + i, sz - i, mem_info);
i += scnprintf(out + i, sz - i, "|SNP ");
i += perf_mem__snp_scnprintf(out + i, sz - i, mem_info);
i += scnprintf(out + i, sz - i, "|TLB ");
--
2.43.0
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v12 2/6] perf mem: Add support for printing PERF_MEM_LVLNUM_L0
2026-09-23 17:08 ` [PATCH v12 0/6] perf: Add support for memory region/range reporting Thomas Falcon
2026-09-23 17:08 ` [PATCH v12 1/6] perf mem: Fix size tracking for mem_lvl's in perf_script__meminfo_scnprintf() Thomas Falcon
@ 2026-09-23 17:08 ` Thomas Falcon
2026-09-23 17:09 ` [PATCH v12 3/6] perf header: Support memory ranges Thomas Falcon
` (4 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Thomas Falcon @ 2026-09-23 17:08 UTC (permalink / raw)
To: sashiko-bot
Cc: linux-perf-users, linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
James Clark, Dapeng Mi
From: Dapeng Mi <dapeng1.mi@linux.intel.com>
Add support for printing PERF_MEM_LVLNUM_L0 in perf mem report.
The L0 cache is newly added a small piece of cache which is
the closest, lowest-latency memory cache tied directly to the
execution pipeline.
The table "Table 9-4. Data Source Field Encodings for Panther
Cove and Coyote Cove Microarchitectures" in the ISE doc chapter
"9.2.1 Panther Cove and Coyote Cove Microarchitectures Memory
Auxiliary Field Layout"[1] indicates the code "01H" means the
"L0 Hit - Minimal latency core cache hit. This request was
satisfied by the L0 data cache."
[1]: https://www.intel.com/content/www/us/en/content-details/922690/intel-architecture-instruction-set-extensions-programming-reference.html
Assisted-by: Sashiko:gemini-3.1-pro-preview
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Co-developed-by: Thomas Falcon <thomas.falcon@intel.com>
Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>
---
v8: Updated developer tags
v3: Included more information about the L0 cache in the commit message.
---
tools/perf/Documentation/perf-record.txt | 2 +-
tools/perf/util/bpf-filter.l | 1 +
tools/perf/util/mem-events.c | 5 +++++
tools/perf/util/mem-events.h | 1 +
4 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
index 388455f9b07b..bd2c56d8cdc0 100644
--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -212,7 +212,7 @@ OPTIONS
The <value> can be one of:
<number> (for any term)
na, load, store, pfetch, exec (for mem_op)
- l1, l2, l3, l4, cxl, io, any_cache, lfb, ram, pmem (for mem_lvl)
+ l0, l1, l2, l3, l4, cxl, io, any_cache, lfb, ram, pmem (for mem_lvl)
na, none, hit, miss, hitm, fwd, peer (for mem_snoop)
remote (for mem_remote)
na, locked (for mem_locked)
diff --git a/tools/perf/util/bpf-filter.l b/tools/perf/util/bpf-filter.l
index 6aa65ade3385..1be9df6550fc 100644
--- a/tools/perf/util/bpf-filter.l
+++ b/tools/perf/util/bpf-filter.l
@@ -131,6 +131,7 @@ store { return constant(PERF_MEM_OP_STORE); }
pfetch { return constant(PERF_MEM_OP_PFETCH); }
exec { return constant(PERF_MEM_OP_EXEC); }
+l0 { return constant(PERF_MEM_LVLNUM_L0); }
l1 { return constant(PERF_MEM_LVLNUM_L1); }
l2 { return constant(PERF_MEM_LVLNUM_L2); }
l3 { return constant(PERF_MEM_LVLNUM_L3); }
diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index 4e490f9cd348..4fd48fd20055 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -391,6 +391,7 @@ static const char * const mem_lvlnum[] = {
[PERF_MEM_LVLNUM_L4] = "L4",
[PERF_MEM_LVLNUM_L2_MHB] = "L2 MHB",
[PERF_MEM_LVLNUM_MSC] = "Memory-side Cache",
+ [PERF_MEM_LVLNUM_L0] = "L0",
[PERF_MEM_LVLNUM_UNC] = "Uncached",
[PERF_MEM_LVLNUM_CXL] = "CXL",
[PERF_MEM_LVLNUM_IO] = "I/O",
@@ -831,6 +832,8 @@ int mem_stat_index(const enum mem_stat_type mst, const u64 val)
}
case PERF_MEM_STAT_CACHE:
switch (src.mem_lvl_num) {
+ case PERF_MEM_LVLNUM_L0:
+ return MEM_STAT_CACHE_L0;
case PERF_MEM_LVLNUM_L1:
return MEM_STAT_CACHE_L1;
case PERF_MEM_LVLNUM_L2:
@@ -915,6 +918,8 @@ const char *mem_stat_name(const enum mem_stat_type mst, const int idx)
}
case PERF_MEM_STAT_CACHE:
switch (idx) {
+ case MEM_STAT_CACHE_L0:
+ return "L0";
case MEM_STAT_CACHE_L1:
return "L1";
case MEM_STAT_CACHE_L2:
diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
index 5b98076904b0..daa22748f9fe 100644
--- a/tools/perf/util/mem-events.h
+++ b/tools/perf/util/mem-events.h
@@ -109,6 +109,7 @@ enum mem_stat_op {
};
enum mem_stat_cache {
+ MEM_STAT_CACHE_L0,
MEM_STAT_CACHE_L1,
MEM_STAT_CACHE_L2,
MEM_STAT_CACHE_L3,
--
2.43.0
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v12 3/6] perf header: Support memory ranges
2026-09-23 17:08 ` [PATCH v12 0/6] perf: Add support for memory region/range reporting Thomas Falcon
2026-09-23 17:08 ` [PATCH v12 1/6] perf mem: Fix size tracking for mem_lvl's in perf_script__meminfo_scnprintf() Thomas Falcon
2026-09-23 17:08 ` [PATCH v12 2/6] perf mem: Add support for printing PERF_MEM_LVLNUM_L0 Thomas Falcon
@ 2026-09-23 17:09 ` Thomas Falcon
2026-09-23 17:09 ` [PATCH v12 4/6] perf tools: Show memory region in perf-c2c subcommand Thomas Falcon
` (3 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Thomas Falcon @ 2026-09-23 17:09 UTC (permalink / raw)
To: sashiko-bot
Cc: linux-perf-users, linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
James Clark, Dapeng Mi
Memory ranges were created to track different types of memory,
such as persistent, high bandwidth, or CXL-attached, that may
be present on a system for performance monitoring and resource
control purposes.
Memory range data are parsed from the ACPI MRRM table and exposed
to userspace tools via sysfs [1]. Memory range data is read from:
/sys/firmware/acpi/memory_ranges/rangeX
With the following attributes:
u64 base;
u64 length;
int node;
u8 local_region_id;
u8 remote_region_id;
Read memory range data from sysfs if present and save it in
the header of the perf data file under a new feature bit,
HEADER_MEMORY_RANGES (35). Memory range data can be viewed with the
--header or --header-only options of perf-report and perf-script.
Example output:
# memory ranges (nr 5):
# range0: [0x0000000000000000-0x00000000bfffffff], node = 0, local_region_id = 0, remote_region_id = 255
# range1: [0x0000000100000000-0x000000203fffffff], node = 0, local_region_id = 0, remote_region_id = 255
# range2: [0x0000008000000000-0x0000027fffffffff], node = -2, local_region_id = 1, remote_region_id = 255
# range3: [0x0000028000000000-0x0000047fffffffff], node = -2, local_region_id = 1, remote_region_id = 255
# range4: [0x0000048000000000-0x000004ffffffffff], node = -2, local_region_id = 1, remote_region_id = 255
[1]: https://lore.kernel.org/lkml/20250505173819.419271-1-tony.luck@intel.com/
Assisted-by: Sashiko:gemini-3.1-pro-preview
Assisted-by: GitHub-Copilot:claude-opus-4-8
Reviewed-by: Ian Rogers <irogers@google.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>
---
v12:
-- Fixed typo in bounds checking for max supported memory ranges when
reading header data
v10:
-- Add missing #include <fcntl.h> for open/openat/O_DIRECTORY (Sashiko)
-- Fix up incorrectly formatted comment in process_memory_ranges()
v4:
-- Fixed bounds checking for local and remote region IDs in
memory_range__read(), which made region "255" invalid
v3:
-- Added missing ff->size check in process_memory_ranges()
-- used open/openat to read memory range sysfs files in memory_range__read()
-- Removed path name and file name buffers in memory_range__read(),
instead pass path name from as a parameter from memory_range__parse()
-- use calloc instead of zalloc in memory_range__parse() and
process_memory_ranges()
-- Removed redundant check for existance of memory range directory in
memory_range__read()
-- Included examples of memory range output in commit message
v2:
-- Added check for NULL return of sysfs__mountpoint() when parsing
memory ranges in sysfs
-- increased MAX_MEMORY_RANGES sanity check from 64 to 256 based on
ACPI MRRM table implementation in Linux kernel
-- added comment for MAX_MEMORY_RANGES to clarify that it is a sanity check
for malformed perf.data files
-- removed a line of code was removed from util/env.h but was added back in
v1 due to bad rebase
---
.../Documentation/perf.data-file-format.txt | 13 ++
tools/perf/builtin-inject.c | 1 +
tools/perf/util/env.c | 1 +
tools/perf/util/env.h | 10 +
| 205 ++++++++++++++++++
| 1 +
6 files changed, 231 insertions(+)
diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
index b90cba9168f8..1f8e7d8e9ae2 100644
--- a/tools/perf/Documentation/perf.data-file-format.txt
+++ b/tools/perf/Documentation/perf.data-file-format.txt
@@ -478,6 +478,19 @@ The size of the cacheline in bytes. Format:
unsigned int cln_size;
+ HEADER_MEMORY_RANGES = 35,
+
+List of memory ranges. The format of the data is as below.
+
+u32 nr_memory_ranges;
+struct memory_range {
+ u64 base;
+ u64 length;
+ int node;
+ u8 local_region_id;
+ u8 remote_region_id;
+}; [nr_memory_ranges]
+
other bits are reserved and should be ignored for now
HEADER_FEAT_BITS = 256,
diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
index 70bbfad5653e..169617a884d3 100644
--- a/tools/perf/builtin-inject.c
+++ b/tools/perf/builtin-inject.c
@@ -2306,6 +2306,7 @@ static bool keep_feat(struct perf_inject *inject, int feat)
case HEADER_PMU_CAPS:
case HEADER_CPU_DOMAIN_INFO:
case HEADER_CLN_SIZE:
+ case HEADER_MEMORY_RANGES:
return true;
/* Information that can be updated */
case HEADER_BUILD_ID:
diff --git a/tools/perf/util/env.c b/tools/perf/util/env.c
index c0e2b9d5f0b2..50993b0dedc5 100644
--- a/tools/perf/util/env.c
+++ b/tools/perf/util/env.c
@@ -297,6 +297,7 @@ void perf_env__exit(struct perf_env *env)
zfree(&env->pmu_caps[i].pmu_name);
}
zfree(&env->pmu_caps);
+ zfree(&env->memory_ranges);
free_cpu_domain_info(env->cpu_domain, env->schedstat_version, env->nr_cpus_avail);
}
diff --git a/tools/perf/util/env.h b/tools/perf/util/env.h
index 7acca39b42ff..23d35425efe3 100644
--- a/tools/perf/util/env.h
+++ b/tools/perf/util/env.h
@@ -68,6 +68,14 @@ struct cpu_domain_map {
struct domain_info **domains;
};
+struct memory_range {
+ u64 base;
+ u64 length;
+ int node;
+ u8 local_region_id;
+ u8 remote_region_id;
+};
+
struct perf_env {
char *hostname;
char *os_release;
@@ -100,6 +108,7 @@ struct perf_env {
int nr_cpu_pmu_caps;
int nr_hybrid_nodes;
int nr_pmus_with_caps;
+ int nr_memory_ranges;
char *cmdline;
const char **cmdline_argv;
char *sibling_cores;
@@ -122,6 +131,7 @@ struct perf_env {
unsigned long long memory_bsize;
struct hybrid_node *hybrid_nodes;
struct pmu_caps *pmu_caps;
+ struct memory_range *memory_ranges;
#ifdef HAVE_LIBBPF_SUPPORT
/*
* bpf_info_lock protects bpf rbtrees. This is needed because the
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index ec2935c0ed04..38f2da9de5f0 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -7,6 +7,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <fcntl.h>
#include <byteswap.h>
#include <dirent.h>
@@ -95,6 +96,7 @@
#define MAX_PMU_CAPS 512
#define MAX_PMU_MAPPINGS 4096
#define MAX_SCHED_DOMAINS 64
+#define MAX_MEMORY_RANGES 256
/*
* magic2 = "PERFILE2"
@@ -1914,6 +1916,132 @@ static int write_cpu_domain_info(struct feat_fd *ff,
return ret;
}
+static int memory_range__read(struct memory_range *range, const char *path)
+{
+ char buf[32];
+ ssize_t n;
+ int dfd, fd, tmp, ret = -1;
+
+ dfd = open(path, O_RDONLY | O_DIRECTORY);
+ if (dfd < 0)
+ return -1;
+
+#define _R(name, dst, conv) \
+ fd = openat(dfd, name, O_RDONLY); \
+ if (fd < 0) \
+ goto out; \
+ n = read(fd, buf, sizeof(buf) - 1); \
+ close(fd); \
+ if (n <= 0) \
+ goto out; \
+ buf[n] = '\0'; \
+ dst = conv(buf, NULL, 0);
+
+ _R("base", range->base, strtoull);
+ _R("length", range->length, strtoull);
+ _R("node", range->node, strtol);
+ _R("local_region_id", tmp, strtol);
+ if (tmp < 0 || tmp > UINT8_MAX)
+ goto out;
+ range->local_region_id = tmp;
+ _R("remote_region_id", tmp, strtol);
+ if (tmp < 0 || tmp > UINT8_MAX)
+ goto out;
+ range->remote_region_id = tmp;
+#undef _R
+
+ ret = 0;
+out:
+ close(dfd);
+ return ret;
+}
+
+static int memory_range__parse(struct memory_range **ranges)
+{
+ const char *sysfs = sysfs__mountpoint();
+ int i, err, nr_memory_ranges = 0;
+ char path[PATH_MAX];
+ struct stat st;
+
+ if (!sysfs)
+ return 0;
+
+ scnprintf(path, PATH_MAX, "%s/firmware/acpi/memory_ranges", sysfs);
+ if (stat(path, &st))
+ return 0;
+
+ while (1) {
+ scnprintf(path, PATH_MAX,
+ "%s/firmware/acpi/memory_ranges/range%d",
+ sysfs, nr_memory_ranges);
+ if (stat(path, &st))
+ break;
+
+ nr_memory_ranges++;
+ }
+
+ if (nr_memory_ranges == 0)
+ return 0;
+
+ *ranges = calloc(nr_memory_ranges, sizeof(struct memory_range));
+ if (!(*ranges))
+ return -ENOMEM;
+
+ for (i = 0; i < nr_memory_ranges; i++) {
+ struct memory_range range;
+
+ scnprintf(path, PATH_MAX,
+ "%s/firmware/acpi/memory_ranges/range%d", sysfs, i);
+ err = memory_range__read(&range, path);
+ if (err < 0)
+ goto out_error;
+
+ (*ranges)[i] = range;
+ }
+
+ return nr_memory_ranges;
+
+out_error:
+ zfree(ranges);
+ return -1;
+}
+
+static int write_memory_ranges(struct feat_fd *ff,
+ struct evlist *evlist __maybe_unused)
+{
+ struct memory_range *ranges = NULL;
+ int nr_memory_ranges = 0, ret;
+
+ nr_memory_ranges = memory_range__parse(&ranges);
+ if (nr_memory_ranges < 0)
+ return nr_memory_ranges;
+
+ ret = do_write(ff, &nr_memory_ranges, sizeof(nr_memory_ranges));
+ if (ret < 0)
+ goto out;
+
+ for (int i = 0; i < nr_memory_ranges; i++) {
+ ret = do_write(ff, &ranges[i].base, sizeof(u64));
+ if (ret < 0)
+ goto out;
+ ret = do_write(ff, &ranges[i].length, sizeof(u64));
+ if (ret < 0)
+ goto out;
+ ret = do_write(ff, &ranges[i].node, sizeof(u32));
+ if (ret < 0)
+ goto out;
+ ret = do_write(ff, &ranges[i].local_region_id, sizeof(u8));
+ if (ret < 0)
+ goto out;
+ ret = do_write(ff, &ranges[i].remote_region_id, sizeof(u8));
+ if (ret < 0)
+ goto out;
+ }
+out:
+ zfree(&ranges);
+ return ret;
+}
+
static void print_hostname(struct feat_fd *ff, FILE *fp)
{
fprintf(fp, "# hostname : %s\n", ff->ph->env.hostname);
@@ -2652,6 +2780,23 @@ static void print_cpu_domain_info(struct feat_fd *ff, FILE *fp)
}
}
+static void print_memory_ranges(struct feat_fd *ff, FILE *fp)
+{
+ struct memory_range *ranges = ff->ph->env.memory_ranges;
+ int nr_memory_ranges = ff->ph->env.nr_memory_ranges;
+ int i;
+
+ fprintf(fp, "# memory ranges (nr %d):\n", nr_memory_ranges);
+
+ for (i = 0; i < nr_memory_ranges; i++) {
+ fprintf(fp, "# range%u: [0x%016" PRIx64 "-0x%016" PRIx64,
+ i, ranges[i].base, ranges[i].base + ranges[i].length - 1);
+ fprintf(fp, "], node = %d, local_region_id = %d, remote_region_id = %d\n",
+ ranges[i].node, ranges[i].local_region_id,
+ ranges[i].remote_region_id);
+ }
+}
+
static int __event_process_build_id(struct perf_record_header_build_id *bev,
char *filename,
struct perf_session *session)
@@ -4227,6 +4372,65 @@ static int process_cpu_domain_info(struct feat_fd *ff, void *data __maybe_unused
return ret;
}
+static int process_memory_ranges(struct feat_fd *ff, void *data __maybe_unused)
+{
+ struct perf_env *env = &ff->ph->env;
+ struct memory_range *ranges, *r;
+ u32 nr_memory_ranges, i;
+
+ if (do_read_u32(ff, &nr_memory_ranges))
+ return -1;
+
+ if (!nr_memory_ranges) {
+ pr_debug("memory ranges not available\n");
+ return 0;
+ }
+
+ /*
+ * According to version 1.1 of the ACPI MRRM table, the maximum
+ * number of memory regions can be at most 255. Do a sanity check
+ * here to guard against a malformed perf.data file.
+ */
+ if (nr_memory_ranges > MAX_MEMORY_RANGES) {
+ pr_err("Invalid memory_ranges: nr_memory_ranges (%u) > %u\n",
+ nr_memory_ranges, MAX_MEMORY_RANGES);
+ return -1;
+ }
+
+ if (ff->size < sizeof(u32) + nr_memory_ranges * (2 * sizeof(u64) + sizeof(u32) + 2 * sizeof(u8))) {
+ pr_err("Invalid HEADER_MEMORY_RANGES: section too small (%zu) for %u range entries\n",
+ ff->size, nr_memory_ranges);
+ return -1;
+ }
+
+ ranges = calloc(nr_memory_ranges, sizeof(*ranges));
+ if (!ranges)
+ return -1;
+
+ for (i = 0; i < nr_memory_ranges; i++) {
+ r = &ranges[i];
+
+ if (do_read_u64(ff, &r->base))
+ goto error;
+ if (do_read_u64(ff, &r->length))
+ goto error;
+ if (do_read_u32(ff, (u32 *) &r->node))
+ goto error;
+ if (__do_read(ff, &r->local_region_id, sizeof(u8)))
+ goto error;
+ if (__do_read(ff, &r->remote_region_id, sizeof(u8)))
+ goto error;
+ }
+
+ env->memory_ranges = ranges;
+ env->nr_memory_ranges = nr_memory_ranges;
+
+ return 0;
+error:
+ zfree(&ranges);
+ return -1;
+}
+
#define FEAT_OPR(n, func, __full_only) \
[HEADER_##n] = { \
.name = __stringify(n), \
@@ -4291,6 +4495,7 @@ const struct perf_header_feature_ops feat_ops[HEADER_LAST_FEATURE] = {
FEAT_OPR(CPU_DOMAIN_INFO, cpu_domain_info, true),
FEAT_OPR(E_MACHINE, e_machine, false),
FEAT_OPR(CLN_SIZE, cln_size, false),
+ FEAT_OPR(MEMORY_RANGES, memory_ranges, false),
};
struct header_print_data {
--git a/tools/perf/util/header.h b/tools/perf/util/header.h
index 5e03f884b7cc..765037762758 100644
--- a/tools/perf/util/header.h
+++ b/tools/perf/util/header.h
@@ -56,6 +56,7 @@ enum {
HEADER_CPU_DOMAIN_INFO,
HEADER_E_MACHINE,
HEADER_CLN_SIZE,
+ HEADER_MEMORY_RANGES,
HEADER_LAST_FEATURE,
HEADER_FEAT_BITS = 256,
};
--
2.43.0
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v12 4/6] perf tools: Show memory region in perf-c2c subcommand
2026-09-23 17:08 ` [PATCH v12 0/6] perf: Add support for memory region/range reporting Thomas Falcon
` (2 preceding siblings ...)
2026-09-23 17:09 ` [PATCH v12 3/6] perf header: Support memory ranges Thomas Falcon
@ 2026-09-23 17:09 ` Thomas Falcon
2026-09-24 0:23 ` Mi, Dapeng
2026-09-23 17:09 ` [PATCH v12 5/6] perf tools: Show memory region in perf-script subcommand Thomas Falcon
` (2 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: Thomas Falcon @ 2026-09-23 17:09 UTC (permalink / raw)
To: sashiko-bot
Cc: linux-perf-users, linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
James Clark, Dapeng Mi
From: Dapeng Mi <dapeng1.mi@linux.intel.com>
Add memory region field to the cacheline list view to help users
identify the memory region to which the cacheline belongs. The memory
region field was included with the introduction of support for the
Off-module Response facility (OMR) [1] in Intel's Diamond Rapids and
Nova Lake architectures.
An example of the new perf c2c output including the memory region
field is shown below:
# Index Address Region Node PA cnt Hitm Total LclHitm RmtHitm records Loads
# ..... .................. ...... .... ...... ....... ....... ....... ....... ....... .......
#
0 0xffffffff84eb0040 N/A 0 1205 23.25% 544 544 0 1677 1677
1 0xffffffff84f03a80 N/A 0 1 18.12% 424 424 0 585 585
[...]
19 0xffffffff845bc840 Mem-0 0 13 0.30% 7 7 0 31 31
20 0xff3bbba284520a00 N/A 0 10 0.26% 6 6 0 11 11
21 0xff3bbbe0bc833500 N/A 0 24 0.26% 6 6 0 30 30
[1]: https://lore.kernel.org/all/20260114011750.350569-1-dapeng1.mi@linux.intel.com/
Assisted-by: Sashiko:gemini-3.1-pro-preview
Assisted-by: GitHub-Copilot:claude-opus-4-8
Reviewed-by: Ian Rogers <irogers@google.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Co-developed-by: Thomas Falcon <thomas.falcon@intel.com>
Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>
---
v11: perf-c2c: revert to only recording a real memory region for a
cacheline
v10: only update mem_region for real cache/memory regions so N/A samples
don't overwrite a valid region; add #include <stdio.h> for asprintf
(Sashiko)
v9: Update perf-c2c to include cache region reporting (Dapeng Mi)
v8: Update developer tags and commit message with real example
output (Dapeng Mi)
v7: fix output_str allocation error handling which introduced
a memory leak (Sashiko)
v6: rebased onto 7.3-rc1
v5: make the cacheline header span and ui_quirks() width
fixup depend on memory-region availability (Namhyung Kim)
v4: correctly handle output_str memory allocation failure
v3: make memory region reporting conditional on feature bit
---
tools/perf/builtin-c2c.c | 114 +++++++++++++++++++++++++++++++++++----
tools/perf/util/c2c.h | 1 +
2 files changed, 104 insertions(+), 11 deletions(-)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 6b64c0d6b24f..a42423ca990d 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -14,6 +14,7 @@
#include <inttypes.h>
#include <stdlib.h>
#include <string.h>
+#include <stdio.h>
#include <asm/bug.h>
#include <linux/compiler.h>
@@ -72,6 +73,7 @@ struct perf_c2c {
bool show_src;
bool show_all;
+ bool show_mem_region;
bool use_stdio;
bool stats_only;
bool symbol_full;
@@ -248,6 +250,18 @@ static void c2c_he__set_node(struct c2c_hist_entry *c2c_he,
}
}
+static void c2c_he__set_mem_region(struct c2c_hist_entry *c2c_he,
+ unsigned int mem_region)
+{
+ if (WARN_ONCE(mem_region > PERF_MEM_REGION_MEM7,
+ "WARNING: invalid memory region ID\n"))
+ return;
+
+ /* Update mem_region only if it really accesses memory */
+ if (mem_region >= PERF_MEM_REGION_MMIO)
+ c2c_he->mem_region = mem_region;
+}
+
static void compute_stats(struct c2c_hist_entry *c2c_he,
struct c2c_stats *stats,
u64 weight)
@@ -306,6 +320,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
struct addr_location al;
struct mem_info *mi = NULL;
struct callchain_cursor *cursor;
+ unsigned int mem_region;
int ret;
addr_location__init(&al);
@@ -333,6 +348,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
}
c2c_decode_stats(&stats, mi);
+ mem_region = mem_info__data_src(mi)->mem_region;
he = hists__add_entry_ops(&c2c_hists->hists, &c2c_entry_ops,
&al, NULL, NULL, mi, NULL,
@@ -349,6 +365,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
c2c_he__set_cpu(c2c_he, sample);
c2c_he__set_node(c2c_he, sample);
c2c_he__set_evsel(c2c_he, evsel);
+ c2c_he__set_mem_region(c2c_he, mem_region);
hists__inc_nr_samples(&c2c_hists->hists, he->filtered);
@@ -402,6 +419,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
c2c_he__set_cpu(c2c_he, sample);
c2c_he__set_node(c2c_he, sample);
c2c_he__set_evsel(c2c_he, evsel);
+ c2c_he__set_mem_region(c2c_he, mem_region);
hists__inc_nr_samples(&c2c_hists->hists, he->filtered);
ret = hist_entry__append_callchain(he, sample);
@@ -540,6 +558,45 @@ dcacheline_node_count(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
return scnprintf(hpp->buf, hpp->size, "%*lu", width, c2c_he->paddr_cnt);
}
+static int
+dcacheline_node_mem_region(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
+ struct hist_entry *he)
+{
+ int width = c2c_width(fmt, hpp, he->hists);
+ struct c2c_hist_entry *c2c_he;
+ unsigned int mem_region;
+ char buf[20];
+
+ c2c_he = container_of(he, struct c2c_hist_entry, he);
+ mem_region = c2c_he->mem_region;
+
+ switch (mem_region) {
+ case PERF_MEM_REGION_NA:
+ case PERF_MEM_REGION_RSVD:
+ scnprintf(buf, sizeof(buf), "N/A");
+ break;
+ case PERF_MEM_REGION_MMIO:
+ scnprintf(buf, sizeof(buf), "MMIO");
+ break;
+ case PERF_MEM_REGION_MEM0:
+ case PERF_MEM_REGION_MEM1:
+ case PERF_MEM_REGION_MEM2:
+ case PERF_MEM_REGION_MEM3:
+ case PERF_MEM_REGION_MEM4:
+ case PERF_MEM_REGION_MEM5:
+ case PERF_MEM_REGION_MEM6:
+ case PERF_MEM_REGION_MEM7:
+ scnprintf(buf, sizeof(buf), "Mem-%d",
+ mem_region - PERF_MEM_REGION_MEM0);
+ break;
+ default:
+ scnprintf(buf, sizeof(buf), "N/A");
+ break;
+ }
+
+ return scnprintf(hpp->buf, hpp->size, "%*s", width, buf);
+}
+
static int offset_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
struct hist_entry *he)
{
@@ -1360,6 +1417,14 @@ static struct c2c_dimension dim_dcacheline_node = {
.width = 4,
};
+static struct c2c_dimension dim_dcacheline_mem_region = {
+ .header = HEADER_LOW("Region"),
+ .name = "dcacheline_mem_region",
+ .cmp = empty_cmp,
+ .entry = dcacheline_node_mem_region,
+ .width = 6,
+};
+
static struct c2c_dimension dim_dcacheline_count = {
.header = HEADER_LOW("PA cnt"),
.name = "dcacheline_count",
@@ -1791,6 +1856,7 @@ static struct c2c_dimension dim_dcacheline_num_empty = {
static struct c2c_dimension *dimensions[] = {
&dim_dcacheline,
+ &dim_dcacheline_mem_region,
&dim_dcacheline_node,
&dim_dcacheline_count,
&dim_offset,
@@ -2854,8 +2920,11 @@ static int ui_quirks(void)
/* Fix the zero line for dcacheline column. */
buf = fill_line(chk_double_cl ? "Double-Cacheline" : "Cacheline",
dim_dcacheline.width +
+ (c2c.show_mem_region ?
+ dim_dcacheline_mem_region.width : 0) +
dim_dcacheline_node.width +
- dim_dcacheline_count.width + 4);
+ dim_dcacheline_count.width +
+ (c2c.show_mem_region ? 6 : 4));
if (!buf)
return -ENOMEM;
@@ -3107,7 +3176,8 @@ static int perf_c2c__report(int argc, const char **argv)
OPT_END()
};
int err = 0;
- const char *output_str, *sort_str = NULL;
+ const char *sort_str = NULL;
+ char *output_str = NULL;
struct perf_env *env;
annotation_options__init();
@@ -3272,9 +3342,16 @@ static int perf_c2c__report(int argc, const char **argv)
goto out_mem2node;
}
- if (c2c.display != DISPLAY_SNP_PEER)
- output_str = "cl_idx,"
+ c2c.show_mem_region = perf_header__has_feat(&session->header,
+ HEADER_MEMORY_RANGES);
+ if (c2c.show_mem_region)
+ dim_dcacheline.header.line[0].span = 3;
+
+ if (c2c.display != DISPLAY_SNP_PEER) {
+ if (asprintf(&output_str,
+ "cl_idx,"
"dcacheline,"
+ "%s"
"dcacheline_node,"
"dcacheline_count,"
"percent_costly_snoop,"
@@ -3286,10 +3363,17 @@ static int perf_c2c__report(int argc, const char **argv)
"ld_fbhit,ld_l1hit,ld_l2hit,"
"ld_lclhit,lcl_hitm,"
"ld_rmthit,rmt_hitm,"
- "dram_lcl,dram_rmt";
- else
- output_str = "cl_idx,"
+ "dram_lcl,dram_rmt",
+ c2c.show_mem_region ?
+ "dcacheline_mem_region," : "") < 0) {
+ err = -ENOMEM;
+ goto out_mem2node;
+ }
+ } else {
+ if (asprintf(&output_str,
+ "cl_idx,"
"dcacheline,"
+ "%s"
"dcacheline_node,"
"dcacheline_count,"
"percent_costly_snoop,"
@@ -3301,7 +3385,13 @@ static int perf_c2c__report(int argc, const char **argv)
"ld_fbhit,ld_l1hit,ld_l2hit,"
"ld_lclhit,lcl_hitm,"
"ld_rmthit,rmt_hitm,"
- "dram_lcl,dram_rmt";
+ "dram_lcl,dram_rmt",
+ c2c.show_mem_region ?
+ "dcacheline_mem_region," : "") < 0) {
+ err = -ENOMEM;
+ goto out_mem2node;
+ }
+ }
if (c2c.display == DISPLAY_TOT_HITM)
sort_str = "tot_hitm";
@@ -3315,7 +3405,7 @@ static int perf_c2c__report(int argc, const char **argv)
err = c2c_hists__reinit(&c2c.hists, output_str, sort_str, perf_session__env(session));
if (err) {
pr_err("Failed to reinitialize hists\n");
- goto out_mem2node;
+ goto out_str;
}
ui_progress__init(&prog, c2c.hists.hists.nr_entries, "Sorting...");
@@ -3324,17 +3414,19 @@ static int perf_c2c__report(int argc, const char **argv)
hists__output_resort_cb(&c2c.hists.hists, &prog, resort_shared_cl_cb);
err = hists__iterate_cb(&c2c.hists.hists, resort_cl_cb, perf_session__env(session));
if (err)
- goto out_mem2node;
+ goto out_str;
ui_progress__finish();
if (ui_quirks()) {
pr_err("failed to setup UI\n");
- goto out_mem2node;
+ goto out_str;
}
perf_c2c_display(session);
+out_str:
+ free(output_str);
out_mem2node:
mem2node__exit(&c2c.mem2node);
out_session:
diff --git a/tools/perf/util/c2c.h b/tools/perf/util/c2c.h
index 53f024e25d99..f04e78e1a2e3 100644
--- a/tools/perf/util/c2c.h
+++ b/tools/perf/util/c2c.h
@@ -33,6 +33,7 @@ struct c2c_hist_entry {
unsigned long *nodeset;
struct c2c_stats *node_stats;
unsigned int cacheline_idx;
+ unsigned int mem_region;
struct compute_stats cstats;
--
2.43.0
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v12 4/6] perf tools: Show memory region in perf-c2c subcommand
2026-09-23 17:09 ` [PATCH v12 4/6] perf tools: Show memory region in perf-c2c subcommand Thomas Falcon
@ 2026-09-24 0:23 ` Mi, Dapeng
2026-09-24 17:28 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 11+ messages in thread
From: Mi, Dapeng @ 2026-09-24 0:23 UTC (permalink / raw)
To: Thomas Falcon, sashiko-bot
Cc: linux-perf-users, linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
James Clark
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Thanks.
On 9/24/2026 1:09 AM, Thomas Falcon wrote:
> From: Dapeng Mi <dapeng1.mi@linux.intel.com>
>
> Add memory region field to the cacheline list view to help users
> identify the memory region to which the cacheline belongs. The memory
> region field was included with the introduction of support for the
> Off-module Response facility (OMR) [1] in Intel's Diamond Rapids and
> Nova Lake architectures.
>
> An example of the new perf c2c output including the memory region
> field is shown below:
>
> # Index Address Region Node PA cnt Hitm Total LclHitm RmtHitm records Loads
> # ..... .................. ...... .... ...... ....... ....... ....... ....... ....... .......
> #
> 0 0xffffffff84eb0040 N/A 0 1205 23.25% 544 544 0 1677 1677
> 1 0xffffffff84f03a80 N/A 0 1 18.12% 424 424 0 585 585
> [...]
> 19 0xffffffff845bc840 Mem-0 0 13 0.30% 7 7 0 31 31
> 20 0xff3bbba284520a00 N/A 0 10 0.26% 6 6 0 11 11
> 21 0xff3bbbe0bc833500 N/A 0 24 0.26% 6 6 0 30 30
>
> [1]: https://lore.kernel.org/all/20260114011750.350569-1-dapeng1.mi@linux.intel.com/
>
> Assisted-by: Sashiko:gemini-3.1-pro-preview
> Assisted-by: GitHub-Copilot:claude-opus-4-8
> Reviewed-by: Ian Rogers <irogers@google.com>
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> Co-developed-by: Thomas Falcon <thomas.falcon@intel.com>
> Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>
> ---
> v11: perf-c2c: revert to only recording a real memory region for a
> cacheline
> v10: only update mem_region for real cache/memory regions so N/A samples
> don't overwrite a valid region; add #include <stdio.h> for asprintf
> (Sashiko)
> v9: Update perf-c2c to include cache region reporting (Dapeng Mi)
> v8: Update developer tags and commit message with real example
> output (Dapeng Mi)
> v7: fix output_str allocation error handling which introduced
> a memory leak (Sashiko)
> v6: rebased onto 7.3-rc1
> v5: make the cacheline header span and ui_quirks() width
> fixup depend on memory-region availability (Namhyung Kim)
> v4: correctly handle output_str memory allocation failure
> v3: make memory region reporting conditional on feature bit
> ---
> tools/perf/builtin-c2c.c | 114 +++++++++++++++++++++++++++++++++++----
> tools/perf/util/c2c.h | 1 +
> 2 files changed, 104 insertions(+), 11 deletions(-)
>
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 6b64c0d6b24f..a42423ca990d 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -14,6 +14,7 @@
> #include <inttypes.h>
> #include <stdlib.h>
> #include <string.h>
> +#include <stdio.h>
>
> #include <asm/bug.h>
> #include <linux/compiler.h>
> @@ -72,6 +73,7 @@ struct perf_c2c {
>
> bool show_src;
> bool show_all;
> + bool show_mem_region;
> bool use_stdio;
> bool stats_only;
> bool symbol_full;
> @@ -248,6 +250,18 @@ static void c2c_he__set_node(struct c2c_hist_entry *c2c_he,
> }
> }
>
> +static void c2c_he__set_mem_region(struct c2c_hist_entry *c2c_he,
> + unsigned int mem_region)
> +{
> + if (WARN_ONCE(mem_region > PERF_MEM_REGION_MEM7,
> + "WARNING: invalid memory region ID\n"))
> + return;
> +
> + /* Update mem_region only if it really accesses memory */
> + if (mem_region >= PERF_MEM_REGION_MMIO)
> + c2c_he->mem_region = mem_region;
> +}
> +
> static void compute_stats(struct c2c_hist_entry *c2c_he,
> struct c2c_stats *stats,
> u64 weight)
> @@ -306,6 +320,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> struct addr_location al;
> struct mem_info *mi = NULL;
> struct callchain_cursor *cursor;
> + unsigned int mem_region;
> int ret;
>
> addr_location__init(&al);
> @@ -333,6 +348,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> }
>
> c2c_decode_stats(&stats, mi);
> + mem_region = mem_info__data_src(mi)->mem_region;
>
> he = hists__add_entry_ops(&c2c_hists->hists, &c2c_entry_ops,
> &al, NULL, NULL, mi, NULL,
> @@ -349,6 +365,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> c2c_he__set_cpu(c2c_he, sample);
> c2c_he__set_node(c2c_he, sample);
> c2c_he__set_evsel(c2c_he, evsel);
> + c2c_he__set_mem_region(c2c_he, mem_region);
>
> hists__inc_nr_samples(&c2c_hists->hists, he->filtered);
>
> @@ -402,6 +419,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> c2c_he__set_cpu(c2c_he, sample);
> c2c_he__set_node(c2c_he, sample);
> c2c_he__set_evsel(c2c_he, evsel);
> + c2c_he__set_mem_region(c2c_he, mem_region);
>
> hists__inc_nr_samples(&c2c_hists->hists, he->filtered);
> ret = hist_entry__append_callchain(he, sample);
> @@ -540,6 +558,45 @@ dcacheline_node_count(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> return scnprintf(hpp->buf, hpp->size, "%*lu", width, c2c_he->paddr_cnt);
> }
>
> +static int
> +dcacheline_node_mem_region(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> + struct hist_entry *he)
> +{
> + int width = c2c_width(fmt, hpp, he->hists);
> + struct c2c_hist_entry *c2c_he;
> + unsigned int mem_region;
> + char buf[20];
> +
> + c2c_he = container_of(he, struct c2c_hist_entry, he);
> + mem_region = c2c_he->mem_region;
> +
> + switch (mem_region) {
> + case PERF_MEM_REGION_NA:
> + case PERF_MEM_REGION_RSVD:
> + scnprintf(buf, sizeof(buf), "N/A");
> + break;
> + case PERF_MEM_REGION_MMIO:
> + scnprintf(buf, sizeof(buf), "MMIO");
> + break;
> + case PERF_MEM_REGION_MEM0:
> + case PERF_MEM_REGION_MEM1:
> + case PERF_MEM_REGION_MEM2:
> + case PERF_MEM_REGION_MEM3:
> + case PERF_MEM_REGION_MEM4:
> + case PERF_MEM_REGION_MEM5:
> + case PERF_MEM_REGION_MEM6:
> + case PERF_MEM_REGION_MEM7:
> + scnprintf(buf, sizeof(buf), "Mem-%d",
> + mem_region - PERF_MEM_REGION_MEM0);
> + break;
> + default:
> + scnprintf(buf, sizeof(buf), "N/A");
> + break;
> + }
> +
> + return scnprintf(hpp->buf, hpp->size, "%*s", width, buf);
> +}
> +
> static int offset_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> struct hist_entry *he)
> {
> @@ -1360,6 +1417,14 @@ static struct c2c_dimension dim_dcacheline_node = {
> .width = 4,
> };
>
> +static struct c2c_dimension dim_dcacheline_mem_region = {
> + .header = HEADER_LOW("Region"),
> + .name = "dcacheline_mem_region",
> + .cmp = empty_cmp,
> + .entry = dcacheline_node_mem_region,
> + .width = 6,
> +};
> +
> static struct c2c_dimension dim_dcacheline_count = {
> .header = HEADER_LOW("PA cnt"),
> .name = "dcacheline_count",
> @@ -1791,6 +1856,7 @@ static struct c2c_dimension dim_dcacheline_num_empty = {
>
> static struct c2c_dimension *dimensions[] = {
> &dim_dcacheline,
> + &dim_dcacheline_mem_region,
> &dim_dcacheline_node,
> &dim_dcacheline_count,
> &dim_offset,
> @@ -2854,8 +2920,11 @@ static int ui_quirks(void)
> /* Fix the zero line for dcacheline column. */
> buf = fill_line(chk_double_cl ? "Double-Cacheline" : "Cacheline",
> dim_dcacheline.width +
> + (c2c.show_mem_region ?
> + dim_dcacheline_mem_region.width : 0) +
> dim_dcacheline_node.width +
> - dim_dcacheline_count.width + 4);
> + dim_dcacheline_count.width +
> + (c2c.show_mem_region ? 6 : 4));
> if (!buf)
> return -ENOMEM;
>
> @@ -3107,7 +3176,8 @@ static int perf_c2c__report(int argc, const char **argv)
> OPT_END()
> };
> int err = 0;
> - const char *output_str, *sort_str = NULL;
> + const char *sort_str = NULL;
> + char *output_str = NULL;
> struct perf_env *env;
>
> annotation_options__init();
> @@ -3272,9 +3342,16 @@ static int perf_c2c__report(int argc, const char **argv)
> goto out_mem2node;
> }
>
> - if (c2c.display != DISPLAY_SNP_PEER)
> - output_str = "cl_idx,"
> + c2c.show_mem_region = perf_header__has_feat(&session->header,
> + HEADER_MEMORY_RANGES);
> + if (c2c.show_mem_region)
> + dim_dcacheline.header.line[0].span = 3;
> +
> + if (c2c.display != DISPLAY_SNP_PEER) {
> + if (asprintf(&output_str,
> + "cl_idx,"
> "dcacheline,"
> + "%s"
> "dcacheline_node,"
> "dcacheline_count,"
> "percent_costly_snoop,"
> @@ -3286,10 +3363,17 @@ static int perf_c2c__report(int argc, const char **argv)
> "ld_fbhit,ld_l1hit,ld_l2hit,"
> "ld_lclhit,lcl_hitm,"
> "ld_rmthit,rmt_hitm,"
> - "dram_lcl,dram_rmt";
> - else
> - output_str = "cl_idx,"
> + "dram_lcl,dram_rmt",
> + c2c.show_mem_region ?
> + "dcacheline_mem_region," : "") < 0) {
> + err = -ENOMEM;
> + goto out_mem2node;
> + }
> + } else {
> + if (asprintf(&output_str,
> + "cl_idx,"
> "dcacheline,"
> + "%s"
> "dcacheline_node,"
> "dcacheline_count,"
> "percent_costly_snoop,"
> @@ -3301,7 +3385,13 @@ static int perf_c2c__report(int argc, const char **argv)
> "ld_fbhit,ld_l1hit,ld_l2hit,"
> "ld_lclhit,lcl_hitm,"
> "ld_rmthit,rmt_hitm,"
> - "dram_lcl,dram_rmt";
> + "dram_lcl,dram_rmt",
> + c2c.show_mem_region ?
> + "dcacheline_mem_region," : "") < 0) {
> + err = -ENOMEM;
> + goto out_mem2node;
> + }
> + }
>
> if (c2c.display == DISPLAY_TOT_HITM)
> sort_str = "tot_hitm";
> @@ -3315,7 +3405,7 @@ static int perf_c2c__report(int argc, const char **argv)
> err = c2c_hists__reinit(&c2c.hists, output_str, sort_str, perf_session__env(session));
> if (err) {
> pr_err("Failed to reinitialize hists\n");
> - goto out_mem2node;
> + goto out_str;
> }
>
> ui_progress__init(&prog, c2c.hists.hists.nr_entries, "Sorting...");
> @@ -3324,17 +3414,19 @@ static int perf_c2c__report(int argc, const char **argv)
> hists__output_resort_cb(&c2c.hists.hists, &prog, resort_shared_cl_cb);
> err = hists__iterate_cb(&c2c.hists.hists, resort_cl_cb, perf_session__env(session));
> if (err)
> - goto out_mem2node;
> + goto out_str;
>
> ui_progress__finish();
>
> if (ui_quirks()) {
> pr_err("failed to setup UI\n");
> - goto out_mem2node;
> + goto out_str;
> }
>
> perf_c2c_display(session);
>
> +out_str:
> + free(output_str);
> out_mem2node:
> mem2node__exit(&c2c.mem2node);
> out_session:
> diff --git a/tools/perf/util/c2c.h b/tools/perf/util/c2c.h
> index 53f024e25d99..f04e78e1a2e3 100644
> --- a/tools/perf/util/c2c.h
> +++ b/tools/perf/util/c2c.h
> @@ -33,6 +33,7 @@ struct c2c_hist_entry {
> unsigned long *nodeset;
> struct c2c_stats *node_stats;
> unsigned int cacheline_idx;
> + unsigned int mem_region;
>
> struct compute_stats cstats;
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v12 4/6] perf tools: Show memory region in perf-c2c subcommand
2026-09-24 0:23 ` Mi, Dapeng
@ 2026-09-24 17:28 ` Arnaldo Carvalho de Melo
2026-09-24 17:29 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 11+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-09-24 17:28 UTC (permalink / raw)
To: Mi, Dapeng
Cc: Thomas Falcon, sashiko-bot, linux-perf-users, linux-kernel,
Peter Zijlstra, Ingo Molnar, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
James Clark
On Thu, Sep 24, 2026 at 08:23:42AM +0800, Mi, Dapeng wrote:
> Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Is this needed since you're the author of the patch? I'm keeping just
the Signed-off-by,
- Arnaldo
> Thanks.
>
>
> On 9/24/2026 1:09 AM, Thomas Falcon wrote:
> > From: Dapeng Mi <dapeng1.mi@linux.intel.com>
> >
> > Add memory region field to the cacheline list view to help users
> > identify the memory region to which the cacheline belongs. The memory
> > region field was included with the introduction of support for the
> > Off-module Response facility (OMR) [1] in Intel's Diamond Rapids and
> > Nova Lake architectures.
> >
> > An example of the new perf c2c output including the memory region
> > field is shown below:
> >
> > # Index Address Region Node PA cnt Hitm Total LclHitm RmtHitm records Loads
> > # ..... .................. ...... .... ...... ....... ....... ....... ....... ....... .......
> > #
> > 0 0xffffffff84eb0040 N/A 0 1205 23.25% 544 544 0 1677 1677
> > 1 0xffffffff84f03a80 N/A 0 1 18.12% 424 424 0 585 585
> > [...]
> > 19 0xffffffff845bc840 Mem-0 0 13 0.30% 7 7 0 31 31
> > 20 0xff3bbba284520a00 N/A 0 10 0.26% 6 6 0 11 11
> > 21 0xff3bbbe0bc833500 N/A 0 24 0.26% 6 6 0 30 30
> >
> > [1]: https://lore.kernel.org/all/20260114011750.350569-1-dapeng1.mi@linux.intel.com/
> >
> > Assisted-by: Sashiko:gemini-3.1-pro-preview
> > Assisted-by: GitHub-Copilot:claude-opus-4-8
> > Reviewed-by: Ian Rogers <irogers@google.com>
> > Reviewed-by: Namhyung Kim <namhyung@kernel.org>
> > Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> > Co-developed-by: Thomas Falcon <thomas.falcon@intel.com>
> > Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>
> > ---
> > v11: perf-c2c: revert to only recording a real memory region for a
> > cacheline
> > v10: only update mem_region for real cache/memory regions so N/A samples
> > don't overwrite a valid region; add #include <stdio.h> for asprintf
> > (Sashiko)
> > v9: Update perf-c2c to include cache region reporting (Dapeng Mi)
> > v8: Update developer tags and commit message with real example
> > output (Dapeng Mi)
> > v7: fix output_str allocation error handling which introduced
> > a memory leak (Sashiko)
> > v6: rebased onto 7.3-rc1
> > v5: make the cacheline header span and ui_quirks() width
> > fixup depend on memory-region availability (Namhyung Kim)
> > v4: correctly handle output_str memory allocation failure
> > v3: make memory region reporting conditional on feature bit
> > ---
> > tools/perf/builtin-c2c.c | 114 +++++++++++++++++++++++++++++++++++----
> > tools/perf/util/c2c.h | 1 +
> > 2 files changed, 104 insertions(+), 11 deletions(-)
> >
> > diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> > index 6b64c0d6b24f..a42423ca990d 100644
> > --- a/tools/perf/builtin-c2c.c
> > +++ b/tools/perf/builtin-c2c.c
> > @@ -14,6 +14,7 @@
> > #include <inttypes.h>
> > #include <stdlib.h>
> > #include <string.h>
> > +#include <stdio.h>
> >
> > #include <asm/bug.h>
> > #include <linux/compiler.h>
> > @@ -72,6 +73,7 @@ struct perf_c2c {
> >
> > bool show_src;
> > bool show_all;
> > + bool show_mem_region;
> > bool use_stdio;
> > bool stats_only;
> > bool symbol_full;
> > @@ -248,6 +250,18 @@ static void c2c_he__set_node(struct c2c_hist_entry *c2c_he,
> > }
> > }
> >
> > +static void c2c_he__set_mem_region(struct c2c_hist_entry *c2c_he,
> > + unsigned int mem_region)
> > +{
> > + if (WARN_ONCE(mem_region > PERF_MEM_REGION_MEM7,
> > + "WARNING: invalid memory region ID\n"))
> > + return;
> > +
> > + /* Update mem_region only if it really accesses memory */
> > + if (mem_region >= PERF_MEM_REGION_MMIO)
> > + c2c_he->mem_region = mem_region;
> > +}
> > +
> > static void compute_stats(struct c2c_hist_entry *c2c_he,
> > struct c2c_stats *stats,
> > u64 weight)
> > @@ -306,6 +320,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> > struct addr_location al;
> > struct mem_info *mi = NULL;
> > struct callchain_cursor *cursor;
> > + unsigned int mem_region;
> > int ret;
> >
> > addr_location__init(&al);
> > @@ -333,6 +348,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> > }
> >
> > c2c_decode_stats(&stats, mi);
> > + mem_region = mem_info__data_src(mi)->mem_region;
> >
> > he = hists__add_entry_ops(&c2c_hists->hists, &c2c_entry_ops,
> > &al, NULL, NULL, mi, NULL,
> > @@ -349,6 +365,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> > c2c_he__set_cpu(c2c_he, sample);
> > c2c_he__set_node(c2c_he, sample);
> > c2c_he__set_evsel(c2c_he, evsel);
> > + c2c_he__set_mem_region(c2c_he, mem_region);
> >
> > hists__inc_nr_samples(&c2c_hists->hists, he->filtered);
> >
> > @@ -402,6 +419,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> > c2c_he__set_cpu(c2c_he, sample);
> > c2c_he__set_node(c2c_he, sample);
> > c2c_he__set_evsel(c2c_he, evsel);
> > + c2c_he__set_mem_region(c2c_he, mem_region);
> >
> > hists__inc_nr_samples(&c2c_hists->hists, he->filtered);
> > ret = hist_entry__append_callchain(he, sample);
> > @@ -540,6 +558,45 @@ dcacheline_node_count(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> > return scnprintf(hpp->buf, hpp->size, "%*lu", width, c2c_he->paddr_cnt);
> > }
> >
> > +static int
> > +dcacheline_node_mem_region(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> > + struct hist_entry *he)
> > +{
> > + int width = c2c_width(fmt, hpp, he->hists);
> > + struct c2c_hist_entry *c2c_he;
> > + unsigned int mem_region;
> > + char buf[20];
> > +
> > + c2c_he = container_of(he, struct c2c_hist_entry, he);
> > + mem_region = c2c_he->mem_region;
> > +
> > + switch (mem_region) {
> > + case PERF_MEM_REGION_NA:
> > + case PERF_MEM_REGION_RSVD:
> > + scnprintf(buf, sizeof(buf), "N/A");
> > + break;
> > + case PERF_MEM_REGION_MMIO:
> > + scnprintf(buf, sizeof(buf), "MMIO");
> > + break;
> > + case PERF_MEM_REGION_MEM0:
> > + case PERF_MEM_REGION_MEM1:
> > + case PERF_MEM_REGION_MEM2:
> > + case PERF_MEM_REGION_MEM3:
> > + case PERF_MEM_REGION_MEM4:
> > + case PERF_MEM_REGION_MEM5:
> > + case PERF_MEM_REGION_MEM6:
> > + case PERF_MEM_REGION_MEM7:
> > + scnprintf(buf, sizeof(buf), "Mem-%d",
> > + mem_region - PERF_MEM_REGION_MEM0);
> > + break;
> > + default:
> > + scnprintf(buf, sizeof(buf), "N/A");
> > + break;
> > + }
> > +
> > + return scnprintf(hpp->buf, hpp->size, "%*s", width, buf);
> > +}
> > +
> > static int offset_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> > struct hist_entry *he)
> > {
> > @@ -1360,6 +1417,14 @@ static struct c2c_dimension dim_dcacheline_node = {
> > .width = 4,
> > };
> >
> > +static struct c2c_dimension dim_dcacheline_mem_region = {
> > + .header = HEADER_LOW("Region"),
> > + .name = "dcacheline_mem_region",
> > + .cmp = empty_cmp,
> > + .entry = dcacheline_node_mem_region,
> > + .width = 6,
> > +};
> > +
> > static struct c2c_dimension dim_dcacheline_count = {
> > .header = HEADER_LOW("PA cnt"),
> > .name = "dcacheline_count",
> > @@ -1791,6 +1856,7 @@ static struct c2c_dimension dim_dcacheline_num_empty = {
> >
> > static struct c2c_dimension *dimensions[] = {
> > &dim_dcacheline,
> > + &dim_dcacheline_mem_region,
> > &dim_dcacheline_node,
> > &dim_dcacheline_count,
> > &dim_offset,
> > @@ -2854,8 +2920,11 @@ static int ui_quirks(void)
> > /* Fix the zero line for dcacheline column. */
> > buf = fill_line(chk_double_cl ? "Double-Cacheline" : "Cacheline",
> > dim_dcacheline.width +
> > + (c2c.show_mem_region ?
> > + dim_dcacheline_mem_region.width : 0) +
> > dim_dcacheline_node.width +
> > - dim_dcacheline_count.width + 4);
> > + dim_dcacheline_count.width +
> > + (c2c.show_mem_region ? 6 : 4));
> > if (!buf)
> > return -ENOMEM;
> >
> > @@ -3107,7 +3176,8 @@ static int perf_c2c__report(int argc, const char **argv)
> > OPT_END()
> > };
> > int err = 0;
> > - const char *output_str, *sort_str = NULL;
> > + const char *sort_str = NULL;
> > + char *output_str = NULL;
> > struct perf_env *env;
> >
> > annotation_options__init();
> > @@ -3272,9 +3342,16 @@ static int perf_c2c__report(int argc, const char **argv)
> > goto out_mem2node;
> > }
> >
> > - if (c2c.display != DISPLAY_SNP_PEER)
> > - output_str = "cl_idx,"
> > + c2c.show_mem_region = perf_header__has_feat(&session->header,
> > + HEADER_MEMORY_RANGES);
> > + if (c2c.show_mem_region)
> > + dim_dcacheline.header.line[0].span = 3;
> > +
> > + if (c2c.display != DISPLAY_SNP_PEER) {
> > + if (asprintf(&output_str,
> > + "cl_idx,"
> > "dcacheline,"
> > + "%s"
> > "dcacheline_node,"
> > "dcacheline_count,"
> > "percent_costly_snoop,"
> > @@ -3286,10 +3363,17 @@ static int perf_c2c__report(int argc, const char **argv)
> > "ld_fbhit,ld_l1hit,ld_l2hit,"
> > "ld_lclhit,lcl_hitm,"
> > "ld_rmthit,rmt_hitm,"
> > - "dram_lcl,dram_rmt";
> > - else
> > - output_str = "cl_idx,"
> > + "dram_lcl,dram_rmt",
> > + c2c.show_mem_region ?
> > + "dcacheline_mem_region," : "") < 0) {
> > + err = -ENOMEM;
> > + goto out_mem2node;
> > + }
> > + } else {
> > + if (asprintf(&output_str,
> > + "cl_idx,"
> > "dcacheline,"
> > + "%s"
> > "dcacheline_node,"
> > "dcacheline_count,"
> > "percent_costly_snoop,"
> > @@ -3301,7 +3385,13 @@ static int perf_c2c__report(int argc, const char **argv)
> > "ld_fbhit,ld_l1hit,ld_l2hit,"
> > "ld_lclhit,lcl_hitm,"
> > "ld_rmthit,rmt_hitm,"
> > - "dram_lcl,dram_rmt";
> > + "dram_lcl,dram_rmt",
> > + c2c.show_mem_region ?
> > + "dcacheline_mem_region," : "") < 0) {
> > + err = -ENOMEM;
> > + goto out_mem2node;
> > + }
> > + }
> >
> > if (c2c.display == DISPLAY_TOT_HITM)
> > sort_str = "tot_hitm";
> > @@ -3315,7 +3405,7 @@ static int perf_c2c__report(int argc, const char **argv)
> > err = c2c_hists__reinit(&c2c.hists, output_str, sort_str, perf_session__env(session));
> > if (err) {
> > pr_err("Failed to reinitialize hists\n");
> > - goto out_mem2node;
> > + goto out_str;
> > }
> >
> > ui_progress__init(&prog, c2c.hists.hists.nr_entries, "Sorting...");
> > @@ -3324,17 +3414,19 @@ static int perf_c2c__report(int argc, const char **argv)
> > hists__output_resort_cb(&c2c.hists.hists, &prog, resort_shared_cl_cb);
> > err = hists__iterate_cb(&c2c.hists.hists, resort_cl_cb, perf_session__env(session));
> > if (err)
> > - goto out_mem2node;
> > + goto out_str;
> >
> > ui_progress__finish();
> >
> > if (ui_quirks()) {
> > pr_err("failed to setup UI\n");
> > - goto out_mem2node;
> > + goto out_str;
> > }
> >
> > perf_c2c_display(session);
> >
> > +out_str:
> > + free(output_str);
> > out_mem2node:
> > mem2node__exit(&c2c.mem2node);
> > out_session:
> > diff --git a/tools/perf/util/c2c.h b/tools/perf/util/c2c.h
> > index 53f024e25d99..f04e78e1a2e3 100644
> > --- a/tools/perf/util/c2c.h
> > +++ b/tools/perf/util/c2c.h
> > @@ -33,6 +33,7 @@ struct c2c_hist_entry {
> > unsigned long *nodeset;
> > struct c2c_stats *node_stats;
> > unsigned int cacheline_idx;
> > + unsigned int mem_region;
> >
> > struct compute_stats cstats;
> >
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v12 4/6] perf tools: Show memory region in perf-c2c subcommand
2026-09-24 17:28 ` Arnaldo Carvalho de Melo
@ 2026-09-24 17:29 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 11+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-09-24 17:29 UTC (permalink / raw)
To: Mi, Dapeng
Cc: Thomas Falcon, sashiko-bot, linux-perf-users, linux-kernel,
Peter Zijlstra, Ingo Molnar, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
James Clark
On Thu, Sep 24, 2026 at 07:28:13PM +0200, Arnaldo Carvalho de Melo wrote:
> On Thu, Sep 24, 2026 at 08:23:42AM +0800, Mi, Dapeng wrote:
> > Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
>
> Is this needed since you're the author of the patch? I'm keeping just
> the Signed-off-by,
I'll keep it since I saw a Co-developed-by tag, meaning maybe there were
changes after you initially created this patch...
- Arnaldo
> >
> > On 9/24/2026 1:09 AM, Thomas Falcon wrote:
> > > From: Dapeng Mi <dapeng1.mi@linux.intel.com>
> > >
> > > Add memory region field to the cacheline list view to help users
> > > identify the memory region to which the cacheline belongs. The memory
> > > region field was included with the introduction of support for the
> > > Off-module Response facility (OMR) [1] in Intel's Diamond Rapids and
> > > Nova Lake architectures.
> > >
> > > An example of the new perf c2c output including the memory region
> > > field is shown below:
> > >
> > > # Index Address Region Node PA cnt Hitm Total LclHitm RmtHitm records Loads
> > > # ..... .................. ...... .... ...... ....... ....... ....... ....... ....... .......
> > > #
> > > 0 0xffffffff84eb0040 N/A 0 1205 23.25% 544 544 0 1677 1677
> > > 1 0xffffffff84f03a80 N/A 0 1 18.12% 424 424 0 585 585
> > > [...]
> > > 19 0xffffffff845bc840 Mem-0 0 13 0.30% 7 7 0 31 31
> > > 20 0xff3bbba284520a00 N/A 0 10 0.26% 6 6 0 11 11
> > > 21 0xff3bbbe0bc833500 N/A 0 24 0.26% 6 6 0 30 30
> > >
> > > [1]: https://lore.kernel.org/all/20260114011750.350569-1-dapeng1.mi@linux.intel.com/
> > >
> > > Assisted-by: Sashiko:gemini-3.1-pro-preview
> > > Assisted-by: GitHub-Copilot:claude-opus-4-8
> > > Reviewed-by: Ian Rogers <irogers@google.com>
> > > Reviewed-by: Namhyung Kim <namhyung@kernel.org>
> > > Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> > > Co-developed-by: Thomas Falcon <thomas.falcon@intel.com>
> > > Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>
> > > ---
> > > v11: perf-c2c: revert to only recording a real memory region for a
> > > cacheline
> > > v10: only update mem_region for real cache/memory regions so N/A samples
> > > don't overwrite a valid region; add #include <stdio.h> for asprintf
> > > (Sashiko)
> > > v9: Update perf-c2c to include cache region reporting (Dapeng Mi)
> > > v8: Update developer tags and commit message with real example
> > > output (Dapeng Mi)
> > > v7: fix output_str allocation error handling which introduced
> > > a memory leak (Sashiko)
> > > v6: rebased onto 7.3-rc1
> > > v5: make the cacheline header span and ui_quirks() width
> > > fixup depend on memory-region availability (Namhyung Kim)
> > > v4: correctly handle output_str memory allocation failure
> > > v3: make memory region reporting conditional on feature bit
> > > ---
> > > tools/perf/builtin-c2c.c | 114 +++++++++++++++++++++++++++++++++++----
> > > tools/perf/util/c2c.h | 1 +
> > > 2 files changed, 104 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> > > index 6b64c0d6b24f..a42423ca990d 100644
> > > --- a/tools/perf/builtin-c2c.c
> > > +++ b/tools/perf/builtin-c2c.c
> > > @@ -14,6 +14,7 @@
> > > #include <inttypes.h>
> > > #include <stdlib.h>
> > > #include <string.h>
> > > +#include <stdio.h>
> > >
> > > #include <asm/bug.h>
> > > #include <linux/compiler.h>
> > > @@ -72,6 +73,7 @@ struct perf_c2c {
> > >
> > > bool show_src;
> > > bool show_all;
> > > + bool show_mem_region;
> > > bool use_stdio;
> > > bool stats_only;
> > > bool symbol_full;
> > > @@ -248,6 +250,18 @@ static void c2c_he__set_node(struct c2c_hist_entry *c2c_he,
> > > }
> > > }
> > >
> > > +static void c2c_he__set_mem_region(struct c2c_hist_entry *c2c_he,
> > > + unsigned int mem_region)
> > > +{
> > > + if (WARN_ONCE(mem_region > PERF_MEM_REGION_MEM7,
> > > + "WARNING: invalid memory region ID\n"))
> > > + return;
> > > +
> > > + /* Update mem_region only if it really accesses memory */
> > > + if (mem_region >= PERF_MEM_REGION_MMIO)
> > > + c2c_he->mem_region = mem_region;
> > > +}
> > > +
> > > static void compute_stats(struct c2c_hist_entry *c2c_he,
> > > struct c2c_stats *stats,
> > > u64 weight)
> > > @@ -306,6 +320,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> > > struct addr_location al;
> > > struct mem_info *mi = NULL;
> > > struct callchain_cursor *cursor;
> > > + unsigned int mem_region;
> > > int ret;
> > >
> > > addr_location__init(&al);
> > > @@ -333,6 +348,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> > > }
> > >
> > > c2c_decode_stats(&stats, mi);
> > > + mem_region = mem_info__data_src(mi)->mem_region;
> > >
> > > he = hists__add_entry_ops(&c2c_hists->hists, &c2c_entry_ops,
> > > &al, NULL, NULL, mi, NULL,
> > > @@ -349,6 +365,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> > > c2c_he__set_cpu(c2c_he, sample);
> > > c2c_he__set_node(c2c_he, sample);
> > > c2c_he__set_evsel(c2c_he, evsel);
> > > + c2c_he__set_mem_region(c2c_he, mem_region);
> > >
> > > hists__inc_nr_samples(&c2c_hists->hists, he->filtered);
> > >
> > > @@ -402,6 +419,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
> > > c2c_he__set_cpu(c2c_he, sample);
> > > c2c_he__set_node(c2c_he, sample);
> > > c2c_he__set_evsel(c2c_he, evsel);
> > > + c2c_he__set_mem_region(c2c_he, mem_region);
> > >
> > > hists__inc_nr_samples(&c2c_hists->hists, he->filtered);
> > > ret = hist_entry__append_callchain(he, sample);
> > > @@ -540,6 +558,45 @@ dcacheline_node_count(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> > > return scnprintf(hpp->buf, hpp->size, "%*lu", width, c2c_he->paddr_cnt);
> > > }
> > >
> > > +static int
> > > +dcacheline_node_mem_region(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> > > + struct hist_entry *he)
> > > +{
> > > + int width = c2c_width(fmt, hpp, he->hists);
> > > + struct c2c_hist_entry *c2c_he;
> > > + unsigned int mem_region;
> > > + char buf[20];
> > > +
> > > + c2c_he = container_of(he, struct c2c_hist_entry, he);
> > > + mem_region = c2c_he->mem_region;
> > > +
> > > + switch (mem_region) {
> > > + case PERF_MEM_REGION_NA:
> > > + case PERF_MEM_REGION_RSVD:
> > > + scnprintf(buf, sizeof(buf), "N/A");
> > > + break;
> > > + case PERF_MEM_REGION_MMIO:
> > > + scnprintf(buf, sizeof(buf), "MMIO");
> > > + break;
> > > + case PERF_MEM_REGION_MEM0:
> > > + case PERF_MEM_REGION_MEM1:
> > > + case PERF_MEM_REGION_MEM2:
> > > + case PERF_MEM_REGION_MEM3:
> > > + case PERF_MEM_REGION_MEM4:
> > > + case PERF_MEM_REGION_MEM5:
> > > + case PERF_MEM_REGION_MEM6:
> > > + case PERF_MEM_REGION_MEM7:
> > > + scnprintf(buf, sizeof(buf), "Mem-%d",
> > > + mem_region - PERF_MEM_REGION_MEM0);
> > > + break;
> > > + default:
> > > + scnprintf(buf, sizeof(buf), "N/A");
> > > + break;
> > > + }
> > > +
> > > + return scnprintf(hpp->buf, hpp->size, "%*s", width, buf);
> > > +}
> > > +
> > > static int offset_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> > > struct hist_entry *he)
> > > {
> > > @@ -1360,6 +1417,14 @@ static struct c2c_dimension dim_dcacheline_node = {
> > > .width = 4,
> > > };
> > >
> > > +static struct c2c_dimension dim_dcacheline_mem_region = {
> > > + .header = HEADER_LOW("Region"),
> > > + .name = "dcacheline_mem_region",
> > > + .cmp = empty_cmp,
> > > + .entry = dcacheline_node_mem_region,
> > > + .width = 6,
> > > +};
> > > +
> > > static struct c2c_dimension dim_dcacheline_count = {
> > > .header = HEADER_LOW("PA cnt"),
> > > .name = "dcacheline_count",
> > > @@ -1791,6 +1856,7 @@ static struct c2c_dimension dim_dcacheline_num_empty = {
> > >
> > > static struct c2c_dimension *dimensions[] = {
> > > &dim_dcacheline,
> > > + &dim_dcacheline_mem_region,
> > > &dim_dcacheline_node,
> > > &dim_dcacheline_count,
> > > &dim_offset,
> > > @@ -2854,8 +2920,11 @@ static int ui_quirks(void)
> > > /* Fix the zero line for dcacheline column. */
> > > buf = fill_line(chk_double_cl ? "Double-Cacheline" : "Cacheline",
> > > dim_dcacheline.width +
> > > + (c2c.show_mem_region ?
> > > + dim_dcacheline_mem_region.width : 0) +
> > > dim_dcacheline_node.width +
> > > - dim_dcacheline_count.width + 4);
> > > + dim_dcacheline_count.width +
> > > + (c2c.show_mem_region ? 6 : 4));
> > > if (!buf)
> > > return -ENOMEM;
> > >
> > > @@ -3107,7 +3176,8 @@ static int perf_c2c__report(int argc, const char **argv)
> > > OPT_END()
> > > };
> > > int err = 0;
> > > - const char *output_str, *sort_str = NULL;
> > > + const char *sort_str = NULL;
> > > + char *output_str = NULL;
> > > struct perf_env *env;
> > >
> > > annotation_options__init();
> > > @@ -3272,9 +3342,16 @@ static int perf_c2c__report(int argc, const char **argv)
> > > goto out_mem2node;
> > > }
> > >
> > > - if (c2c.display != DISPLAY_SNP_PEER)
> > > - output_str = "cl_idx,"
> > > + c2c.show_mem_region = perf_header__has_feat(&session->header,
> > > + HEADER_MEMORY_RANGES);
> > > + if (c2c.show_mem_region)
> > > + dim_dcacheline.header.line[0].span = 3;
> > > +
> > > + if (c2c.display != DISPLAY_SNP_PEER) {
> > > + if (asprintf(&output_str,
> > > + "cl_idx,"
> > > "dcacheline,"
> > > + "%s"
> > > "dcacheline_node,"
> > > "dcacheline_count,"
> > > "percent_costly_snoop,"
> > > @@ -3286,10 +3363,17 @@ static int perf_c2c__report(int argc, const char **argv)
> > > "ld_fbhit,ld_l1hit,ld_l2hit,"
> > > "ld_lclhit,lcl_hitm,"
> > > "ld_rmthit,rmt_hitm,"
> > > - "dram_lcl,dram_rmt";
> > > - else
> > > - output_str = "cl_idx,"
> > > + "dram_lcl,dram_rmt",
> > > + c2c.show_mem_region ?
> > > + "dcacheline_mem_region," : "") < 0) {
> > > + err = -ENOMEM;
> > > + goto out_mem2node;
> > > + }
> > > + } else {
> > > + if (asprintf(&output_str,
> > > + "cl_idx,"
> > > "dcacheline,"
> > > + "%s"
> > > "dcacheline_node,"
> > > "dcacheline_count,"
> > > "percent_costly_snoop,"
> > > @@ -3301,7 +3385,13 @@ static int perf_c2c__report(int argc, const char **argv)
> > > "ld_fbhit,ld_l1hit,ld_l2hit,"
> > > "ld_lclhit,lcl_hitm,"
> > > "ld_rmthit,rmt_hitm,"
> > > - "dram_lcl,dram_rmt";
> > > + "dram_lcl,dram_rmt",
> > > + c2c.show_mem_region ?
> > > + "dcacheline_mem_region," : "") < 0) {
> > > + err = -ENOMEM;
> > > + goto out_mem2node;
> > > + }
> > > + }
> > >
> > > if (c2c.display == DISPLAY_TOT_HITM)
> > > sort_str = "tot_hitm";
> > > @@ -3315,7 +3405,7 @@ static int perf_c2c__report(int argc, const char **argv)
> > > err = c2c_hists__reinit(&c2c.hists, output_str, sort_str, perf_session__env(session));
> > > if (err) {
> > > pr_err("Failed to reinitialize hists\n");
> > > - goto out_mem2node;
> > > + goto out_str;
> > > }
> > >
> > > ui_progress__init(&prog, c2c.hists.hists.nr_entries, "Sorting...");
> > > @@ -3324,17 +3414,19 @@ static int perf_c2c__report(int argc, const char **argv)
> > > hists__output_resort_cb(&c2c.hists.hists, &prog, resort_shared_cl_cb);
> > > err = hists__iterate_cb(&c2c.hists.hists, resort_cl_cb, perf_session__env(session));
> > > if (err)
> > > - goto out_mem2node;
> > > + goto out_str;
> > >
> > > ui_progress__finish();
> > >
> > > if (ui_quirks()) {
> > > pr_err("failed to setup UI\n");
> > > - goto out_mem2node;
> > > + goto out_str;
> > > }
> > >
> > > perf_c2c_display(session);
> > >
> > > +out_str:
> > > + free(output_str);
> > > out_mem2node:
> > > mem2node__exit(&c2c.mem2node);
> > > out_session:
> > > diff --git a/tools/perf/util/c2c.h b/tools/perf/util/c2c.h
> > > index 53f024e25d99..f04e78e1a2e3 100644
> > > --- a/tools/perf/util/c2c.h
> > > +++ b/tools/perf/util/c2c.h
> > > @@ -33,6 +33,7 @@ struct c2c_hist_entry {
> > > unsigned long *nodeset;
> > > struct c2c_stats *node_stats;
> > > unsigned int cacheline_idx;
> > > + unsigned int mem_region;
> > >
> > > struct compute_stats cstats;
> > >
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v12 5/6] perf tools: Show memory region in perf-script subcommand
2026-09-23 17:08 ` [PATCH v12 0/6] perf: Add support for memory region/range reporting Thomas Falcon
` (3 preceding siblings ...)
2026-09-23 17:09 ` [PATCH v12 4/6] perf tools: Show memory region in perf-c2c subcommand Thomas Falcon
@ 2026-09-23 17:09 ` Thomas Falcon
2026-09-23 17:09 ` [PATCH v12 6/6] perf c2c: print memory region data with stdio output Thomas Falcon
2026-09-24 17:35 ` [PATCH v12 0/6] perf: Add support for memory region/range reporting Arnaldo Carvalho de Melo
6 siblings, 0 replies; 11+ messages in thread
From: Thomas Falcon @ 2026-09-23 17:09 UTC (permalink / raw)
To: sashiko-bot
Cc: linux-perf-users, linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
James Clark, Dapeng Mi
From: Dapeng Mi <dapeng1.mi@linux.intel.com>
Show the memory region in perf-script subcommand. Memory region is found
in the mem_region field of the memory information data source. This
field was included with the introduction of support for the Off-module
Response facility (OMR) [1] in Intel's Diamond Rapids and Nova Lake
Architectures.
An example of perf-script output with the new memory region field is shown
below:
thread 5/0 ... |OP LOAD|LVL L3 hit|SNP HitM|TLB L1 or L2 hit|LCK No|BLK N/A|Region Local-shared-cache ffffffff9f002aba
thread 2/0 ... |OP LOAD|LVL L3 hit|SNP None|TLB L1 or L2 hit|LCK No|BLK N/A|Region Local-shared-cache ffffffff9dc54c95
thread 8/0 ... |OP LOAD|LVL L3 hit|SNP HitM|TLB L1 or L2 hit|LCK No|BLK N/A|Region Other-non-shared-cache ffffffff9dc54db3
thread 0/0 ... |OP LOAD|LVL LFB/MAB hit|SNP None|TLB L1 or L2 hit|LCK No|BLK Addr|Region N/A ffffffff9dc54db3
thread 2/0 ... |OP LOAD|LVL L0 hit|SNP None|TLB L1 or L2 hit|LCK Yes|BLK N/A|Region N/A ffffffff9f002a8c
thread 0/0 ... |OP LOAD|LVL L3 hit|SNP HitM or Fwd|TLB L1 or L2 hit|LCK No|BLK N/A|Region Local-non-shared-cache ffffffff9f002aba
thread 0/0 ... |OP LOAD|LVL L3 hit|SNP None|TLB L1 or L2 hit|LCK No|BLK N/A|Region Local-shared-cache ffffffff9dc54ca7
thread 30/0 ... |OP LOAD|LVL LFB/MAB hit|SNP None|TLB L1 or L2 hit|LCK Yes|BLK N/A|Region N/A ffffffff9dcc1ff2
thread 30/0 ... |OP LOAD|LVL RAM hit|SNP None|TLB L1 or L2 hit|LCK No|BLK N/A|Region Mem-0 ffffffff9dc54c95
thread 19/0 ... |OP LOAD|LVL LFB/MAB hit|SNP None|TLB L1 or L2 hit|LCK No|BLK N/A|Region N/A ffffffff9f002cbb
thread 19/0 ... |OP LOAD|LVL L3 hit|SNP HitM or Fwd|TLB L1 or L2 hit|LCK No|BLK N/A|Region Local-non-shared-cache ffffffff9f002aba
[1]: https://lore.kernel.org/all/20260114011750.350569-1-dapeng1.mi@linux.intel.com/
Assisted-by: Sashiko:gemini-3.1-pro-preview
Assisted-by: GitHub-Copilot:claude-opus-4-8
Reviewed-by: Ian Rogers <irogers@google.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Co-developed-by: Thomas Falcon <thomas.falcon@intel.com>
Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>
---
v10: use a forward declaration of struct perf_session in mem-events.h
instead of including session.h; include session.h directly where
needed (Sashiko)
v8: Update developer tags and commit message with real example output
v4: Drop the global show-region flag; pass perf_session to
perf_script__meminfo_scnprintf() and gate the Region field
on the feature bit, with a pipe-mode fallback
v3: make memory region reporting conditional on feature bit
---
tools/perf/builtin-script.c | 13 +--
tools/perf/util/mem-events.c | 87 ++++++++++++++++++-
tools/perf/util/mem-events.h | 4 +-
.../scripting-engines/trace-event-python.c | 6 +-
4 files changed, 100 insertions(+), 10 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 0174489d1c0f..565ee8d55f80 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2153,11 +2153,12 @@ static int evlist__max_name_len(struct evlist *evlist)
return max;
}
-static int data_src__fprintf(u64 data_src, FILE *fp)
+static int data_src__fprintf(struct perf_session *session,
+ u64 data_src, FILE *fp)
{
struct mem_info *mi = mem_info__new();
- char decode[100];
- char out[100];
+ char decode[200];
+ char out[200];
static int maxlen;
int len;
@@ -2165,10 +2166,10 @@ static int data_src__fprintf(u64 data_src, FILE *fp)
return -ENOMEM;
mem_info__data_src(mi)->val = data_src;
- perf_script__meminfo_scnprintf(decode, 100, mi);
+ perf_script__meminfo_scnprintf(decode, 200, mi, session);
mem_info__put(mi);
- len = scnprintf(out, 100, "%16" PRIx64 " %s", data_src, decode);
+ len = scnprintf(out, 200, "%16" PRIx64 " %s", data_src, decode);
if (maxlen < len)
maxlen = len;
@@ -2562,7 +2563,7 @@ static void process_event(struct perf_script *script,
perf_sample__fprintf_addr(sample, thread, evsel, fp);
if (PRINT_FIELD(DATA_SRC))
- data_src__fprintf(sample->data_src, fp);
+ data_src__fprintf(evsel__session(evsel), sample->data_src, fp);
if (PRINT_FIELD(WEIGHT))
fprintf(fp, "%16" PRIu64, sample->weight);
diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index 4fd48fd20055..0cdcb47647bd 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -17,6 +17,7 @@
#include "symbol.h"
#include "pmu.h"
#include "pmus.h"
+#include "session.h"
unsigned int perf_mem_events__loads_ldlat = 30;
@@ -604,8 +605,77 @@ int perf_mem__blk_scnprintf(char *out, size_t sz, const struct mem_info *mem_inf
return l;
}
-int perf_script__meminfo_scnprintf(char *out, size_t sz, const struct mem_info *mem_info)
+static int perf_mem__region_scnprintf(char *out, size_t sz, const struct mem_info *mem_info)
{
+ size_t l = 0;
+ u64 mem = PERF_MEM_REGION_NA;
+
+ sz -= 1; /* -1 for null termination */
+ out[0] = '\0';
+
+ if (mem_info)
+ mem = mem_info__const_data_src(mem_info)->mem_region;
+
+ switch (mem) {
+ case PERF_MEM_REGION_NA:
+ case PERF_MEM_REGION_RSVD:
+ l += scnprintf(out + l, sz - l, "N/A");
+ break;
+ case PERF_MEM_REGION_L_SHARE:
+ l += scnprintf(out + l, sz - l, "Local-shared-cache");
+ break;
+ case PERF_MEM_REGION_L_NON_SHARE:
+ l += scnprintf(out + l, sz - l, "Local-non-shared-cache");
+ break;
+ case PERF_MEM_REGION_O_IO:
+ l += scnprintf(out + l, sz - l, "Other-IO");
+ break;
+ case PERF_MEM_REGION_O_SHARE:
+ l += scnprintf(out + l, sz - l, "Other-shared-cache");
+ break;
+ case PERF_MEM_REGION_O_NON_SHARE:
+ l += scnprintf(out + l, sz - l, "Other-non-shared-cache");
+ break;
+ case PERF_MEM_REGION_MMIO:
+ l += scnprintf(out + l, sz - l, "MMIO");
+ break;
+ case PERF_MEM_REGION_MEM0:
+ l += scnprintf(out + l, sz - l, "Mem-0");
+ break;
+ case PERF_MEM_REGION_MEM1:
+ l += scnprintf(out + l, sz - l, "Mem-1");
+ break;
+ case PERF_MEM_REGION_MEM2:
+ l += scnprintf(out + l, sz - l, "Mem-2");
+ break;
+ case PERF_MEM_REGION_MEM3:
+ l += scnprintf(out + l, sz - l, "Mem-3");
+ break;
+ case PERF_MEM_REGION_MEM4:
+ l += scnprintf(out + l, sz - l, "Mem-4");
+ break;
+ case PERF_MEM_REGION_MEM5:
+ l += scnprintf(out + l, sz - l, "Mem-5");
+ break;
+ case PERF_MEM_REGION_MEM6:
+ l += scnprintf(out + l, sz - l, "Mem-6");
+ break;
+ case PERF_MEM_REGION_MEM7:
+ l += scnprintf(out + l, sz - l, "Mem-7");
+ break;
+ default:
+ l += scnprintf(out + l, sz - l, "N/A");
+ break;
+ }
+
+ return l;
+}
+
+int perf_script__meminfo_scnprintf(char *out, size_t sz,
+ const struct mem_info *mem_info,
+ struct perf_session *session)
+{
+ struct perf_env *env;
int i = 0;
i += scnprintf(out, sz, "|OP ");
@@ -620,6 +690,21 @@ int perf_script__meminfo_scnprintf(char *out, size_t sz, const struct mem_info *
i += perf_mem__lck_scnprintf(out + i, sz - i, mem_info);
i += scnprintf(out + i, sz - i, "|BLK ");
i += perf_mem__blk_scnprintf(out + i, sz - i, mem_info);
+ if (session) {
+ /*
+ * In case the feature bits are not available, as in
+ * pipe mode, fallback to checking for the existence of
+ * memory ranges
+ */
+ env = perf_session__env(session);
+ if ((env && session->data->is_pipe && env->nr_memory_ranges) ||
+ perf_header__has_feat(&session->header,
+ HEADER_MEMORY_RANGES)) {
+ i += scnprintf(out + i, sz - i, "|Region ");
+ i += perf_mem__region_scnprintf(out + i, sz - i,
+ mem_info);
+ }
+ }
return i;
}
diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
index daa22748f9fe..38b14c03392c 100644
--- a/tools/perf/util/mem-events.h
+++ b/tools/perf/util/mem-events.h
@@ -24,6 +24,7 @@ enum {
struct evsel;
struct mem_info;
struct perf_pmu;
+struct perf_session;
extern unsigned int perf_mem_events__loads_ldlat;
extern struct perf_mem_event perf_mem_events[PERF_MEM_EVENTS__MAX];
@@ -47,7 +48,8 @@ int perf_mem__snp_scnprintf(char *out, size_t sz, const struct mem_info *mem_inf
int perf_mem__lck_scnprintf(char *out, size_t sz, const struct mem_info *mem_info);
int perf_mem__blk_scnprintf(char *out, size_t sz, const struct mem_info *mem_info);
-int perf_script__meminfo_scnprintf(char *bf, size_t size, const struct mem_info *mem_info);
+int perf_script__meminfo_scnprintf(char *bf, size_t size, const struct mem_info *mem_info,
+ struct perf_session *session);
struct c2c_stats {
u32 nr_entries;
diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
index 239104b0337d..038c4268a429 100644
--- a/tools/perf/util/scripting-engines/trace-event-python.c
+++ b/tools/perf/util/scripting-engines/trace-event-python.c
@@ -58,6 +58,7 @@
#include "stat.h"
#include "mem-events.h"
#include "util/perf_regs.h"
+#include "util/session.h"
#define _PyUnicode_FromString(arg) \
PyUnicode_FromString(arg)
@@ -694,8 +695,9 @@ static void set_sample_read_in_dict(PyObject *dict_sample, struct perf_sample *s
static void set_sample_datasrc_in_dict(PyObject *dict,
struct perf_sample *sample)
{
+ struct perf_session *session = evsel__session(sample->evsel);
struct mem_info *mi = mem_info__new();
- char decode[100];
+ char decode[200];
if (!mi)
Py_FatalError("couldn't create mem-info");
@@ -704,7 +706,7 @@ static void set_sample_datasrc_in_dict(PyObject *dict,
PyLong_FromUnsignedLongLong(sample->data_src));
mem_info__data_src(mi)->val = sample->data_src;
- perf_script__meminfo_scnprintf(decode, 100, mi);
+ perf_script__meminfo_scnprintf(decode, 200, mi, session);
mem_info__put(mi);
pydict_set_item_string_decref(dict, "datasrc_decode",
--
2.43.0
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v12 6/6] perf c2c: print memory region data with stdio output
2026-09-23 17:08 ` [PATCH v12 0/6] perf: Add support for memory region/range reporting Thomas Falcon
` (4 preceding siblings ...)
2026-09-23 17:09 ` [PATCH v12 5/6] perf tools: Show memory region in perf-script subcommand Thomas Falcon
@ 2026-09-23 17:09 ` Thomas Falcon
2026-09-24 17:35 ` [PATCH v12 0/6] perf: Add support for memory region/range reporting Arnaldo Carvalho de Melo
6 siblings, 0 replies; 11+ messages in thread
From: Thomas Falcon @ 2026-09-23 17:09 UTC (permalink / raw)
To: sashiko-bot
Cc: linux-perf-users, linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
James Clark, Dapeng Mi
Print memory range data in perf-c2c subcommand. Only available in stdio
mode currently. If memory ranges are not supported or present, print
nothing.
Example output of perf c2c report --stdio:
=================================================
Memory Ranges
=================================================
Range 0: [0x0000000000000000-0x00000000bfffffff] Node 0, local region id 0, remote region id 255
Range 1: [0x0000000100000000-0x000000203fffffff] Node 0, local region id 0, remote region id 255
Range 2: [0x0000008000000000-0x0000027fffffffff] Node -2, local region id 1, remote region id 255
Range 3: [0x0000028000000000-0x0000047fffffffff] Node -2, local region id 1, remote region id 255
Range 4: [0x0000048000000000-0x000004ffffffffff] Node -2, local region id 1, remote region id 255
Assisted-by: Sashiko:gemini-3.1-pro-preview
Reviewed-by: Ian Rogers <irogers@google.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>
---
v10: Fixup double blank line before print_memory_ranges_info() define
---
tools/perf/builtin-c2c.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index a42423ca990d..2c8e1c7adedd 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -2597,6 +2597,33 @@ static void print_c2c_info(FILE *out, struct perf_session *session)
fprintf(out, " Cacheline data grouping : %s\n", c2c.cl_sort);
}
+static void print_memory_ranges_info(FILE *out, struct perf_session *session)
+{
+ struct perf_env *env = perf_session__env(session);
+ int nr_ranges = 0;
+
+ if (!perf_header__has_feat(&session->header, HEADER_MEMORY_RANGES))
+ return;
+ nr_ranges = env->nr_memory_ranges;
+ if (nr_ranges == 0) {
+ pr_debug("No memory ranges found, skipping\n");
+ return;
+ }
+
+ fprintf(out, "\n");
+ fprintf(out, "=================================================\n");
+ fprintf(out, " Memory Ranges \n");
+ fprintf(out, "=================================================\n");
+
+ for (int i = 0; i < nr_ranges; i++) {
+ struct memory_range *r = &env->memory_ranges[i];
+
+ fprintf(out, "Range %d: [0x%016" PRIx64 "-0x%016" PRIx64 "] Node %d, local region id %u, remote region id %u\n",
+ i, r->base, r->base + r->length - 1, r->node,
+ r->local_region_id, r->remote_region_id);
+ }
+}
+
static void perf_c2c__hists_fprintf(FILE *out, struct perf_session *session)
{
setup_pager();
@@ -2610,6 +2637,8 @@ static void perf_c2c__hists_fprintf(FILE *out, struct perf_session *session)
if (c2c.stats_only)
return;
+ print_memory_ranges_info(out, session);
+
fprintf(out, "\n");
fprintf(out, "=================================================\n");
fprintf(out, " Shared Data Cache Line Table \n");
--
2.43.0
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v12 0/6] perf: Add support for memory region/range reporting
2026-09-23 17:08 ` [PATCH v12 0/6] perf: Add support for memory region/range reporting Thomas Falcon
` (5 preceding siblings ...)
2026-09-23 17:09 ` [PATCH v12 6/6] perf c2c: print memory region data with stdio output Thomas Falcon
@ 2026-09-24 17:35 ` Arnaldo Carvalho de Melo
6 siblings, 0 replies; 11+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-09-24 17:35 UTC (permalink / raw)
To: Thomas Falcon
Cc: sashiko-bot, linux-perf-users, linux-kernel, Peter Zijlstra,
Ingo Molnar, Namhyung Kim, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Ian Rogers, Adrian Hunter, James Clark, Dapeng Mi
On Wed, Sep 23, 2026 at 12:08:57PM -0500, Thomas Falcon wrote:
> Add support for two memory-related reporting features in the perf tool:
<SNIP>
> Include a change allowing PERF_MEM_LVLNUM_L0 to be printed in
> perf-mem output as well.
> [1]: https://lore.kernel.org/all/20260114011750.350569-1-dapeng1.mi@linux.intel.com/
> [2]: https://lore.kernel.org/lkml/20250505173819.419271-1-tony.luck@intel.com/
> [3]: MRRM definition allow for future expansion for the OS to assign
> these region IDs.
> v12:
> -- Fixed typo in bounds checking for max supported memory ranges when
> reading header data
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
^ permalink raw reply [flat|nested] 11+ messages in thread