mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mm: remove the unused zone->unaccepted_cleanup
@ 2026-09-24 19:11 Usama Arif
  2026-09-24 19:21 ` David Hildenbrand (Arm)
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Usama Arif @ 2026-09-24 19:11 UTC (permalink / raw)
  To: Andrew Morton, axelrasmussen, baohua, baolin.wang, baoquan.he,
	david, kasong, liam, linux-kernel, linux-mm, ljs, mhocko,
	qi.zheng, rppt, shakeel.butt, surenb, vbabka, weixugc, yuanchu,
	hannes, kernel-team
  Cc: Usama Arif

Commit fefc07518227 ("mm/page_alloc: fix race condition in unaccepted
memory handling") removed the zones_with_unaccepted_pages static key and
the work that decremented it, but left the work_struct behind in struct
zone. Nothing uses it anymore, so let's remove it.

Signed-off-by: Usama Arif <usama.arif@linux.dev>
---
 include/linux/mmzone.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 65e2e0249b04f..e9d3845d10554 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -1100,9 +1100,6 @@ struct zone {
 #ifdef CONFIG_UNACCEPTED_MEMORY
 	/* Pages to be accepted. All pages on the list are MAX_PAGE_ORDER */
 	struct list_head	unaccepted_pages;
-
-	/* To be called once the last page in the zone is accepted */
-	struct work_struct	unaccepted_cleanup;
 #endif
 
 	/* zone flags, see below */
-- 
2.53.0-Meta


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mm: remove the unused zone->unaccepted_cleanup
  2026-09-24 19:11 [PATCH] mm: remove the unused zone->unaccepted_cleanup Usama Arif
@ 2026-09-24 19:21 ` David Hildenbrand (Arm)
  2026-09-24 20:08 ` Shakeel Butt
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand (Arm) @ 2026-09-24 19:21 UTC (permalink / raw)
  To: Usama Arif, Andrew Morton, axelrasmussen, baohua, baolin.wang,
	baoquan.he, kasong, liam, linux-kernel, linux-mm, ljs, mhocko,
	qi.zheng, rppt, shakeel.butt, surenb, vbabka, weixugc, yuanchu,
	hannes, kernel-team

On 9/24/26 21:11, Usama Arif wrote:
> Commit fefc07518227 ("mm/page_alloc: fix race condition in unaccepted
> memory handling") removed the zones_with_unaccepted_pages static key and
> the work that decremented it, but left the work_struct behind in struct
> zone. Nothing uses it anymore, so let's remove it.
> 
> Signed-off-by: Usama Arif <usama.arif@linux.dev>
> ---

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mm: remove the unused zone->unaccepted_cleanup
  2026-09-24 19:11 [PATCH] mm: remove the unused zone->unaccepted_cleanup Usama Arif
  2026-09-24 19:21 ` David Hildenbrand (Arm)
@ 2026-09-24 20:08 ` Shakeel Butt
  2026-09-24 20:20 ` Johannes Weiner
  2026-09-24 20:49 ` Barry Song
  3 siblings, 0 replies; 5+ messages in thread
From: Shakeel Butt @ 2026-09-24 20:08 UTC (permalink / raw)
  To: Usama Arif
  Cc: Andrew Morton, axelrasmussen, baohua, baolin.wang, baoquan.he,
	david, kasong, liam, linux-kernel, linux-mm, ljs, mhocko,
	qi.zheng, rppt, surenb, vbabka, weixugc, yuanchu, hannes,
	kernel-team

On Thu, Sep 24, 2026 at 12:11:03PM -0700, Usama Arif wrote:
> Commit fefc07518227 ("mm/page_alloc: fix race condition in unaccepted
> memory handling") removed the zones_with_unaccepted_pages static key and
> the work that decremented it, but left the work_struct behind in struct
> zone. Nothing uses it anymore, so let's remove it.
> 
> Signed-off-by: Usama Arif <usama.arif@linux.dev>

Reviewed-by: Shakeel Butt <shakeel.butt@linux.dev>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mm: remove the unused zone->unaccepted_cleanup
  2026-09-24 19:11 [PATCH] mm: remove the unused zone->unaccepted_cleanup Usama Arif
  2026-09-24 19:21 ` David Hildenbrand (Arm)
  2026-09-24 20:08 ` Shakeel Butt
@ 2026-09-24 20:20 ` Johannes Weiner
  2026-09-24 20:49 ` Barry Song
  3 siblings, 0 replies; 5+ messages in thread
From: Johannes Weiner @ 2026-09-24 20:20 UTC (permalink / raw)
  To: Usama Arif
  Cc: Andrew Morton, axelrasmussen, baohua, baolin.wang, baoquan.he,
	david, kasong, liam, linux-kernel, linux-mm, ljs, mhocko,
	qi.zheng, rppt, shakeel.butt, surenb, vbabka, weixugc, yuanchu,
	kernel-team

On Thu, Sep 24, 2026 at 12:11:03PM -0700, Usama Arif wrote:
> Commit fefc07518227 ("mm/page_alloc: fix race condition in unaccepted
> memory handling") removed the zones_with_unaccepted_pages static key and
> the work that decremented it, but left the work_struct behind in struct
> zone. Nothing uses it anymore, so let's remove it.
> 
> Signed-off-by: Usama Arif <usama.arif@linux.dev>

Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mm: remove the unused zone->unaccepted_cleanup
  2026-09-24 19:11 [PATCH] mm: remove the unused zone->unaccepted_cleanup Usama Arif
                   ` (2 preceding siblings ...)
  2026-09-24 20:20 ` Johannes Weiner
@ 2026-09-24 20:49 ` Barry Song
  3 siblings, 0 replies; 5+ messages in thread
From: Barry Song @ 2026-09-24 20:49 UTC (permalink / raw)
  To: Usama Arif
  Cc: Andrew Morton, axelrasmussen, baolin.wang, baoquan.he, david,
	kasong, liam, linux-kernel, linux-mm, ljs, mhocko, qi.zheng,
	rppt, shakeel.butt, surenb, vbabka, weixugc, yuanchu, hannes,
	kernel-team

On Fri, Sep 25, 2026 at 3:11 AM Usama Arif <usama.arif@linux.dev> wrote:
>
> Commit fefc07518227 ("mm/page_alloc: fix race condition in unaccepted
> memory handling") removed the zones_with_unaccepted_pages static key and
> the work that decremented it, but left the work_struct behind in struct
> zone. Nothing uses it anymore, so let's remove it.
>
> Signed-off-by: Usama Arif <usama.arif@linux.dev>
> ---

Nice catch.

Reviewed-by: Barry Song <baohua@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-09-24 20:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-24 19:11 [PATCH] mm: remove the unused zone->unaccepted_cleanup Usama Arif
2026-09-24 19:21 ` David Hildenbrand (Arm)
2026-09-24 20:08 ` Shakeel Butt
2026-09-24 20:20 ` Johannes Weiner
2026-09-24 20:49 ` Barry Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®