mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Missing signoff in the perf tree
@ 2026-09-24 22:36 Mark Brown
  2026-09-24 22:41 ` Arnaldo Melo
  2026-09-24 22:48 ` Arnaldo Carvalho de Melo
  0 siblings, 2 replies; 8+ messages in thread
From: Mark Brown @ 2026-09-24 22:36 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo, Namhyung Kim; +Cc: linux-kernel, linux-next

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

Commit

  4c09f6c47b769 ("perf annotate: Fix NULL pointer dereference in loongarch_call__parse")

is missing a Signed-off-by from its author

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Missing signoff in the perf tree
  2026-09-24 22:36 Missing signoff in the perf tree Mark Brown
@ 2026-09-24 22:41 ` Arnaldo Melo
  2026-09-24 22:48 ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 8+ messages in thread
From: Arnaldo Melo @ 2026-09-24 22:41 UTC (permalink / raw)
  To: Mark Brown, Namhyung Kim; +Cc: linux-kernel, linux-next



On September 25, 2026 12:36:44 AM GMT+02:00, Mark Brown <broonie@kernel.org> wrote:
>Commit
>
>  4c09f6c47b769 ("perf annotate: Fix NULL pointer dereference in loongarch_call__parse")
>
>is missing a Signed-off-by from its author

I'll fix and force push.

- Arnaldo

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Missing signoff in the perf tree
  2026-09-24 22:36 Missing signoff in the perf tree Mark Brown
  2026-09-24 22:41 ` Arnaldo Melo
@ 2026-09-24 22:48 ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-09-24 22:48 UTC (permalink / raw)
  To: Mark Brown
  Cc: Arnaldo Carvalho de Melo, Namhyung Kim, linux-kernel, linux-next,
	Jianping Liu, Ming Wang

On Thu, Sep 24, 2026 at 11:36:44PM +0100, Mark Brown wrote:
> Commit
> 
>   4c09f6c47b769 ("perf annotate: Fix NULL pointer dereference in loongarch_call__parse")
> 
> is missing a Signed-off-by from its author

The patch had a --- before the author's s-o-b, so it got lost, I'll
adding it and will force push:

============================================================

the address-based symbol lookup so that ops->target.sym can still be
resolved via maps__find_ams() using the already-parsed target address.
This preserves is_call semantics and keeps TUI navigation working.

---
Changes from v1:
- Instead of returning -1 when the '<sym>' token is absent jump to the
  address-based symbol lookup so that maps__find_ams() can still resolve
  ops->target.sym from the already parsed target address.

- Link to v1: https://lore.kernel.org/all/20260423053102.3717015-1-frankljpliu@gmail.com/
---

Fixes: 4ca0d340ce20 ("perf annotate: Fix instruction association and parsing for LoongArch")
Signed-off-by: Jianping Liu <frankjpliu@tencent.com>
Reviewed-by: Ming Wang <wangming01@loongson.cn>

======================


- Arnaldo

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Missing signoff in the perf tree
  2026-06-30 11:44   ` Mark Brown
@ 2026-06-30 17:14     ` Namhyung Kim
  0 siblings, 0 replies; 8+ messages in thread
From: Namhyung Kim @ 2026-06-30 17:14 UTC (permalink / raw)
  To: Mark Brown
  Cc: Arnaldo Carvalho de Melo, Arnaldo Carvalho de Melo, linux-kernel,
	linux-next

Hello,

On Tue, Jun 30, 2026 at 12:44:10PM +0100, Mark Brown wrote:
> On Tue, Jun 30, 2026 at 08:43:00AM -0300, Arnaldo Carvalho de Melo wrote:
> 
> > Namhyung, take a look, I think you did something that made you become
> > the committer but then you didn't S-o-B it, please fix and force push.
> 
> That's usually a rebase.

Yep, I've rebased the python changes onto v7.2-rc1 but forgot to check
the S-o-b.  Sorry for the trouble, will fix and push soon.

Thanks,
Namhyung


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Missing signoff in the perf tree
  2026-06-30 11:43 ` Arnaldo Carvalho de Melo
@ 2026-06-30 11:44   ` Mark Brown
  2026-06-30 17:14     ` Namhyung Kim
  0 siblings, 1 reply; 8+ messages in thread
From: Mark Brown @ 2026-06-30 11:44 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Arnaldo Carvalho de Melo, Namhyung Kim, linux-kernel, linux-next

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

On Tue, Jun 30, 2026 at 08:43:00AM -0300, Arnaldo Carvalho de Melo wrote:

> Namhyung, take a look, I think you did something that made you become
> the committer but then you didn't S-o-B it, please fix and force push.

That's usually a rebase.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Missing signoff in the perf tree
  2026-06-30 10:18 Mark Brown
  2026-06-30 10:23 ` Arnaldo Melo
@ 2026-06-30 11:43 ` Arnaldo Carvalho de Melo
  2026-06-30 11:44   ` Mark Brown
  1 sibling, 1 reply; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-06-30 11:43 UTC (permalink / raw)
  To: Mark Brown
  Cc: Arnaldo Carvalho de Melo, Namhyung Kim, linux-kernel, linux-next

On Tue, Jun 30, 2026 at 11:18:01AM +0100, Mark Brown wrote:
> Commits
> 
>   535c327f22a28 ("perf python: Add LiveSession helper")
>   4f093d248b148 ("perf python: Add perf.pyi stubs file")
>   145f6bea48134 ("perf python: Add type checking for parse_events/parse_metrics")
>   1bb0a1721f3f1 ("perf python: Handle Py_None for thread and cpu maps")
>   226e60c35ac93 ("perf python: Add config file access")
>   2b8aad745c248 ("perf python: Add syscall name/id to convert syscall number and name")
>   6efb7ef71b226 ("perf python: Expose brstack in sample event")
>   1b3460930fcda ("perf python: Extend API for stat events in python.c")
>   4d97f00572c6f ("perf python: Add callchain support")
>   0dd3f949cfb58 ("perf python: Add mmap2 event")
>   b81c05a559ee7 ("perf python: Refactor and add accessors to sample event")
>   beed2f88c2d7b ("perf python: Add python session abstraction wrapping perf's session")
>   f46938e02fa6c ("perf python: Add wrapper for perf_data file abstraction")
>   d8da1ea834a88 ("perf python: Use evsel in sample in pyrf_event")
>   3e153b92b6e88 ("perf evlist: Add reference count checking")
>   4d7018b55734f ("perf evsel: Add reference count")
>   7e7110bdf0e37 ("perf evlist: Add reference count")
>   ca42447bde058 ("perf data: Add open flag")
>   3d295e4e6974a ("perf evsel/evlist: Avoid unnecessary #includes")
>   6a7ac633a3e8c ("perf python: Add missed explicit dependencies")
>   bdd53407c817d ("perf util: Sort includes and add missed explicit dependencies")
> 
> are missing a Signed-off-by from their committers

I see it:

acme@number:~/git/perf-tools-next$ git show --format=fuller 535c327f22a28
commit 535c327f22a28fcbbdfc9189cbeef8d54f187364 (perf-tools-next.korg/perf-tools-next)
Author:     Ian Rogers <irogers@google.com>
AuthorDate: Mon Jun 15 18:15:43 2026 -0700
Commit:     Namhyung Kim <namhyung@kernel.org>
CommitDate: Mon Jun 29 10:47:59 2026 -0700

    perf python: Add LiveSession helper

    Add LiveSession class in tools/perf/python/perf_live.py to support
    live event collection using perf.evlist and perf.parse_events,
    avoiding the need to fork a separate perf record process.

    Signed-off-by: Ian Rogers <irogers@google.com>
    Assisted-by: Gemini:gemini-3.1-pro-preview
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alice Rogers <alice.mei.rogers@gmail.com>
    Cc: Dapeng Mi <dapeng1.mi@linux.intel.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: James Clark <james.clark@linaro.org>
    Cc: Leo Yan <leo.yan@linux.dev>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Richter <tmricht@linux.ibm.com>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>


That was the last series I committed and then removed from the 7.2
submission as per a discussion with Mark, i.e. even being tested a lot
it missed the window, not being strict fixes.

Namhyung, take a look, I think you did something that made you become
the committer but then you didn't S-o-B it, please fix and force push.

Thanks,

- Arnaldo

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Missing signoff in the perf tree
  2026-06-30 10:18 Mark Brown
@ 2026-06-30 10:23 ` Arnaldo Melo
  2026-06-30 11:43 ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 8+ messages in thread
From: Arnaldo Melo @ 2026-06-30 10:23 UTC (permalink / raw)
  To: Mark Brown, Namhyung Kim; +Cc: linux-kernel, linux-next



On June 30, 2026 7:18:01 AM GMT-03:00, Mark Brown <broonie@kernel.org> wrote:
>Commits
>
>  535c327f22a28 ("perf python: Add LiveSession helper")
>  4f093d248b148 ("perf python: Add perf.pyi stubs file")
>  145f6bea48134 ("perf python: Add type checking for parse_events/parse_metrics")
>  1bb0a1721f3f1 ("perf python: Handle Py_None for thread and cpu maps")
>  226e60c35ac93 ("perf python: Add config file access")
>  2b8aad745c248 ("perf python: Add syscall name/id to convert syscall number and name")
>  6efb7ef71b226 ("perf python: Expose brstack in sample event")
>  1b3460930fcda ("perf python: Extend API for stat events in python.c")
>  4d97f00572c6f ("perf python: Add callchain support")
>  0dd3f949cfb58 ("perf python: Add mmap2 event")
>  b81c05a559ee7 ("perf python: Refactor and add accessors to sample event")
>  beed2f88c2d7b ("perf python: Add python session abstraction wrapping perf's session")
>  f46938e02fa6c ("perf python: Add wrapper for perf_data file abstraction")
>  d8da1ea834a88 ("perf python: Use evsel in sample in pyrf_event")
>  3e153b92b6e88 ("perf evlist: Add reference count checking")
>  4d7018b55734f ("perf evsel: Add reference count")
>  7e7110bdf0e37 ("perf evlist: Add reference count")
>  ca42447bde058 ("perf data: Add open flag")
>  3d295e4e6974a ("perf evsel/evlist: Avoid unnecessary #includes")
>  6a7ac633a3e8c ("perf python: Add missed explicit dependencies")
>  bdd53407c817d ("perf util: Sort includes and add missed explicit dependencies")
>
>are missing a Signed-off-by from their committers.

Thanks for reporting, I'll fix and force push,

- Arnaldo

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Missing signoff in the perf tree
@ 2026-06-30 10:18 Mark Brown
  2026-06-30 10:23 ` Arnaldo Melo
  2026-06-30 11:43 ` Arnaldo Carvalho de Melo
  0 siblings, 2 replies; 8+ messages in thread
From: Mark Brown @ 2026-06-30 10:18 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo, Namhyung Kim; +Cc: linux-kernel, linux-next

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

Commits

  535c327f22a28 ("perf python: Add LiveSession helper")
  4f093d248b148 ("perf python: Add perf.pyi stubs file")
  145f6bea48134 ("perf python: Add type checking for parse_events/parse_metrics")
  1bb0a1721f3f1 ("perf python: Handle Py_None for thread and cpu maps")
  226e60c35ac93 ("perf python: Add config file access")
  2b8aad745c248 ("perf python: Add syscall name/id to convert syscall number and name")
  6efb7ef71b226 ("perf python: Expose brstack in sample event")
  1b3460930fcda ("perf python: Extend API for stat events in python.c")
  4d97f00572c6f ("perf python: Add callchain support")
  0dd3f949cfb58 ("perf python: Add mmap2 event")
  b81c05a559ee7 ("perf python: Refactor and add accessors to sample event")
  beed2f88c2d7b ("perf python: Add python session abstraction wrapping perf's session")
  f46938e02fa6c ("perf python: Add wrapper for perf_data file abstraction")
  d8da1ea834a88 ("perf python: Use evsel in sample in pyrf_event")
  3e153b92b6e88 ("perf evlist: Add reference count checking")
  4d7018b55734f ("perf evsel: Add reference count")
  7e7110bdf0e37 ("perf evlist: Add reference count")
  ca42447bde058 ("perf data: Add open flag")
  3d295e4e6974a ("perf evsel/evlist: Avoid unnecessary #includes")
  6a7ac633a3e8c ("perf python: Add missed explicit dependencies")
  bdd53407c817d ("perf util: Sort includes and add missed explicit dependencies")

are missing a Signed-off-by from their committers

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-09-24 22:48 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-24 22:36 Missing signoff in the perf tree Mark Brown
2026-09-24 22:41 ` Arnaldo Melo
2026-09-24 22:48 ` Arnaldo Carvalho de Melo
  -- strict thread matches above, loose matches on Subject: below --
2026-06-30 10:18 Mark Brown
2026-06-30 10:23 ` Arnaldo Melo
2026-06-30 11:43 ` Arnaldo Carvalho de Melo
2026-06-30 11:44   ` Mark Brown
2026-06-30 17:14     ` Namhyung Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®