From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Ruslan Koreev <koreev.r@gmail.com>
Cc: benjamin.mugnier@foss.st.com, sylvain.petinot@foss.st.com,
dan.scally@ideasonboard.com, mchehab@kernel.org,
hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Peter Marshall <pm@petermarshall.ca>
Subject: Re: [PATCH 4/4] media: staging/ipu7: Add monochrome pixel formats
Date: Fri, 25 Sep 2026 11:51:21 +0300 [thread overview]
Message-ID: <arY2CULvwXGyVvH_@kekkonen.localdomain> (raw)
In-Reply-To: <20260924171820.1179823-5-koreev.r@gmail.com>
Hi Ruslan,
On Thu, Sep 24, 2026 at 08:18:20PM +0300, Ruslan Koreev wrote:
> The CSI-2 receiver already accepts MEDIA_BUS_FMT_Y10_1X10 but the video
> nodes offer no pixel format for it, and MEDIA_BUS_FMT_Y8_1X8 is not
> accepted at all, so a monochrome sensor cannot stream through the IPU7:
> the ST VD55G1 IR camera of the Lenovo ThinkPad X1 Carbon Gen 14 only
> produces Y8 and Y10 and no configuration can be negotiated for it.
>
> Add the GREY, Y10 and Y10P pixel formats, mapped to the RAW8, RAW16
> and RAW10 frame formats like their Bayer counterparts, and accept
> MEDIA_BUS_FMT_Y8_1X8 on the CSI-2 receiver with the RAW8 data type.
> ipu7_isys_is_bayer_format() treats every raw code as Bayer, so the mono
> codes take the raw path in the CSI-2 cropping code; leave them alone in
> ipu7_isys_convert_bayer_order(), which otherwise warns about them. The
> two parts belong together: with the mono codes exposed but not excluded
> there, any crop offset on a mono stream triggers the warning.
>
> Tested with the VD55G1 on that laptop: libcamera negotiates Y8 and
> streams 804x704 at 58 fps, and Y10 and Y10P stream with plain V4L2.
Can you try doing this with the ipu6 driver instead? We're about to drop
the ipu7 staging driver after some smallish number of kernel releases.
--
Regards,
Sakari Ailus
prev parent reply other threads:[~2026-09-25 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 17:18 [PATCH 0/4] Lenovo ThinkPad X1 Carbon Gen 14 IR camera: ST VD55G1 on Intel IPU7 Ruslan Koreev
2026-09-24 17:18 ` [PATCH 1/4] platform/x86: int3472: Map the VD55G1 power enable GPIO to "vana" Ruslan Koreev
2026-09-24 17:18 ` [PATCH 2/4] media: ipu-bridge: Add the ST VD55G1 (TBE20A1) Ruslan Koreev
2026-09-24 17:18 ` [PATCH 3/4] media: i2c: vd55g1: Add ACPI support for the Lenovo TBE20A1 HID Ruslan Koreev
2026-09-25 8:50 ` Sakari Ailus
2026-09-24 17:18 ` [PATCH 4/4] media: staging/ipu7: Add monochrome pixel formats Ruslan Koreev
2026-09-25 8:51 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arY2CULvwXGyVvH_@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=dan.scally@ideasonboard.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=koreev.r@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pm@petermarshall.ca \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®