mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qiling Zhu <kmatzkaczor244@gmail.com>
To: Ruslan Koreev <koreev.r@gmail.com>
Cc: sakari.ailus@linux.intel.com, benjamin.mugnier@foss.st.com,
	 sylvain.petinot@foss.st.com, dan.scally@ideasonboard.com,
	mchehab@kernel.org,  hansg@kernel.org,
	ilpo.jarvinen@linux.intel.com, gregkh@linuxfoundation.org,
	 linux-media@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	 linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	pm@petermarshall.ca
Subject: Re: [PATCH 4/4] media: staging/ipu7: Add monochrome pixel formats
Date: Tue, 29 Sep 2026 21:25:39 +0800	[thread overview]
Message-ID: <aru5-aq_sPUDy8dq@ThinkPad> (raw)
In-Reply-To: <20260929092238.1765758-1-koreev.r@gmail.com>

Hi Ruslan,

On Tue, Sep 29, 2026 at 12:22:38PM +0300, Ruslan Koreev wrote:

> I wasn't aware the ipu6 driver had grown IPU7 support, my base was
> 7.3-rc5. Tested now on next-20260924 with the ipu6 driver and patches
> 1-3, the vd55g1 one reworked as you suggested: the sensor probes,
> ipu-bridge connects both cameras, libcamera streams Y8 804x704 at 58 fps
> from the VD55G1, and Y10 and Y10P stream with plain V4L2. So this patch
> is not needed there; I'll drop it in v2.
> 
> Ruslan

I tested patches 1-3 from v1 on another ThinkPad X1 Carbon Gen 14
(21V8A028CD, Panther Lake, IPU7 PCI 8086:b05d) using the ipu6 driver on
next-20260928. I did not apply patch 4.

Patches 1-3 applied cleanly without local changes. The VD55G1
probes successfully, TBE20A1 is discovered by ipu-bridge, and the
media topology is established as:

  vd55g1 1-0010
    -> Intel IPU6 CSI2 2
    -> Intel IPU6 ISYS Capture 16
    -> /dev/video16

The sensor reports Y10_1X10/804x704, and /dev/video16 enumerates
GREY, Y10 and Y10P. Setting Y10 at 804x704 succeeds with:

  Bytes per Line : 1664
  Size Image     : 1173120

However, VIDIOC_STREAMON returns EPIPE for Y10, Y10P and GREY,
and no frames are captured.

Since you reported successful plain-V4L2 Y10/Y10P streaming on
next-20260924, could you share the exact media-ctl/v4l2-ctl commands
and any setup performed before STREAMON? I'd like to reproduce the
same sequence before looking for differences between the two
linux-next snapshots.

My test base before applying the series was:

  6375e61c01e93e35ee7acd336a689ac1fae4b509 (next-20260928)

Hardware: ThinkPad X1 Carbon Gen 14, 21V8A028CD
Kernel: 7.3.0-rc5-next-20260928-x1c14ir

Thanks,
Qiling Zhu

      reply	other threads:[~2026-09-29 13:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 17:18 [PATCH 0/4] Lenovo ThinkPad X1 Carbon Gen 14 IR camera: ST VD55G1 on Intel IPU7 Ruslan Koreev
2026-09-24 17:18 ` [PATCH 1/4] platform/x86: int3472: Map the VD55G1 power enable GPIO to "vana" Ruslan Koreev
2026-09-28  8:39   ` Benjamin Mugnier
2026-09-24 17:18 ` [PATCH 2/4] media: ipu-bridge: Add the ST VD55G1 (TBE20A1) Ruslan Koreev
2026-09-28  8:39   ` Benjamin Mugnier
2026-09-24 17:18 ` [PATCH 3/4] media: i2c: vd55g1: Add ACPI support for the Lenovo TBE20A1 HID Ruslan Koreev
2026-09-25  8:50   ` Sakari Ailus
2026-09-24 17:18 ` [PATCH 4/4] media: staging/ipu7: Add monochrome pixel formats Ruslan Koreev
2026-09-25  8:51   ` Sakari Ailus
2026-09-29  9:22     ` Ruslan Koreev
2026-09-29 13:25       ` Qiling Zhu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aru5-aq_sPUDy8dq@ThinkPad \
    --to=kmatzkaczor244@gmail.com \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=koreev.r@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pm@petermarshall.ca \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®