[PATCH] tty: add break_wait kernel-doc

[PATCH] tty: add break_wait kernel-doc

[Johan Hovold]

Add the missing kernel-doc description for the new break_wait field in
struct tty_struct.

Fixes: c7e9bff9b4b3 ("tty: abort break signalling on hangup")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/20d75a7a-2e7a-484f-a267-c21db82dd922@infradead.org
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 include/linux/tty.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/tty.h b/include/linux/tty.h
index ad4e4a835f90..833bb7b97ceb 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -168,6 +168,7 @@ struct tty_operations;
  * @write_wait: concurrent writers are waiting in this queue until they are
  *		allowed to write
  * @read_wait: readers wait for data in this queue
+ * @break_wait: wait queue for timed breaks
  * @hangup_work: normally a work to perform a hangup (do_tty_hangup()); while
  *		 freeing the tty, (re)used to release_one_tty()
  * @disc_data: pointer to @ldisc's private data (e.g. to &struct n_tty_data)
-- 
2.55.0

Re: [PATCH] tty: add break_wait kernel-doc

[Greg Kroah-Hartman]

On Fri, Sep 25, 2026 at 11:42:22AM +0200, Johan Hovold wrote:
> Add the missing kernel-doc description for the new break_wait field in
> struct tty_struct.
> 
> Fixes: c7e9bff9b4b3 ("tty: abort break signalling on hangup")

Don't you mean:
	845a2737e0f5 ("tty: abort break signalling on hangup")
?

thanks,

greg k-h

Re: [PATCH] tty: add break_wait kernel-doc

[Johan Hovold]

On Fri, Sep 25, 2026 at 11:55:48AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Sep 25, 2026 at 11:42:22AM +0200, Johan Hovold wrote:
> > Add the missing kernel-doc description for the new break_wait field in
> > struct tty_struct.
> > 
> > Fixes: c7e9bff9b4b3 ("tty: abort break signalling on hangup")
> 
> Don't you mean:
> 	845a2737e0f5 ("tty: abort break signalling on hangup")
> ?

Yes, sorry. Can you fix it up when applying or do you want me to resend?

Johan

Re: [PATCH] tty: add break_wait kernel-doc

[Greg Kroah-Hartman]

On Fri, Sep 25, 2026 at 12:02:00PM +0200, Johan Hovold wrote:
> On Fri, Sep 25, 2026 at 11:55:48AM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Sep 25, 2026 at 11:42:22AM +0200, Johan Hovold wrote:
> > > Add the missing kernel-doc description for the new break_wait field in
> > > struct tty_struct.
> > > 
> > > Fixes: c7e9bff9b4b3 ("tty: abort break signalling on hangup")
> > 
> > Don't you mean:
> > 	845a2737e0f5 ("tty: abort break signalling on hangup")
> > ?
> 
> Yes, sorry. Can you fix it up when applying or do you want me to resend?

I'll fix it up, no worries, thanks.

greg k-h