* [PATCH v1] perf test: stat metrics cgroup strip possible slash from cgroup name
@ 2026-09-17 6:13 Ian Rogers
2026-09-25 15:33 ` Ian Rogers
2026-09-25 15:35 ` Namhyung Kim
0 siblings, 2 replies; 4+ messages in thread
From: Ian Rogers @ 2026-09-17 6:13 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Jiri Olsa, Ian Rogers, Adrian Hunter, James Clark,
linux-perf-users, linux-kernel
The grep to match cgroup name in metric output assumes no leading / on
the cgroup name, however, cgroups in /proc/self/cgroup may have a
leading /. Strip the / if it exists to avoid failures to match the
cgroup name in the perf stat output.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/stat_metrics_cgrp.sh | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/perf/tests/shell/stat_metrics_cgrp.sh b/tools/perf/tests/shell/stat_metrics_cgrp.sh
index d4226ee0ae98..0728f48f21fa 100755
--- a/tools/perf/tests/shell/stat_metrics_cgrp.sh
+++ b/tools/perf/tests/shell/stat_metrics_cgrp.sh
@@ -86,6 +86,13 @@ check_metric_reported()
for cgrp in "${cgrps[@]}"; do
# Find metric lines for this cgroup
+ case "$cgrp" in
+ /) # The root cgroup, leave unchanged.
+ ;;
+ /*) # Strip any starting slashes.
+ cgrp="${cgrp#/}"
+ ;;
+ esac
# We use exact cgroup match with surrounding commas
local cgrp_lines
cgrp_lines=$(echo "${output}" | grep -F ",${cgrp}," | grep "insn_per_cycle" || true)
--
2.55.0.1082.g2b9226bbc0-goog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] perf test: stat metrics cgroup strip possible slash from cgroup name
2026-09-17 6:13 [PATCH v1] perf test: stat metrics cgroup strip possible slash from cgroup name Ian Rogers
@ 2026-09-25 15:33 ` Ian Rogers
2026-09-25 15:39 ` Arnaldo Carvalho de Melo
2026-09-25 15:35 ` Namhyung Kim
1 sibling, 1 reply; 4+ messages in thread
From: Ian Rogers @ 2026-09-25 15:33 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Jiri Olsa, Ian Rogers, Adrian Hunter, James Clark,
linux-perf-users, linux-kernel
On Wed, Sep 16, 2026 at 11:13 PM Ian Rogers <irogers@google.com> wrote:
>
> The grep to match cgroup name in metric output assumes no leading / on
> the cgroup name, however, cgroups in /proc/self/cgroup may have a
> leading /. Strip the / if it exists to avoid failures to match the
> cgroup name in the perf stat output.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Ping.
Thanks,
Ian
> ---
> tools/perf/tests/shell/stat_metrics_cgrp.sh | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tools/perf/tests/shell/stat_metrics_cgrp.sh b/tools/perf/tests/shell/stat_metrics_cgrp.sh
> index d4226ee0ae98..0728f48f21fa 100755
> --- a/tools/perf/tests/shell/stat_metrics_cgrp.sh
> +++ b/tools/perf/tests/shell/stat_metrics_cgrp.sh
> @@ -86,6 +86,13 @@ check_metric_reported()
>
> for cgrp in "${cgrps[@]}"; do
> # Find metric lines for this cgroup
> + case "$cgrp" in
> + /) # The root cgroup, leave unchanged.
> + ;;
> + /*) # Strip any starting slashes.
> + cgrp="${cgrp#/}"
> + ;;
> + esac
> # We use exact cgroup match with surrounding commas
> local cgrp_lines
> cgrp_lines=$(echo "${output}" | grep -F ",${cgrp}," | grep "insn_per_cycle" || true)
> --
> 2.55.0.1082.g2b9226bbc0-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] perf test: stat metrics cgroup strip possible slash from cgroup name
2026-09-17 6:13 [PATCH v1] perf test: stat metrics cgroup strip possible slash from cgroup name Ian Rogers
2026-09-25 15:33 ` Ian Rogers
@ 2026-09-25 15:35 ` Namhyung Kim
1 sibling, 0 replies; 4+ messages in thread
From: Namhyung Kim @ 2026-09-25 15:35 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Jiri Olsa,
Adrian Hunter, James Clark, linux-perf-users, linux-kernel
On Wed, Sep 16, 2026 at 11:13:12PM -0700, Ian Rogers wrote:
> The grep to match cgroup name in metric output assumes no leading / on
> the cgroup name, however, cgroups in /proc/self/cgroup may have a
> leading /. Strip the / if it exists to avoid failures to match the
> cgroup name in the perf stat output.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/tests/shell/stat_metrics_cgrp.sh | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tools/perf/tests/shell/stat_metrics_cgrp.sh b/tools/perf/tests/shell/stat_metrics_cgrp.sh
> index d4226ee0ae98..0728f48f21fa 100755
> --- a/tools/perf/tests/shell/stat_metrics_cgrp.sh
> +++ b/tools/perf/tests/shell/stat_metrics_cgrp.sh
> @@ -86,6 +86,13 @@ check_metric_reported()
>
> for cgrp in "${cgrps[@]}"; do
> # Find metric lines for this cgroup
> + case "$cgrp" in
> + /) # The root cgroup, leave unchanged.
> + ;;
> + /*) # Strip any starting slashes.
> + cgrp="${cgrp#/}"
> + ;;
> + esac
> # We use exact cgroup match with surrounding commas
> local cgrp_lines
> cgrp_lines=$(echo "${output}" | grep -F ",${cgrp}," | grep "insn_per_cycle" || true)
> --
> 2.55.0.1082.g2b9226bbc0-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] perf test: stat metrics cgroup strip possible slash from cgroup name
2026-09-25 15:33 ` Ian Rogers
@ 2026-09-25 15:39 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-09-25 15:39 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Namhyung Kim, Jiri Olsa,
Adrian Hunter, James Clark, linux-perf-users, linux-kernel
On Fri, Sep 25, 2026 at 08:33:08AM -0700, Ian Rogers wrote:
> On Wed, Sep 16, 2026 at 11:13 PM Ian Rogers <irogers@google.com> wrote:
> >
> > The grep to match cgroup name in metric output assumes no leading / on
> > the cgroup name, however, cgroups in /proc/self/cgroup may have a
> > leading /. Strip the / if it exists to avoid failures to match the
> > cgroup name in the perf stat output.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> Ping.
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-25 15:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 6:13 [PATCH v1] perf test: stat metrics cgroup strip possible slash from cgroup name Ian Rogers
2026-09-25 15:33 ` Ian Rogers
2026-09-25 15:39 ` Arnaldo Carvalho de Melo
2026-09-25 15:35 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®