mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hangbin Liu <hangbin.liu@linux.dev>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Donald Hunter <donald.hunter@gmail.com>,
	Danielle Ratson <danieller@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH net-next v2 6/9] netlink: specs: ethtool: re-align module-fw-flash-status
Date: Mon, 28 Sep 2026 09:40:25 +0800	[thread overview]
Message-ID: <arnFiazPHNUKul04@fedora> (raw)
In-Reply-To: <20260925213918.204767-7-ast@fiberby.net>

On Fri, Sep 25, 2026 at 09:39:09PM +0000, Asbjørn Sloth Tønnesen wrote:
> Correct the values for enum ethtool_module_fw_flash_status:
> 
> - ETHTOOL_MODULE_FW_FLASH_STATUS_STARTED is 1, not 0.
> - ETHTOOL_MODULE_FW_FLASH_STATUS_IN_PROGRESS is 2, not 1.
> - ETHTOOL_MODULE_FW_FLASH_STATUS_COMPLETED is 3, not 2.
> - ETHTOOL_MODULE_FW_FLASH_STATUS_ERROR is 4, not 3.
> 
> Re-align the YNL spec by explicitly setting the first value to 1.
> 
> CC: Andrew Lunn <andrew@lunn.ch>
> CC: Oleksij Rempel <o.rempel@pengutronix.de>
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> ---
> Note for Sashiko/Clashiko: Targeting net-next, so no "Fixes" tag.
> 
>  Documentation/netlink/specs/ethtool.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 439bf24e7c33..6868eb473478 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -47,6 +47,7 @@ definitions:
>        -
>          name: started
>          doc: The firmware flashing process has started.
> +        value: 1
>        -
>          name: in-progress
>          doc: The firmware flashing process is in progress.
> -- 
> 2.55.0
> 

Reviewed-by: Hangbin Liu <liuhangbin@kylinos.cn>

  reply	other threads:[~2026-09-28  1:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 21:39 [PATCH net-next v2 0/9] netlink: specs: enum alignment fixes Asbjørn Sloth Tønnesen
2026-09-25 21:39 ` [PATCH net-next v2 1/9] netlink: specs: rt-link: re-align IPv4 devconf Asbjørn Sloth Tønnesen
2026-09-28  1:19   ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 2/9] netlink: specs: rt-link: re-align ifla-inet6-stats Asbjørn Sloth Tønnesen
2026-09-28  1:28   ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 3/9] netlink: specs: rt-link: fix ifinfo-flags names Asbjørn Sloth Tønnesen
2026-09-28  1:29   ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 4/9] netlink: specs: devlink: fix resource-scope type Asbjørn Sloth Tønnesen
2026-09-28  2:01   ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 5/9] netlink: specs: ethtool: re-align c33-pse-ext-state Asbjørn Sloth Tønnesen
2026-09-28  1:39   ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 6/9] netlink: specs: ethtool: re-align module-fw-flash-status Asbjørn Sloth Tønnesen
2026-09-28  1:40   ` Hangbin Liu [this message]
2026-09-25 21:39 ` [PATCH net-next v2 7/9] netlink: specs: nl80211: fix naming of enum members Asbjørn Sloth Tønnesen
2026-09-28  1:47   ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 8/9] netlink: specs: tc: fix typo in cls-flags Asbjørn Sloth Tønnesen
2026-09-28  1:53   ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 9/9] netlink: specs: fix incorrect name-prefixes Asbjørn Sloth Tønnesen
2026-09-28  2:00   ` Hangbin Liu
2026-09-29 11:30 ` [PATCH net-next v2 0/9] netlink: specs: enum alignment fixes patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arnFiazPHNUKul04@fedora \
    --to=hangbin.liu@linux.dev \
    --cc=andrew@lunn.ch \
    --cc=ast@fiberby.net \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®