From: Frank Li <Frank.li@oss.nxp.com>
To: Guoniu Zhou <guoniu.zhou@oss.nxp.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Frank Li <Frank.Li@nxp.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
linux-media@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 05/11] media: imx8-isi: Apply RAW output format workaround at runtime
Date: Tue, 29 Sep 2026 09:26:29 -0500 [thread overview]
Message-ID: <arvKleQMr1mF6va5@SMW015318> (raw)
In-Reply-To: <20260929-isi_imx952-v4-5-e69f89c7c651@oss.nxp.com>
On Tue, Sep 29, 2026 at 04:52:26PM +0800, Guoniu Zhou wrote:
> Refactor the RAW format handling by storing the actual hardware output
> format (RAW10/RAW12) in the format table instead of the workaround value
> RAW16. The RAW16 workaround is now applied at runtime in
> mxc_isi_channel_set_output_format() via the new isi_out_raw_shifted()
> helper in imx8-isi-regs.h.
>
> This makes the format table accurately reflect the real hardware
> capability.
>
> Signed-off-by: Guoniu Zhou <guoniu.zhou@oss.nxp.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Changes in v4:
> - New patch
> ---
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c | 7 ++++-
> .../media/platform/nxp/imx8-isi/imx8-isi-regs.h | 13 ++++++++++
> .../media/platform/nxp/imx8-isi/imx8-isi-video.c | 30 ++++++++--------------
> 3 files changed, 30 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c
> index 6aa760ce3605..cc52a90c2477 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c
> @@ -411,13 +411,18 @@ void mxc_isi_channel_set_output_format(struct mxc_isi_pipe *pipe,
> struct v4l2_pix_format_mplane *format)
> {
> u32 val;
> + u32 fmt;
>
> /* set outbuf format */
> dev_dbg(pipe->isi->dev, "output format %p4cc", &format->pixelformat);
>
> + fmt = isi_out_raw_shifted(info->isi_out_format)
> + ? CHNL_IMG_CTRL_FORMAT_RAW16
> + : info->isi_out_format;
> +
> val = mxc_isi_read(pipe, CHNL_IMG_CTRL);
> val &= ~CHNL_IMG_CTRL_FORMAT_MASK;
> - val |= CHNL_IMG_CTRL_FORMAT(info->isi_out_format);
> + val |= CHNL_IMG_CTRL_FORMAT(fmt);
> mxc_isi_write(pipe, CHNL_IMG_CTRL, val);
>
> /* line pitch */
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-regs.h b/drivers/media/platform/nxp/imx8-isi/imx8-isi-regs.h
> index c704be882705..0f3ada30e71e 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-regs.h
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-regs.h
> @@ -421,4 +421,17 @@
> /* Channel Input Buffer Extended Address Bits */
> #define CHNL_IN_BUF_XTND_ADDR 0x00b8
>
> +/*
> + * The ISI shifts the 10-bit and 12-bit RAW formats left by 6 and 4 bits when
> + * using CHNL_IMG_CTRL_FORMAT_RAW10 or CHNL_IMG_CTRL_FORMAT_RAW12 respectively,
> + * to align the bits to the left and pad with zeros in the LSBs. The
> + * corresponding V4L2 formats are however right-aligned, so
> + * CHNL_IMG_CTRL_FORMAT_RAW16 must be used to avoid the left shift.
> + */
> +static inline bool isi_out_raw_shifted(u32 format)
> +{
> + return format == CHNL_IMG_CTRL_FORMAT_RAW10 ||
> + format == CHNL_IMG_CTRL_FORMAT_RAW12;
> +}
> +
> #endif /* __IMX8_ISI_REGS_H__ */
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c
> index 21849af3121b..365057db47bd 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c
> @@ -218,15 +218,7 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = {
> .depth = { 32 },
> .encoding = MXC_ISI_ENC_RGB,
> },
> - /*
> - * RAW formats
> - *
> - * The ISI shifts the 10-bit and 12-bit formats left by 6 and 4 bits
> - * when using CHNL_IMG_CTRL_FORMAT_RAW10 or MXC_ISI_OUT_FMT_RAW12
> - * respectively, to align the bits to the left and pad with zeros in
> - * the LSBs. The corresponding V4L2 formats are however right-aligned,
> - * we have to use CHNL_IMG_CTRL_FORMAT_RAW16 to avoid the left shift.
> - */
> + /* RAW formats */
> {
> .mbus_code = MEDIA_BUS_FMT_Y8_1X8,
> .fourcc = V4L2_PIX_FMT_GREY,
> @@ -240,7 +232,7 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = {
> .mbus_code = MEDIA_BUS_FMT_Y10_1X10,
> .fourcc = V4L2_PIX_FMT_Y10,
> .type = MXC_ISI_VIDEO_CAP,
> - .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW16,
> + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW10,
> .mem_planes = 1,
> .color_planes = 1,
> .depth = { 16 },
> @@ -249,7 +241,7 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = {
> .mbus_code = MEDIA_BUS_FMT_Y12_1X12,
> .fourcc = V4L2_PIX_FMT_Y12,
> .type = MXC_ISI_VIDEO_CAP,
> - .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW16,
> + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW12,
> .mem_planes = 1,
> .color_planes = 1,
> .depth = { 16 },
> @@ -312,7 +304,7 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = {
> .mbus_code = MEDIA_BUS_FMT_SBGGR10_1X10,
> .fourcc = V4L2_PIX_FMT_SBGGR10,
> .type = MXC_ISI_VIDEO_CAP,
> - .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW16,
> + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW10,
> .mem_planes = 1,
> .color_planes = 1,
> .depth = { 16 },
> @@ -321,7 +313,7 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = {
> .mbus_code = MEDIA_BUS_FMT_SGBRG10_1X10,
> .fourcc = V4L2_PIX_FMT_SGBRG10,
> .type = MXC_ISI_VIDEO_CAP,
> - .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW16,
> + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW10,
> .mem_planes = 1,
> .color_planes = 1,
> .depth = { 16 },
> @@ -330,7 +322,7 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = {
> .mbus_code = MEDIA_BUS_FMT_SGRBG10_1X10,
> .fourcc = V4L2_PIX_FMT_SGRBG10,
> .type = MXC_ISI_VIDEO_CAP,
> - .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW16,
> + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW10,
> .mem_planes = 1,
> .color_planes = 1,
> .depth = { 16 },
> @@ -339,7 +331,7 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = {
> .mbus_code = MEDIA_BUS_FMT_SRGGB10_1X10,
> .fourcc = V4L2_PIX_FMT_SRGGB10,
> .type = MXC_ISI_VIDEO_CAP,
> - .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW16,
> + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW10,
> .mem_planes = 1,
> .color_planes = 1,
> .depth = { 16 },
> @@ -348,7 +340,7 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = {
> .mbus_code = MEDIA_BUS_FMT_SBGGR12_1X12,
> .fourcc = V4L2_PIX_FMT_SBGGR12,
> .type = MXC_ISI_VIDEO_CAP,
> - .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW16,
> + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW12,
> .mem_planes = 1,
> .color_planes = 1,
> .depth = { 16 },
> @@ -357,7 +349,7 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = {
> .mbus_code = MEDIA_BUS_FMT_SGBRG12_1X12,
> .fourcc = V4L2_PIX_FMT_SGBRG12,
> .type = MXC_ISI_VIDEO_CAP,
> - .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW16,
> + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW12,
> .mem_planes = 1,
> .color_planes = 1,
> .depth = { 16 },
> @@ -366,7 +358,7 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = {
> .mbus_code = MEDIA_BUS_FMT_SGRBG12_1X12,
> .fourcc = V4L2_PIX_FMT_SGRBG12,
> .type = MXC_ISI_VIDEO_CAP,
> - .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW16,
> + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW12,
> .mem_planes = 1,
> .color_planes = 1,
> .depth = { 16 },
> @@ -375,7 +367,7 @@ static const struct mxc_isi_format_info mxc_isi_formats[] = {
> .mbus_code = MEDIA_BUS_FMT_SRGGB12_1X12,
> .fourcc = V4L2_PIX_FMT_SRGGB12,
> .type = MXC_ISI_VIDEO_CAP,
> - .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW16,
> + .isi_out_format = CHNL_IMG_CTRL_FORMAT_RAW12,
> .mem_planes = 1,
> .color_planes = 1,
> .depth = { 16 },
>
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2026-09-29 14:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 8:52 [PATCH v4 00/11] media: imx8-isi: Add i.MX952 ISI support Guoniu Zhou
2026-09-29 8:52 ` [PATCH v4 01/11] media: imx8-isi: Reorder mxc_imx95_data to follow mxc_imx93_data Guoniu Zhou
2026-09-29 8:52 ` [PATCH v4 02/11] media: imx8-isi: Extend output format mask to 7 bits Guoniu Zhou
2026-09-29 14:20 ` Frank Li
2026-09-29 8:52 ` [PATCH v4 03/11] media: imx8-isi: Support mbus_code filtering in format enumeration Guoniu Zhou
2026-09-29 14:22 ` Frank Li
2026-09-29 8:52 ` [PATCH v4 04/11] media: imx8-isi: Reuse mxc_isi_format_enum() in capture " Guoniu Zhou
2026-09-29 14:23 ` Frank Li
2026-09-29 8:52 ` [PATCH v4 05/11] media: imx8-isi: Apply RAW output format workaround at runtime Guoniu Zhou
2026-09-29 14:26 ` Frank Li [this message]
2026-09-29 8:52 ` [PATCH v4 06/11] media: imx8-isi: Add RAW14 output format support Guoniu Zhou
2026-09-29 14:28 ` Frank Li
2026-09-29 8:52 ` [PATCH v4 07/11] media: imx8-isi: Select MSB-aligned RAW input from pixel link on i.MX95 Guoniu Zhou
2026-09-29 14:31 ` Frank Li
2026-09-30 2:39 ` G.N. Zhou (OSS)
2026-09-29 8:52 ` [PATCH v4 08/11] media: imx8-isi: Exclude RAW10/12/14 output formats " Guoniu Zhou
2026-09-29 14:33 ` Frank Li
2026-09-29 8:52 ` [PATCH v4 09/11] media: dt-bindings: nxp,imx8-isi: Add i.MX952 ISI compatible string Guoniu Zhou
2026-09-29 8:52 ` [PATCH v4 10/11] media: imx8-isi: Add i.MX952 ISI support Guoniu Zhou
2026-09-29 8:52 ` [PATCH v4 11/11] media: imx8-isi: Enable RAW10/12/14 output LSB alignment on i.MX952 Guoniu Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arvKleQMr1mF6va5@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=guoniu.zhou@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®