mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Kanak Shilledar <Kanak.Shilledar@axis.com>,
	"andy@kernel.org" <andy@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>, Kernel <Kernel@axis.com>,
	"macromorgan@hotmail.com" <macromorgan@hotmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"joshua.crofts1@gmail.com" <joshua.crofts1@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"jean-baptiste.maneyrol@tdk.com" <jean-baptiste.maneyrol@tdk.com>,
	"dlechner@baylibre.com" <dlechner@baylibre.com>,
	"nuno.sa@analog.com" <nuno.sa@analog.com>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"jic23@kernel.org" <jic23@kernel.org>,
	Henrik Grimler <Henrik.Grimler@axis.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v6 1/6] dt-bindings: iio: imu: icm42600: Add ICM-42670-P
Date: Mon, 12 Oct 2026 19:03:40 -0300	[thread overview]
Message-ID: <as1ZPOocclBgYkko@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <da8b6047-419b-4c3d-8416-e5c871ea4dec@kernel.org>

Hi Krzysztof,

On 10/12, Krzysztof Kozlowski wrote:
> On 12/10/2026 12:43, Kanak Shilledar wrote:
> > Hi Krzystztof,
> > 
> > On Mon, 2026-10-12 at 10:58 +0200, Krzysztof Kozlowski wrote:
> >> On Fri, Oct 09, 2026 at 04:12:06PM +0200, Kanak Shilledar wrote:
> >>>    It has a configurable host interface that supports I3C, I2C and
> >>> SPI serial
> >>> -  communication, features a 2kB FIFO and 2 programmable interrupts
> >>> with
> >>> +  communication, features up to 2.25kB FIFO and 2 programmable
> >>> interrupts with
> >>>    ultra-low-power wake-on-motion support to minimize system power
> >>> consumption.
> >>>  
> >>>    Other industry-leading features include InvenSense on-chip APEX
> >>> Motion
> >>> @@ -28,6 +29,7 @@ properties:
> >>>    compatible:
> >>>      oneOf:
> >>>        - enum:
> >>> +          - invensense,icm42370p
> >>>            - invensense,icm42600
> >>>            - invensense,icm42602
> >>>            - invensense,icm42605
> >>
> >> Why aren't the interrupts required?
> > 
> > The interrupts are only required if using the device is used in
> > buffered mode. Which will be added later and the dt-binding will be
> > updated when the buffer support is added. Currently, the device works
> > without any interrupts.
> > 
> 
> That's misleading or confusing. Either the device works or does not
> without interrupt hooked up. Consult hardware datasheet if in doubts.
> 
> Driver support is different thing here and you cannot make it required
> later, because that would be unjustified ABI break.

I looked into icm42605 data sheet and saw no clear statement about the interrupts
being required. The timing diagrams only show protocol specific lines and it
looks like the interrupt sources can even be disabled (not routed out to any
interrupt pin). Maybe I'm missing something and the interrupts are required for
some sort of reset function or so? Otherwise, I don't see how the interrupts are
required.

Kanak, do you have access to any of those other chips to test whether they work
without interrupts? If possible, can you also check the data sheets for the other
parts besides icm42370p and icm42605?

Maybe
  - if:
      properties:
        compatible:
          contains:
            enum:
              - invensense,icm42600
              - invensense,icm42602
              - invensense,icm42605
              - invensense,icm42622
              - invensense,icm42631
              - invensense,icm42686
              - invensense,icm42688
    then:
      required:
        - interrupts
was a documentation mistake?

With best regards,
Marcelo

  reply	other threads:[~2026-10-12 22:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09 14:12 [PATCH v6 0/6] Add support for InvenSense ICM-42370-P accelerometer Kanak Shilledar
2026-10-09 14:12 ` [PATCH v6 1/6] dt-bindings: iio: imu: icm42600: Add ICM-42670-P Kanak Shilledar
2026-10-12  8:58   ` Krzysztof Kozlowski
2026-10-12 10:43     ` Kanak Shilledar
2026-10-12 10:46       ` Krzysztof Kozlowski
2026-10-12 22:03         ` Marcelo Schmitt [this message]
2026-10-13  7:42           ` Jean-Baptiste Maneyrol
2026-10-09 14:12 ` [PATCH v6 2/6] iio: imu: inv_icm42607: Simplify IIO channel macros Kanak Shilledar
2026-10-09 14:12 ` [PATCH v6 3/6] iio: imu: inv_icm42607: Initialize gyro based on chip_info Kanak Shilledar
2026-10-12 21:48   ` Marcelo Schmitt
2026-10-13  6:48   ` Andy Shevchenko
2026-10-09 14:12 ` [PATCH v6 4/6] iio: imu: inv_icm42607: Add support for ICM-42370-P Kanak Shilledar
2026-10-09 14:12 ` [PATCH v6 5/6] iio: imu: inv_icm42607: Implement MREGx register access Kanak Shilledar
2026-10-09 14:12 ` [PATCH v6 6/6] iio: imu: inv_icm42607: Add accelerometer calibbias support Kanak Shilledar
2026-10-12 21:55   ` Marcelo Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=as1ZPOocclBgYkko@debian-BULLSEYE-live-builder-AMD64 \
    --to=marcelo.schmitt1@gmail.com \
    --cc=Henrik.Grimler@axis.com \
    --cc=Kanak.Shilledar@axis.com \
    --cc=Kernel@axis.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jean-baptiste.maneyrol@tdk.com \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macromorgan@hotmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®