[PATCH v1 1/1] soc: qcom: cmd-db: Use %*pEhp specifier to add some sanity

[PATCH v1 1/1] soc: qcom: cmd-db: Use %*pEhp specifier to add some sanity

[Andy Shevchenko]

As Sashiko pointed out in [1] the %*pEp makes the whole thing
like "no escape". To add some sanity to this the used specifier
also includes ESCAPE_HEX.

Link: https://lore.kernel.org/r/179089728102.434549.12368098081790653201@kernel.org [1]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

Just a Link tag (no Fixes et alia) as the escaping seems to be a guard
that never fired so far.

 drivers/soc/qcom/cmd-db.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
index 3f1eee784387..bed14b92c194 100644
--- a/drivers/soc/qcom/cmd-db.c
+++ b/drivers/soc/qcom/cmd-db.c
@@ -308,7 +308,7 @@ static int cmd_db_debugfs_dump(struct seq_file *seq, void *p)
 
 		ent = rsc_to_entry_header(rsc);
 		for (j = 0; j < le16_to_cpu(rsc->cnt); j++, ent++) {
-			seq_printf(seq, "0x%05x: %*pEp", le32_to_cpu(ent->addr),
+			seq_printf(seq, "0x%05x: %*pEhp", le32_to_cpu(ent->addr),
 				   (int)strnlen(ent->id, sizeof(ent->id)), ent->id);
 
 			len = le16_to_cpu(ent->len);
-- 
2.50.1

Re: [PATCH v1 1/1] soc: qcom: cmd-db: Use %*pEhp specifier to add some sanity

[Andy Shevchenko]

On Fri, Oct 02, 2026 at 12:30:46PM +0200, Andy Shevchenko wrote:
> As Sashiko pointed out in [1] the %*pEp makes the whole thing
> like "no escape". To add some sanity to this the used specifier
> also includes ESCAPE_HEX.

Any comments on this, please?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] soc: qcom: cmd-db: Use %*pEhp specifier to add some sanity

[Dmitry Baryshkov]

On Fri, Oct 02, 2026 at 12:30:46PM +0200, Andy Shevchenko wrote:
> As Sashiko pointed out in [1] the %*pEp makes the whole thing
> like "no escape". To add some sanity to this the used specifier
> also includes ESCAPE_HEX.
> 
> Link: https://lore.kernel.org/r/179089728102.434549.12368098081790653201@kernel.org [1]
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> 
> Just a Link tag (no Fixes et alia) as the escaping seems to be a guard
> that never fired so far.
> 

The names are ASCII-only, but it's worth using escapes just in case we
parse CMD-DB incorrectly.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH v1 1/1] soc: qcom: cmd-db: Use %*pEhp specifier to add some sanity

[Abel Vesa]

On 26-10-02 12:30:46, Andy Shevchenko wrote:
> As Sashiko pointed out in [1] the %*pEp makes the whole thing
> like "no escape". To add some sanity to this the used specifier
> also includes ESCAPE_HEX.
> 
> Link: https://lore.kernel.org/r/179089728102.434549.12368098081790653201@kernel.org [1]
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>