From: Hiago De Franco <hfranco@baylibre.com>
To: Chen-Yu Yeh <chenyou910331@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <chen.wang@linux.dev>,
Inochi Amaoto <inochiama@gmail.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Longbin Li <looong.bin@gmail.com>,
"Anton D. Stavinskii" <stavinsky@gmail.com>,
Joshua Milas <josh.milas@gmail.com>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
sophgo@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] riscv: dts: sophgo: Milk-V Duo 256M ethernet support
Date: Sat, 3 Oct 2026 13:32:27 -0300 [thread overview]
Message-ID: <asEsCbfKIkXPAyCh@hiagonb> (raw)
In-Reply-To: <20261003084627.353899-1-chenyou910331@gmail.com>
On Sat, Oct 03, 2026 at 04:46:24PM +0800, Chen-Yu Yeh wrote:
> The Milk-V Duo 256M has no Ethernet connector of its own; the SG2002's
> internal PHY is only usable through the optional USB & Ethernet IO
> board. This series adds an overlay for that board and fixes the name of
> the internal PHY node it exposes.
>
> Changes in v2:
> - Enable Ethernet through an overlay instead of in the board
> devicetree, since without the IO board the pins may be used as GPIO
> (Inochi)
> - Send both patches in one thread (Inochi)
> - Test link-up and traffic on the IO board, which v1 could not
> - Collect Inochi's Reviewed-by on the PHY node name fix
>
> The overlay has the same shape as Hiago's for the Milk-V Duo [1], so the
> two boards stay consistent. The PHY node name fix is in cv180x.dtsi and
> so covers that board as well.
>
> Testing, with a kernel built from this branch:
>
> - sg2002-milkv-duo256m-eth.dtb: eth0 comes up at 100Mbps/Full, gets an
> address via DHCP and passes traffic
> - sg2002-milkv-duo256m.dtb: no eth0 is created, and the gmac node
> reads back as disabled
>
> Kernel log with sg2002-milkv-duo256m-eth.dtb:
>
> [ 1.426499] stmmaceth 4070000.ethernet: User ID: 0x10, Synopsys ID: 0x37
> [ 1.426536] stmmaceth 4070000.ethernet: DWMAC1000
> [ 6.052829] stmmaceth 4070000.ethernet eth0: PHY [mdio_mux-0.0:01] driver [Generic PHY] (irq=POLL)
> [ 8.138131] stmmaceth 4070000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx
>
> # ip addr show eth0
> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP qlen 1000
> inet 192.168.0.47/24 brd 192.168.0.255 scope global dynamic noprefixroute eth0
>
> With the base sg2002-milkv-duo256m.dtb:
>
> # ip addr show eth0
> ip: can't find device 'eth0'
> # cat /proc/device-tree/soc/ethernet@4070000/status
> disabled
>
> iperf3 against a desktop on the same switch gives 94 Mbit/s with the
> board sending and 70-74 Mbit/s with it receiving, with no
> retransmissions either way. The receive side being slower is not a CPU
> limit on the board; I have not looked into it further yet.
>
> v1: https://lore.kernel.org/sophgo/20260803163323.74414-1-chenyou910331@gmail.com/
> https://lore.kernel.org/sophgo/20260803163427.74445-1-chenyou910331@gmail.com/
>
> [1] https://lore.kernel.org/sophgo/20261001-milkv-duo-eth-overlay-v1-1-78bc1454f35b@baylibre.com/
for the series,
Reviewed-by: Hiago De Franco <hfranco@baylibre.com>
>
> Chen-Yu Yeh (2):
> riscv: dts: sophgo: add Milk-V Duo 256M ethernet support overlay
> riscv: dts: sophgo: cv180x: Fix internal ephy node name
>
> arch/riscv/boot/dts/sophgo/Makefile | 3 +++
> arch/riscv/boot/dts/sophgo/cv180x.dtsi | 2 +-
> .../dts/sophgo/sg2002-milkv-duo256m-eth.dtso | 17 +++++++++++++++++
> 3 files changed, 21 insertions(+), 1 deletion(-)
> create mode 100644 arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m-eth.dtso
>
> --
> 2.43.0
>
Best regards,
--
Hiago
prev parent reply other threads:[~2026-10-03 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 8:46 Chen-Yu Yeh
2026-10-03 8:46 ` [PATCH v2 1/2] riscv: dts: sophgo: add Milk-V Duo 256M ethernet support overlay Chen-Yu Yeh
2026-10-03 8:46 ` [PATCH v2 2/2] riscv: dts: sophgo: cv180x: Fix internal ephy node name Chen-Yu Yeh
2026-10-03 16:23 ` Hiago De Franco
2026-10-03 16:32 ` Hiago De Franco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asEsCbfKIkXPAyCh@hiagonb \
--to=hfranco@baylibre.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=chen.wang@linux.dev \
--cc=chenyou910331@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@gmail.com \
--cc=josh.milas@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=looong.bin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=sophgo@lists.linux.dev \
--cc=stavinsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®