mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] fs/iomap: document ret parameter of iomap_iter_continue
@ 2026-10-06 15:40 Muhammad Mahdi Amirpour
  2026-10-07 13:08 ` Christoph Hellwig
  2026-10-07 16:31 ` Jeremy Bingham
  0 siblings, 2 replies; 3+ messages in thread
From: Muhammad Mahdi Amirpour @ 2026-10-06 15:40 UTC (permalink / raw)
  To: Christian Brauner
  Cc: Darrick J . Wong, linux-xfs, linux-fsdevel, linux-kernel,
	Muhammad Mahdi Amirpour

Document the ret parameter of iomap_iter_continue to avoid a
kernel-doc warning.

Signed-off-by: Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>
---
 fs/iomap/iter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/iomap/iter.c b/fs/iomap/iter.c
index c445a38b6..fd8791c49 100644
--- a/fs/iomap/iter.c
+++ b/fs/iomap/iter.c
@@ -51,6 +51,7 @@ static inline void iomap_iter_done(struct iomap_iter *iter)
  * @iter: iteration structure
  * @iomap: the mapping that was just processed
  * @srcmap: the source mapping that was just processed
+ * @ret: return value from the previous mapping's ->end() callback
  *
  * Helper normally called via iomap_iter_next(). Called after the previous
  * mapping has been finished to determine whether there is more of the file
-- 
2.55.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fs/iomap: document ret parameter of iomap_iter_continue
  2026-10-06 15:40 [PATCH] fs/iomap: document ret parameter of iomap_iter_continue Muhammad Mahdi Amirpour
@ 2026-10-07 13:08 ` Christoph Hellwig
  2026-10-07 16:31 ` Jeremy Bingham
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2026-10-07 13:08 UTC (permalink / raw)
  To: Muhammad Mahdi Amirpour
  Cc: Christian Brauner, Darrick J . Wong, linux-xfs, linux-fsdevel,
	linux-kernel

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fs/iomap: document ret parameter of iomap_iter_continue
  2026-10-06 15:40 [PATCH] fs/iomap: document ret parameter of iomap_iter_continue Muhammad Mahdi Amirpour
  2026-10-07 13:08 ` Christoph Hellwig
@ 2026-10-07 16:31 ` Jeremy Bingham
  1 sibling, 0 replies; 3+ messages in thread
From: Jeremy Bingham @ 2026-10-07 16:31 UTC (permalink / raw)
  To: ampr.mhd; +Cc: brauner, djwong, linux-fsdevel, linux-kernel, Jeremy Bingham

It's a useful documentation only change, and documenting what ret does
there seems useful. For whatever it's worth,

Reviewed-by: Jeremy Bingham <jbingham@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-07 16:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-06 15:40 [PATCH] fs/iomap: document ret parameter of iomap_iter_continue Muhammad Mahdi Amirpour
2026-10-07 13:08 ` Christoph Hellwig
2026-10-07 16:31 ` Jeremy Bingham

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®