[PATCH 1/1] net: ethernet: micrel: ks8842: use dmaengine_submit() instead of ->tx_submit()

[PATCH 1/1] net: ethernet: micrel: ks8842: use dmaengine_submit() instead of ->tx_submit()

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Replace direct dma_async_tx_descriptor->tx_submit() calls with the
proper dmaengine_submit() API wrapper.

Assisted-by: LLM
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/net/ethernet/micrel/ks8842.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/micrel/ks8842.c b/drivers/net/ethernet/micrel/ks8842.c
index b7cf2ee9115fd..f0d6bfc6025ca 100644
--- a/drivers/net/ethernet/micrel/ks8842.c
+++ b/drivers/net/ethernet/micrel/ks8842.c
@@ -455,7 +455,7 @@ static int ks8842_tx_frame_dma(struct sk_buff *skb, struct net_device *netdev)
 
 	ctl->adesc->callback_param = netdev;
 	ctl->adesc->callback = ks8842_dma_tx_cb;
-	ctl->adesc->tx_submit(ctl->adesc);
+	dmaengine_submit(ctl->adesc);
 
 	netdev->stats.tx_bytes += skb->len;
 
@@ -569,7 +569,7 @@ static int __ks8842_start_new_rx_dma(struct net_device *netdev)
 
 		ctl->adesc->callback_param = netdev;
 		ctl->adesc->callback = ks8842_dma_rx_cb;
-		ctl->adesc->tx_submit(ctl->adesc);
+		dmaengine_submit(ctl->adesc);
 	} else {
 		err = -ENOMEM;
 		sg_dma_address(sg) = 0;
-- 
2.43.0

Re: [PATCH 1/1] net: ethernet: micrel: ks8842: use dmaengine_submit() instead of ->tx_submit()

[Simon Horman]

On Fri, Oct 02, 2026 at 03:30:19PM -0400, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
> 
> Replace direct dma_async_tx_descriptor->tx_submit() calls with the
> proper dmaengine_submit() API wrapper.
> 
> Assisted-by: LLM
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Hi Frank,

Is there a back-story to this change?
Is it part of something larger?

In face value it looks like a cleanup to an unmaintained driver.
And if so, I'm not sure it's worth the churn.

Re: [PATCH 1/1] net: ethernet: micrel: ks8842: use dmaengine_submit() instead of ->tx_submit()

[Vinod Koul]

On 07-10-26, 15:43, Simon Horman wrote:
> On Fri, Oct 02, 2026 at 03:30:19PM -0400, Frank.Li@oss.nxp.com wrote:
> > From: Frank Li <Frank.Li@nxp.com>
> > 
> > Replace direct dma_async_tx_descriptor->tx_submit() calls with the
> > proper dmaengine_submit() API wrapper.
> > 
> > Assisted-by: LLM
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> Hi Frank,
> 
> Is there a back-story to this change?
> Is it part of something larger?

Yep, Frank has been fixing direct calls with wrappers with aim to
eventually start moving dmaengine guts internal and have a good
consumer/provider split of the engine and objects

> In face value it looks like a cleanup to an unmaintained driver.
> And if so, I'm not sure it's worth the churn.

-- 
~Vinod