Re: [PATCH] nbcon/reboot: Flush nbcon consoles synchronously on reboot

[Petr Mladek <pmladek@suse.com>]

On Thu 2026-10-08 16:19:03, Bradley Morgan wrote:
> On 8 October 2026 16:08:52 BST, Petr Mladek <pmladek@suse.com> wrote:
> >NBCON consoles emit messages in a dedicated kthreads when the system
> >is working properly. printk() tries to flush them synchronously in
> >explicitly marked emergency context and in panic().
> >
> >Another situation where printk() could not rely on kthreads are the
> >various
> >reboot and halt code paths. They can be detected by the `system_state`
> >variable.
> >
> >Let's default to NBCON_PRIO_EMERGENCY for the post-running states.
> >printk() will automatically try flushing the consoles synchronously.
> >Also do not rely on printk() and explicitly flush the consoles
> >after these states are set.
> >
> >Note that suspend code paths have already been handled, see
> >console_suspend_all() and console_suspend().
> >
> >Reported-by: kernel test robot <lkp@intel.com>
> >Closes: https://lore.kernel.org/all/202608061008.48a1e76e-lkp@intel.com/
> >Suggested-by: John Ogness <john.ogness@linutronix.de>
> 
> Hi, this looks good to me reboot.c ended! :)
> 
> Reviewed-by: Bradley Morgan <brads@mainlining.org>

Honestly, I am more or less ignoring Reviewed-by: Bradley Morgan.
I can't recall any problem reported by this person. And the excited,
AI-generated, acks do not add much value.

> >Signed-off-by: Petr Mladek <pmladek@suse.com>
> >---
> >Hi,
> >
> >ah, this somehow fallen through cracks.
> >I am sending it as a proper patch finally.
> >
> >I am sorry I have been somehow too busy before
> >the Plumbers conference.
> 
> That's ok :) I'm too unlucky as to not go to any conferences :c

I am not sure if there will be any conferences when robots will
be ready to attend them.

Best Regards,
Petr