mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Christian Brauner <brauner@kernel.org>,
	oe-lkp@lists.linux.dev, lkp@intel.com,
	linux-serial@vger.kernel.org, oliver.sang@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nbcon/reboot: Flush nbcon consoles synchronously on reboot
Date: Fri, 9 Oct 2026 17:27:04 +0200	[thread overview]
Message-ID: <askHyBX6EPaMYnRt@pathway.suse.cz> (raw)
In-Reply-To: <87qzhzxatd.fsf@jogness.linutronix.de>

On Fri 2026-10-09 15:34:30, John Ogness wrote:
> On 2026-10-09, Petr Mladek <pmladek@suse.com> wrote:
> > Anyway, IMHO, we should switch to NBCON_PRIO_EMERGENCY for the post-running
> > states and flush the pending messages immediately. It is more
> > reliable. It is easy to find the locations when system_state() is set.
> > And all follow-up printk() calls will try the direct flush so that
> > they won't rely on an explicit flush.
> 
> We need to be careful about abusing CPU state in order to get certain
> functionality. We already have things in place to gracefully switch to
> atomic after shutting down the printing kthreads.

This explains why I see the messages even without this patch.
I wonder what is actually going on in the test.

The log contains:

</paste>
LKP: ttyS0: 256: LKP: tbox cant kexec and rebooting forcely
</paste>

I see this message in lkp-tests/bin/lkp-setup-rootfs:

<cat lkp-tests/bin/lkp-setup-rootfs>
lkp_reboot()
{
	local tbox_state="rebooting"
	[ -n "$1" ] && tbox_state="rebooting_$1"

	set_tbox_wtmp $tbox_state

	# Avoid get stuck in yocto minimal rootfs.
	# LKP: rebooting
	# [    8.124081] LKP: rebooting
	# # (shell prompt)
	is_virt && [ -e '/proc/sysrq-trigger' ] && {
		sync
		echo s >/proc/sysrq-trigger
		echo b >/proc/sysrq-trigger
	}

	start_reboot_watchdog
	reboot_tbox 2>/dev/null

	exit
}
[...]
	if tbox_cant_kexec; then
		echo_to_tty "LKP: tbox cant kexec and rebooting forcely"
		lkp_reboot "cant_kexec"
	fi
</cat lkp-tests/bin/lkp-setup-rootfs>

so, it ends with reboot_tbox which is:

<cat lkp-tests/lib/reboot.sh>
reboot_tbox()
{
	reboot
}
</cat lkp-tests/lib/reboot.sh

which is classic reboot. I am not sure where it expects the warning.
I actually can't find the code which prints:

<paste>
BUG: kernel reboot-without-warning in test stage
</paste>

I might need to try reproducing it with the lkp-test framework.
But it has to wait for the next week.

Best Regards,
Petr

      reply	other threads:[~2026-10-09 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08 15:08 Petr Mladek
2026-10-08 15:19 ` Bradley Morgan
2026-10-09  9:16   ` Petr Mladek
2026-10-09 10:52     ` Sebastian Andrzej Siewior
2026-10-09  6:51 ` Sebastian Andrzej Siewior
2026-10-09  9:08   ` Petr Mladek
2026-10-09 12:59     ` Sebastian Andrzej Siewior
2026-10-09 13:28     ` John Ogness
2026-10-09 15:27       ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=askHyBX6EPaMYnRt@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=bigeasy@linutronix.de \
    --cc=brauner@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oleg@redhat.com \
    --cc=oliver.sang@intel.com \
    --cc=ptikhomirov@virtuozzo.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®