From: Andi Shyti <andi.shyti@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Johan Hovold <johan@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: core: document preference for i2c_get_adapter_by_fwnode()
Date: Sat, 10 Oct 2026 11:57:14 +0200 [thread overview]
Message-ID: <asoLqKvJsHhkEgqi@zenone.zhora.eu> (raw)
In-Reply-To: <asjvTCazRMSNMojQ@shikoro>
Hi Johan and Wolfram,
On Fri, Oct 09, 2026 at 03:42:36PM +0200, Wolfram Sang wrote:
> On Sat, Aug 01, 2026 at 10:57:34PM +0200, Wolfram Sang wrote:
> > On Thu, Jul 16, 2026 at 03:30:29PM +0200, Johan Hovold wrote:
> > > The i2c subsystem currently blocks during adapter deregistration
> > > whenever there are consumers holding a reference.
> > >
> > > Document that i2c_get_adapter_by_fwnode(), which also takes a module
> > > reference, should almost always be preferred over
> > > i2c_find_adapter_by_fwnode() so that an attempt to unload the adapter
> > > module while in use fails gracefully instead of blocking
> > > uninterruptibly.
> > >
> > > Note that by implication of_get_i2c_adapter_by_node() is also generally
> > > preferred over of_find_i2c_adapter_by_node().
> > >
> > > Signed-off-by: Johan Hovold <johan@kernel.org>
> >
> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Andi, can we have that in 7.4 pretty please?
I was just pushing this and thanks for pinging me here last
night.
Now it's in i2c/i2c.
Thanks,
Andi
prev parent reply other threads:[~2026-10-10 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 13:30 Johan Hovold
2026-08-01 20:57 ` Wolfram Sang
2026-10-01 13:03 ` Johan Hovold
2026-10-09 13:42 ` Wolfram Sang
2026-10-10 9:57 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asoLqKvJsHhkEgqi@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=johan@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®