mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Cen Zhang <zzzccc427@gmail.com>
Cc: dhowells@redhat.com, paul@paul-moore.com, jmorris@namei.org,
	serge@hallyn.com, akpm@osdl.org, keyrings@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, baijiaju1990@gmail.com,
	jjzuming@gmail.com
Subject: Re: [PATCH] KEYS: Protect user key quota access during instantiation
Date: Mon, 12 Oct 2026 16:49:55 +0300	[thread overview]
Message-ID: <aszlg2R3E7zqR75r@kernel.org> (raw)
In-Reply-To: <CAFRLqsUB0MQRoCHg8cXmyofWqbDGyvAr7vV07i0jUpMnSaksVQ@mail.gmail.com>

On Mon, Oct 12, 2026 at 09:30:43PM +0800, Cen Zhang wrote:
> Hi Jarkko,
> 
> Thanks very much for the detailed feedback and for your patience with this :).
> 
> Jarkko Sakkinen <jarkko@kernel.org> 于2026年10月12日周一 21:03写道:
> >
> >
> > I appreciate the fix but if I'm completely hones the commit message
> > looks like direct LLM output, which is not acceptable.
> >
> > It needs to be proof-readed and edited. For this reason, I want a better
> > iteration before I apply this.
> >
> > Br, Jarkko
> 
> Thanks very much for the detailed feedback and for your patience with this.
> 
> Several people have mentioned that my commit messages look like they were
> generated by an LLM — and to be honest, I did write them with LLM assistance.
> However, they often gave me the feeling of being questioned rather
> than explained.
> I spend most of my time looking for bugs, following my interest, so
> I’m more familiar
> with bug patterns than with the deeper details of the subsystem. That
> means I can
> make mistakes. I’m willing to listen to feedback and keep revising the
> patch until it’s in
> good shape, but the pressure sometimes makes me afraid to continue the
> conversation,
> worried about making more mistakes. Your patient explanation this time
> really means a
> lot to me.
> 
> Of course, I also fully understand that busy developers feel
> uncomfortable when seeing
> unclear or poorly written messages. I just wanted to express my thanks
> for taking the time
> to gently and patiently explain things clearly.
> 
> I’ll carefully rework the commit message following your suggestions to
> make the concurrency
> scenario and the reasoning clearer, and send a new patch once it’s
> ready. I’d appreciate it if
> you could take another look then.

While AI assistance is allowed, if this happens as a pattern, it is
misuse and eager way to credit without due. I.e., you've done 50%
of the work but ignored the human part.

I.e., you also must understand without AI assistance what
the patch does. If you do, it should not a problem to write
a commit message tht simply describes what it does.

To summarize:

1. Actual mistakes are fine and then patch just needs to be iterated.
2. Skipping work is not mistake and it is not cool.

Hope this clears things up.

> 
> Best regards,
> Cen Zhang

Br, Jarkko

  parent reply	other threads:[~2026-10-12 13:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12  3:15 Cen Zhang
2026-10-12 13:00 ` Jarkko Sakkinen
2026-10-12 13:03   ` Jarkko Sakkinen
2026-10-12 13:30     ` Cen Zhang
2026-10-12 13:33       ` Cen Zhang
2026-10-12 15:01         ` Jarkko Sakkinen
2026-10-12 13:49       ` Jarkko Sakkinen [this message]
2026-10-12 13:59         ` Cen Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aszlg2R3E7zqR75r@kernel.org \
    --to=jarkko@kernel.org \
    --cc=akpm@osdl.org \
    --cc=baijiaju1990@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=jjzuming@gmail.com \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=zzzccc427@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®