From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: "James Hilliard" <james.hilliard1@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Raul E Rangel" <rrangel@chromium.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Tony Lindgren" <tony@atomide.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Richard Genoud" <richard.genoud@bootlin.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Jacky Huang" <ychuang3@nuvoton.com>,
"Shan-Chun Hung" <schung@nuvoton.com>,
"Pali Rohár" <pali@kernel.org>, "Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Timur Tabi" <timur@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v5 2/5] serial: serialize asynchronous write wakeups with the port lock
Date: Sun, 25 Oct 2026 17:09:55 +0200 [thread overview]
Message-ID: <at4bw-G8czG-G7Wl@ashevche-desk.local> (raw)
In-Reply-To: <alpine.DEB.2.21.2610250459200.42255@angie.orcam.me.uk>
On Sun, Oct 25, 2026 at 05:10:03AM +0000, Maciej W. Rozycki wrote:
> On Sat, 24 Oct 2026, James Hilliard wrote:
>
> > uart_write_wakeup() expects the UART port lock to be held. Several worker,
> > DMA completion and interrupt paths call it without that lock, including
> > indirect calls from uart_handle_cts_change() and the transmit helpers.
>
> Fair enough, and thank you for the cleanup and spotting the issue in the
> first place, however...
He already issues a v6. I think the tactics against AI contributions should be
to not answer for a week or so until there will be a quiescent week. At least
that's what I learn from this patch storm.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-25 15:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 6:40 [PATCH v5 0/5] serial: 8250: serialize DMA cancellation with buffer reuse James Hilliard
2026-10-24 6:40 ` [PATCH v5 1/5] serial: 8250_omap: separate locked TX DMA completion processing James Hilliard
2026-10-24 6:40 ` [PATCH v5 2/5] serial: serialize asynchronous write wakeups with the port lock James Hilliard
2026-10-25 5:10 ` Maciej W. Rozycki
2026-10-25 15:09 ` Andy Shevchenko [this message]
2026-10-25 20:25 ` James Hilliard
2026-10-25 20:44 ` Andy Shevchenko
2026-10-25 22:11 ` James Hilliard
2026-10-26 9:31 ` Andy Shevchenko
2026-10-26 16:45 ` James Hilliard
2026-10-26 19:53 ` Andy Shevchenko
2026-10-26 19:59 ` James Hilliard
2026-10-26 20:17 ` Greg Kroah-Hartman
2026-10-26 20:24 ` James Hilliard
2026-10-26 20:40 ` Greg Kroah-Hartman
2026-10-26 20:49 ` James Hilliard
2026-10-26 21:23 ` Andy Shevchenko
2026-10-26 21:36 ` Maciej W. Rozycki
2026-10-26 20:18 ` Andy Shevchenko
2026-10-25 18:47 ` James Hilliard
2026-10-24 6:40 ` [PATCH v5 3/5] serial: core: allow drivers to reserve flushed transmit storage James Hilliard
2026-10-24 6:40 ` [PATCH v5 4/5] serial: 8250: drain canceled TX DMA before reusing its buffer James Hilliard
2026-10-24 6:40 ` [PATCH v5 5/5] serial: 8250: retire canceled RX DMA before reusing the receive buffer James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at4bw-G8czG-G7Wl@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bigeasy@linutronix.de \
--cc=claudiu.beznea@tuxon.dev \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=imx@lists.linux.dev \
--cc=james.hilliard1@gmail.com \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=macro@orcam.me.uk \
--cc=nicolas.ferre@microchip.com \
--cc=pali@kernel.org \
--cc=richard.genoud@bootlin.com \
--cc=rrangel@chromium.org \
--cc=s.hauer@pengutronix.de \
--cc=schung@nuvoton.com \
--cc=timur@kernel.org \
--cc=tony@atomide.com \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®