From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Victor Chernyakin <chernyakin.victor.j@outlook.com>
Cc: andy@kernel.org, dlechner@baylibre.com, jic23@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
nuno.sa@analog.com
Subject: Re: [PATCH v2 0/3] iio: cdc: add Texas Instruments FDC1004 driver
Date: Mon, 26 Oct 2026 11:35:43 +0200 [thread overview]
Message-ID: <at8e77xcrCAxDiWu@ashevche-desk.local> (raw)
In-Reply-To: <SN1PR12MB2528B7C10FBE90A0B31BE375A5622@SN1PR12MB2528.namprd12.prod.outlook.com>
On Sun, Oct 25, 2026 at 04:35:36PM -0500, Victor Chernyakin wrote:
> > > Changes in v2:
> > > - Patch 1
> > > - Added tests
> >
> > > - Added a fix in iio_format_value
> >
> > If it's about abs(), it should go in a separate patch.
>
> This is about both abs() and working around overflow when
> computing 10^scale. To be clear, neither of these were problems before,
> they're directly caused by the new units. You're saying they should still
> go in a separate patch?
For a starter I'm saying that changelog should be more elaborative.
But conduct a small research and check if it's possible to split. One fix per
problem is what we want ideally. However, there are other aspects are being
involved (in all steps), such as code readability and additional churn made.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-26 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 5:48 Victor Chernyakin
2026-10-25 5:48 ` [PATCH v2 1/3] iio: add IIO_VAL_DECIMAL64_{ATTO,ZEPTO,YOCTO} formats Victor Chernyakin
2026-10-25 19:41 ` Andy Shevchenko
2026-10-25 5:48 ` [PATCH v2 2/3] dt-bindings: iio: cdc: add Texas Instruments FDC1004 Victor Chernyakin
2026-10-26 13:04 ` Krzysztof Kozlowski
2026-10-25 5:48 ` [PATCH v2 3/3] iio: cdc: add Texas Instruments FDC1004 driver Victor Chernyakin
2026-10-25 21:24 ` Andy Shevchenko
2026-10-25 20:47 ` [PATCH v2 0/3] " Andy Shevchenko
2026-10-25 21:35 ` Victor Chernyakin
2026-10-26 9:35 ` Andy Shevchenko [this message]
2026-10-25 22:26 ` [PATCH v2 3/3] " Victor Chernyakin
2026-10-26 9:43 ` Andy Shevchenko
2026-10-25 22:39 ` [PATCH v2 0/3] " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at8e77xcrCAxDiWu@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=chernyakin.victor.j@outlook.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®