[PATCH v2] staging: fbtft: Remove unused fbtft_init_dbg()

[PATCH v2] staging: fbtft: Remove unused fbtft_init_dbg()

[himanshu bakshi]

From: Himanshu Bakshi <himanshu.bakshi478@gmail.com>

The fbtft_init_dbg() macro is not being used, so delete it.

Reviewed-by: Dan Carpenter error27@gmail.com

Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
---
 drivers/staging/fbtft/fbtft.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 40a7567df1eb..16459e4e0ba0 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -420,13 +420,6 @@ module_spi_driver(fbtft_driver_spi_driver);
 #define DEBUG_REQUEST_GPIOS_MATCH   BIT(30)
 #define DEBUG_VERIFY_GPIOS          BIT(31)
 
-#define fbtft_init_dbg(dev, format, arg...)                  \
-do {                                                         \
-	if (unlikely((dev)->platform_data &&                 \
-	    (((struct fbtft_platform_data *)(dev)->platform_data)->display.debug & DEBUG_DRIVER_INIT_FUNCTIONS))) \
-		dev_info(dev, format, ##arg);                \
-} while (0)
-
 #define fbtft_par_dbg(level, par, format, arg...)            \
 do {                                                         \
 	if (unlikely((par)->debug & (level)))                    \
-- 
2.56.0

Re: [PATCH v2] staging: fbtft: Remove unused fbtft_init_dbg()

[Himanshu Bakshi]

On Mon, Oct 26, 2026 at 2:54 PM himanshu bakshi
<himanshu.bakshi478@gmail.com> wrote:
>
> From: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
>
> The fbtft_init_dbg() macro is not being used, so delete it.
>
> Reviewed-by: Dan Carpenter error27@gmail.com
>
> Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
> ---
>  drivers/staging/fbtft/fbtft.h | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> index 40a7567df1eb..16459e4e0ba0 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -420,13 +420,6 @@ module_spi_driver(fbtft_driver_spi_driver);
>  #define DEBUG_REQUEST_GPIOS_MATCH   BIT(30)
>  #define DEBUG_VERIFY_GPIOS          BIT(31)
>
> -#define fbtft_init_dbg(dev, format, arg...)                  \
> -do {                                                         \
> -       if (unlikely((dev)->platform_data &&                 \
> -           (((struct fbtft_platform_data *)(dev)->platform_data)->display.debug & DEBUG_DRIVER_INIT_FUNCTIONS))) \
> -               dev_info(dev, format, ##arg);                \
> -} while (0)
> -
>  #define fbtft_par_dbg(level, par, format, arg...)            \
>  do {                                                         \
>         if (unlikely((par)->debug & (level)))                    \
> --
> 2.56.0
>

Hi Andy,

For testing, I have compiled the driver successfully and
verified that  fbtft_init_dbg() has no call sites in the kernel
tree.

Thank you for the review.

Thanks and Regards,
Himanshu Bakshi

Re: [PATCH v2] staging: fbtft: Remove unused fbtft_init_dbg()

[Andy Shevchenko]

On Mon, Oct 26, 2026 at 02:54:23PM +0530, himanshu bakshi wrote:
> 
> The fbtft_init_dbg() macro is not being used, so delete it.
> 
> Reviewed-by: Dan Carpenter error27@gmail.com
> 

No blank line in the tag block.

> Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
> ---

You must learn to provide a changelog!
What has been changed? Why (whose request was that)?

>  drivers/staging/fbtft/fbtft.h | 7 -------
>  1 file changed, 7 deletions(-)

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] staging: fbtft: Remove unused fbtft_init_dbg()

[Himanshu Bakshi]

On Mon, Oct 26, 2026 at 3:18 PM Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
> You must learn to provide a changelog!
> What has been changed? Why (whose request was that)?

Hi Andy,

Thanks for clarifying. I have sent the v3 patch and
added what you requested.

Thanks and regards,
Himanshu Bakshi

Re: [PATCH v2] staging: fbtft: Remove unused fbtft_init_dbg()

[Dan Carpenter]

On Mon, Oct 26, 2026 at 02:54:23PM +0530, himanshu bakshi wrote:
> From: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
> 
> The fbtft_init_dbg() macro is not being used, so delete it.
> 
> Reviewed-by: Dan Carpenter error27@gmail.com

This is formatted incorrectly.

> 

Don't add a blank line in the middle of the Tag block.
Tags are supposed to be in chronological order.  So Acks come
after the S-o-by tag.

> Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
> ---

No v2 text.

Please, wait a day between resends, even for small things.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter

Re: [PATCH v2] staging: fbtft: Remove unused fbtft_init_dbg()

[Himanshu Bakshi]

Hi Dan,

Thanks for letting me know. I have already
sent the v3 patch, so I apologize for not waiting for
a day. I will keep it in mind.

Thanks and Regards,
Himanshu Bakshi

On Mon, Oct 26, 2026 at 3:35 PM Dan Carpenter <error27@gmail.com> wrote:
>
> On Mon, Oct 26, 2026 at 02:54:23PM +0530, himanshu bakshi wrote:
> > From: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
> >
> > The fbtft_init_dbg() macro is not being used, so delete it.
> >
> > Reviewed-by: Dan Carpenter error27@gmail.com
>
> This is formatted incorrectly.
>
> >
>
> Don't add a blank line in the middle of the Tag block.
> Tags are supposed to be in chronological order.  So Acks come
> after the S-o-by tag.
>
> > Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
> > ---
>
> No v2 text.
>
> Please, wait a day between resends, even for small things.
>
> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
>
> regards,
> dan carpenter
>

Re: [PATCH v2] staging: fbtft: Remove unused fbtft_init_dbg()

[Dan Carpenter]

On Mon, Oct 26, 2026 at 03:52:43PM +0530, Himanshu Bakshi wrote:
> Hi Dan,
> 
> Thanks for letting me know. I have already
> sent the v3 patch, so I apologize for not waiting for
> a day. I will keep it in mind.

Thanks.

regards,
dan carpenter