* [PATCH v3] staging: fbtft: remove unused fbtft_init_dbg()
@ 2026-10-26 10:18 himanshu bakshi
2026-10-26 10:29 ` Dan Carpenter
2026-10-26 10:47 ` Andy Shevchenko
0 siblings, 2 replies; 3+ messages in thread
From: himanshu bakshi @ 2026-10-26 10:18 UTC (permalink / raw)
To: andy, gregkh
Cc: dennylin0707, cenzhang, dri-devel, linux-fbdev, linux-staging,
linux-kernel, error27, Himanshu Bakshi
From: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
The fbtft_init_dbg() macro is not being used, so delete it.
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
---
Changes in v3:
- Fix tag formatting as requested by Andy Shevchenko.
- Add revision history and testing details following review feedback.
Testing:
- Built the fbtft driver successfully.
- Verified that fbtft_init_dbg() has no call sites in the kernel
tree.
---
drivers/staging/fbtft/fbtft.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 40a7567df1eb..16459e4e0ba0 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -420,13 +420,6 @@ module_spi_driver(fbtft_driver_spi_driver);
#define DEBUG_REQUEST_GPIOS_MATCH BIT(30)
#define DEBUG_VERIFY_GPIOS BIT(31)
-#define fbtft_init_dbg(dev, format, arg...) \
-do { \
- if (unlikely((dev)->platform_data && \
- (((struct fbtft_platform_data *)(dev)->platform_data)->display.debug & DEBUG_DRIVER_INIT_FUNCTIONS))) \
- dev_info(dev, format, ##arg); \
-} while (0)
-
#define fbtft_par_dbg(level, par, format, arg...) \
do { \
if (unlikely((par)->debug & (level))) \
--
2.56.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] staging: fbtft: remove unused fbtft_init_dbg()
2026-10-26 10:18 [PATCH v3] staging: fbtft: remove unused fbtft_init_dbg() himanshu bakshi
@ 2026-10-26 10:29 ` Dan Carpenter
2026-10-26 10:47 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2026-10-26 10:29 UTC (permalink / raw)
To: himanshu bakshi
Cc: andy, gregkh, dennylin0707, cenzhang, dri-devel, linux-fbdev,
linux-staging, linux-kernel
Please always wait a day between resends...
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] staging: fbtft: remove unused fbtft_init_dbg()
2026-10-26 10:18 [PATCH v3] staging: fbtft: remove unused fbtft_init_dbg() himanshu bakshi
2026-10-26 10:29 ` Dan Carpenter
@ 2026-10-26 10:47 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2026-10-26 10:47 UTC (permalink / raw)
To: himanshu bakshi
Cc: andy, gregkh, dennylin0707, cenzhang, dri-devel, linux-fbdev,
linux-staging, linux-kernel, error27
On Mon, Oct 26, 2026 at 03:48:15PM +0530, himanshu bakshi wrote:
>
> The fbtft_init_dbg() macro is not being used, so delete it.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Next time wait at least 24h before resend.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-26 10:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-26 10:18 [PATCH v3] staging: fbtft: remove unused fbtft_init_dbg() himanshu bakshi
2026-10-26 10:29 ` Dan Carpenter
2026-10-26 10:47 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®